Commit Graph

5914 Commits

Author SHA1 Message Date
wangyunjian
bd26d38569 THRIFT-5094: Fix memory leak in thrift_server_set_property()
Client: c_glib
Patch: wangyunjian

This closes #2008

Signed-off-by: wangyunjian <wangyunjian@huawei.com>
2020-02-21 21:25:45 +01:00
wangyunjian
d8480c9ac1 THRIFT-5101: Return NULL install of FALSE for thrift_server_socket_accept()
Client: c_glib
Patch: wangyunjian

This closes #2011

Signed-off-by: wangyunjian <wangyunjian@huawei.com>
2020-02-21 21:15:29 +01:00
Jeffrey Han
7b712f42d7 THRIFT-5106: Fix various Lua library and compiler issues
Client: lua
Patch: Jeffrey Han

This closes #2014
2020-02-21 21:08:19 +01:00
Jens Geyer
222362cc70 THRIFT-5095 ToString() should print entire structure, not just the top-level data
Client: netstd
Patch: Jens Geyer

This closes #2009
2020-02-16 13:19:43 +01:00
Tobias Mayer
c8e46cf861 THRIFT-5097: Fix exported version in cmake module
Patch: Tobias Mayer

This closes #2010
2020-02-16 13:18:24 +01:00
Jens Geyer
bb5f7ec6b0 THRIFT-5091 Netstd generator produces uncompileable code for struct names ending with "_result" or "_args"
Client: netstd
Patch: Jens Geyer

THis closes #2006
2020-02-14 09:15:17 +01:00
Renan I. Del Valle
aa9e7e8f59 THRIFT-5092: Return an error instead of causing a panic when attempting to write to a closed client.
Client: go
Patch: Renan I. Del Valle

This closes #2005
2020-02-13 22:42:14 +01:00
Jens Geyer
b012318fc8 THRIFT-5088 Memory leak in TWinHttpTransport
Client: Delphi
Patch: Jens Geyer
2020-02-12 22:40:42 +01:00
Homarechan
ded326101a THRIFT-5072 Fix data type generation.
Client: hs
Patch: Homarechan <tikuwakunn@icloud.com>

This closes #1974
2020-02-06 23:21:02 +01:00
Gaurav Singh
7d30e2c0b6 (no ticket) catch exception by ref
Patch: Gaurav Singh

This closes #1998
2020-02-06 23:10:08 +01:00
Gaurav Singh
77c4afae16 (no ticket) Propagate exception instead of rethrowing
Client: cpp
Patch: Gaurav Singh

This closes #1999
2020-02-06 23:06:07 +01:00
Jens Geyer
baddaa8612 THRIFT-5086 CMake target thrift::thrift has no INTERFACE_INCLUDE_DIRECTORIES property
Client: cpp
Patch: SmartNet Club

This closes #2003
2020-02-06 22:59:31 +01:00
Cameron Rollheiser
b576ae91f0 (no ticket) Document Docker Build JS Versions [skip ci]
Client: docs
Patch: Cameron Rollheiser

This closes #1976
2020-02-05 22:40:21 +01:00
Srinivas Reddy
68b113a73e (no ticket) Improved formatting
Client: doc
Patch: Srinivas Reddy

This closes #1989
2020-02-05 22:36:33 +01:00
Paulo Neves
f049ff374d THRIFT-5083 Reset context on new messages.
Client: netstd
Patch: Paulo Neves

This closes #
2020-02-05 21:40:16 +01:00
Christopher Friedt
f8b004081d
Fix typo for python 3 support
This change simply enables the existing check in configure.ac to function as intended.

Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
2020-01-29 08:03:46 +00:00
Kengo Seki
cb4c31a072 THRIFT-5050 Fix MemoryBuffer.pm to raise a proper exception if no data is available
Client: perl
Patch: Kengo Seki

This closes #1967
2020-01-28 23:27:48 +01:00
Nick Collier
e56f717b7f THRIFT-5078 Handle named pipe clients quickly disconnecting
Client: C++
Patch: Nick Collier

This closes #1964
2020-01-28 23:20:40 +01:00
David Mollitor
e8f82da45e THRIFT-5016 Do Not Check 'other' For Null in Equals
Client: Java
Patch: David Mollitor

This closes #1937
2020-01-28 22:53:58 +01:00
Sam De Roeck
436bce3321 (no ticket) Gracefully terminate the connection handling loop when encountering EOF on the transport layer
Client: Rust
Patch: Sam De Roeck

This closes #1928
2020-01-28 22:47:55 +01:00
Jens Geyer
a86a3549cf THRIFT-5074 Cleanup of test suite command line options
Client: Documentation
Patch: Jens Geyer & Kengo Seki

This closes #1990
2020-01-23 23:17:00 +01:00
Cameron Rollheiser
3a2a44bb51 Remove non-required JS dependencies
These dependencies are not needed at runtime.

Client: js
2020-01-21 17:02:22 +00:00
JackBoosY
829b7d330d Add vcpkg installation instructions
Patch: JackBoosY, edited by JensG

This closes #1986
2020-01-19 23:00:32 +01:00
Kengo Seki
d082d1d61b THRIFT-5052: Make the Go tutorial executable to the end
Client: Go
Patch: Kengo Seki

This closes #1969
2020-01-19 22:33:58 +01:00
Kengo Seki
c97e6aa860 THRIFT-5060: Add cross tests for TZlibTransport in Java
Client: Java
Patch: Kengo Seki

This closes #1978
2020-01-19 22:26:09 +01:00
Kengo Seki
46554d0a4c THRIFT-5051: Fix Python tutorials to address THRIFT-4002
Client: Python
Patch: Kengo Seki

This closes #1968
2020-01-19 22:18:52 +01:00
Kengo Seki
1c789cea1e THRIFT-5065: Fix broken links in the IDL document
Patch: Kengo Seki
This closes #1983
2020-01-19 22:13:16 +01:00
Yuxuan 'fishy' Wang
397645ac24 THRIFT-5069: Make TDeserializer resource pool friendly
Client: go

This change improves performance when using TDeserializer with a
resource pool. See https://issues.apache.org/jira/browse/THRIFT-5069 for
more context.

Also add TSerializerPool and TDeserializerPool, which are thread-safe
versions of TSerializer and TDeserializer. Benchmark result shows that
they are both faster and use less memory than the plain version:

    $ go test -bench Serializer -benchmem
    goos: darwin
    goarch: amd64
    BenchmarkSerializer/baseline-8            577558              1930 ns/op             512 B/op          6 allocs/op
    BenchmarkSerializer/plain-8               452712              2638 ns/op            2976 B/op         16 allocs/op
    BenchmarkSerializer/pool-8                591698              2032 ns/op             512 B/op          6 allocs/op
    PASS
2020-01-18 20:55:51 +00:00
Christopher Tubbs
a5ec666e1b THRIFT-5068: Force secure Maven Central in Travis CI
Modify docker build scripts used in CI test environments in order to put
in place a Maven .m2/settings.xml configuration file that overrides the
repository with the id 'central' with an equivalent "mirror" that uses
https instead of http.

This closes #1988.
2020-01-17 12:33:38 +00:00
D. Can Celasun
70c4e7a7c7
Use HTTPS for repo1.maven.org
Upstream no longer supports plain HTTP as of today [1].

[1] https://support.sonatype.com/hc/en-us/articles/360041287334
2020-01-15 21:13:50 +00:00
Kengo Seki
45a94594ff THRIFT-5061: Pin Ruby's rack version to 2.0.8
Client: ruby
Patch: Kengo Seki

This closes #1980
2020-01-11 12:57:53 +01:00
Kengo Seki
bee4f2fd69 THRIFT-5053: Fix the netstd tutorial console logging and README
Client: netstd
Patch: Kengo Seki

This closes #1970
2020-01-11 00:52:42 +01:00
Eugen
30ac2598e8 THRIFT-5003: Websocket Connection in Browsers with nodejs code
* changed this to self in forEach callback

* updated minimum node version to 8.16.2 (Maintenance LTS until December 2019)
changed ws_connection.js to work in the browser, with isomorphic-ws
added exports for `wsConnection`, `createWSConnection`, `createWSClient`

* added exports for WSConnection to browser.js

* extended the sample of nodejs code in the browser with webpack

* tested and updated node version to LTS 10.18.0 Dubnium
discussion based: https://github.com/apache/thrift/pull/1927#discussion_r358140463
2020-01-07 14:28:45 +00:00
Allen George
6e443789e9
Merge pull request #1919 from mpajkowski/to_socket_addrs
THRIFT-4995 Use `ToSocketAddrs` for expressing network addresses
2019-12-14 09:52:36 -05:00
belugabehr
44d8cc6b43 THRIFT-5014: Do Direct Comparison on Raw Values Instead of Objects
Client: java

This closes #1935.
2019-12-14 09:33:37 +00:00
Duru Can Celasun
b374ce3555
THRIFT-5046: Better struct tag overrides
Custom go.tag in an IDL no longer removes the existing "db" and "json"
tags but can override them.

This allows us to change default tags in the future without affecting
user defined ones.

Client: go

This closes #1963.
2019-12-13 13:10:23 +00:00
belugabehr
418d88b447 THRIFT-5013: Replace NullPointerException with RequireNonNull
Co-Authored-By: Christopher Tubbs <ctubbsii@apache.org>

Client: java

This closes #1934.
2019-12-13 09:13:12 +00:00
Kevin Wojniak
0ebf3ce99d Fix uint64_t to size_t conversion warning
Fixes an MSVC warning with an explicit cast.

Client: cpp
2019-12-12 23:42:00 +00:00
Duru Can Celasun
dfae5d7f4a
THRIFT-4252: Close sockets when shut down server (#1905)
* THRIFT-4252: Close sockets when shut down server

In TThreadPoolServer, threads are blocking in io with open sockets,
as long as clients don't close the connection, server threads are
never stopped even after a shutdown is called on server (because
they are blocked waiting for io).
To be able to stop all server threads properly, server should
proactively close sockets once a shutdown is initiated.

* Fix indentation

Use white space for indentation instead of tabulation.
2019-12-12 23:34:48 +00:00
Jens Geyer
6e2a6983ec THRIFT-5048 EnumUtils<T>.ToString() throws for elements not known to the receiving end [ci skip]
Client: Delphi
Patch: Jens Geyer
2019-12-13 00:33:46 +01:00
Kengo Seki
f1c53418a7 THRIFT-4974: Add cross test for Python's Unix domain socket transport
Client: Python

This closes #1896.
2019-12-12 23:09:36 +00:00
Anton Golub
cf95fef9b8 THRIFT-5029: Fix Node.js lib entry point
Client: js
2019-12-12 22:30:07 +00:00
Elvis Pranskevichus
9c43962da8 Revert "Revert "THRIFT-4002: Make generated exception classes immutable by default""
This reverts commit 1234ddf8a5.
2019-12-12 13:50:42 +00:00
Elvis Pranskevichus
9320f891d7 Revert "Revert "Remove unnecessary TException.message hack""
This reverts commit 3d9f50d617.
2019-12-12 13:50:42 +00:00
Qinghui Xu
6e023df1de THRIFT-4889 Nonblocking server with sasl support
Client: Java
Patch: Qinghui Xu

This closes #1892
2019-12-10 23:57:35 +01:00
Qinghui Xu
3a0e1fd356 THRIFT-5008: Improve TSaslTransport logging
Client: Java
Patch: Qinghui Xu

This closes #1931
2019-12-10 23:25:15 +01:00
D. Can Celasun
3d9f50d617
Revert "Remove unnecessary TException.message hack"
This reverts commit 45a9827f0f.
2019-12-10 22:13:19 +00:00
D. Can Celasun
1234ddf8a5
Revert "THRIFT-4002: Make generated exception classes immutable by default"
This reverts commit b40f5c227f.
2019-12-10 22:13:06 +00:00
Elvis Pranskevichus
b40f5c227f
THRIFT-4002: Make generated exception classes immutable by default
Currently, the generated exception classes are not hashable under
Python 3 because of the generated `__eq__` method.  Exception objects
are generally expected to be hashable by the Python standard library.
Post-construction mutation of an exception object seems like a very
unlikely case, so enable hashing for all exceptions by making them
immutable by default.  This also adds a way to opt-out of immutability
by setting the `python.immutable` annotation to `"false"`.
2019-12-10 20:44:24 +00:00
Elvis Pranskevichus
45a9827f0f
Remove unnecessary TException.message hack
Thrift attempts to work-around the Python 2.7 DeprecationWarning
around `BaseException.message` by using a property.  This hack is
unnecessary since `message` is _also_ written as a regular attribute in
the `TException` constructor (and would be in any of its children),
hence the `BaseException_get_message()` wouldn't even be called.

This hack also stands in the way of making exception instances
immutable (which is a prerequisute to fixing THRIFT-4002).
2019-12-10 20:44:22 +00:00