Commit Graph

6443 Commits

Author SHA1 Message Date
Yuxuan 'fishy' Wang
6f33b04706 THRIFT-5509: Close connection in IsOpen
Client: go

When the connectivity check failed in IsOpen, close the connection
explicitly to avoid connection leaks.

This is Path 2 of THRIFT-5509.
2022-02-03 16:11:20 -08:00
Jens Geyer
af453f33c4 minor indent fixes 2022-02-01 23:51:00 +01:00
Jens Geyer
9a16c755b1 THRIFT-5504 CA2254 Message template should be compile time constant
Client netstd
Patch: Jens Geyer
2022-02-01 08:55:05 +01:00
Jens Geyer
69b66a51f2 THRIFT-5506 C26495 variable "t_field::req_" not initialized, t_field.h:40
Compiler General
Patch: Jens Geyer
2022-01-30 01:09:06 +01:00
Jens Geyer
a0cd3cfc84 THRIFT-5505 error: 'close_generator' overrides a member function but is not marked 'override'
Client: netstd
Patch: Jens Geyer
2022-01-30 01:09:06 +01:00
Yuxuan 'fishy' Wang
eadbd9cd36 Fix travis issue caused by 5f16344311 2022-01-29 18:50:01 +01:00
Yuxuan 'fishy' Wang
c4f2ba1173 Fix the travis issue
For example [1]:

    FAILURE: Build failed with an exception.
    * Where:
    Script '/thrift/src/thrift-0.17.0/lib/java/gradle/generateTestThrift.gradle' line: 40
    * What went wrong:
    A problem occurred evaluating script.
    > assert thriftFile.exists()
             |          |
             |          false
             /thrift/src/thrift-0.17.0/test/partial/thrift_test_schema.thrift

[1]: https://app.travis-ci.com/github/apache/thrift/jobs/557030315
2022-01-27 07:38:24 -08:00
Jens Geyer
561bc9ab79 THRIFT-5504 CA2254 Message template should be compile time constant
Client netstd
Patch: Jens Geyer
2022-01-27 08:51:15 +01:00
くらげ
bf0967537b Fixed proxy related bugs 2022-01-26 23:00:04 +01:00
ihciah
5f16344311 fix wrong thrift strict header comparing 2022-01-26 22:56:08 +01:00
Jens Geyer
febc5121ea Updated changes.md for 0.16.0 2022-01-21 09:38:55 +01:00
Jonas Marty
86763a1681 Fixes #5500, uncompilable code when a .thirft struct named 'System' is present 2022-01-20 22:13:40 +01:00
Jens Geyer
6868ebbb31 Release 0.16.0 2022-01-20 21:02:02 +01:00
Jens Geyer
7a6829531f 2022 we have 2022-01-20 20:48:15 +01:00
Mario Emmenlauer
b1dc2aeb48
Merge pull request #2505 from dsandbrink/patch-1
Fix warning C4515: 'protocol': namespace uses itself
2022-01-18 00:09:30 -08:00
Mario Emmenlauer
11dc245c40
Merge pull request #2504 from dsandbrink/bugfix/thrift_5418
THRIFT-5418: C++ to_string and ostream operator not always generated
2022-01-18 00:08:37 -08:00
Dirk Sandbrink
d3f13f0907 THRIFT-5418: Fix missing implementation for enum functions
If a thrift file only contains an enum, then the c++ source file with
the implementation for to_string and ostream operator<< is not
generated.
This bug was introduced in PR#2095 / THRIFT-5168.
2022-01-17 23:25:42 +01:00
Dirk Sandbrink
b3cf198058 Fix warning C4515: 'protocol': namespace uses itself
This warning can been seen when compiling generated code using Visual Studio 16.11.
2022-01-17 23:23:50 +01:00
Mario Emmenlauer
16b490ce1f
Merge pull request #2506 from BioDataAnalysis/bda_remove_jcenter
lib/java/build.gradle: Removed jcenter() after repeated errors
2022-01-17 14:02:34 -08:00
Mario Emmenlauer
e07cdcce8d lib/java/build.gradle: Removed jcenter() after repeated errors 2022-01-17 19:14:56 +01:00
Yuxuan 'fishy' Wang
bbc7c5f65e Bump the versions of Go used in Travis
Bump the versions of Go used in Travis to the latest point releases in
preparing for the upcoming v0.16.0 release.

Also switch the go download URL to the new go.dev domain.

Also update LANGUAGES.md accordingly, and mark that we support THeader
in Go now (we added the support in v0.13.0, just forgot to update
LANGUAGES.md accordingly).
2022-01-11 13:44:23 -08:00
Jens Geyer
98a232577f THRIFT-5479 Add net 6 support 2022-01-09 21:57:30 +01:00
Yuxuan 'fishy' Wang
39d7278ddf go: Make socketConn.Close thread-safe
Client: go

We used to rely on setting the connection inside TSocket/TSSLSocket as
nil after Close is called to mark the connection as closed, but that is
not thread safe and causing TSocket.Close/TSSLSocket.Close cannot be
called concurrently. Use an atomic int to mark closure instead.
2022-01-08 23:10:21 -08:00
Ali-Akber Saifee
9d7d627b51 Remove excess assertions
Asserting on trying to deserialize None, or an invalid serialized
buffer result in different exceptions being raised in python2/3.
2022-01-08 00:17:27 -08:00
Yuxuan 'fishy' Wang
e12fbe88e2 Use iotest.OneByteReader instead of self implemented one
Client: go

This is a trivial unit test improvement from the last commit. Of course
I only discovered the existence of testing/iotest package after I
re-invented the wheel.
2022-01-06 22:06:41 -08:00
Yuxuan 'fishy' Wang
999e6e3bce THRIFT-5490: Use pooled buffer for TFramedTransport
Client: go

Follow up on d582a8614, do the same thing on TFramedTransport.

Also update the test on the implementation of THeaderTransport to make
sure that small reads are not broken.
2022-01-05 14:21:58 -08:00
Yuxuan 'fishy' Wang
d582a86142 THRIFT-5490: Use pooled buffer for THeaderTransport
Client: go

Instead of binding 2 buffers (read/write) to each THeaderTransport, grab
one from the pool to be used for the whole read/write, and return it
back to the pool after the read/write is done. This would help reduce
the memory footprint from idle connections.
2021-12-17 10:24:19 -08:00
Ali-Akber Saifee
b724787d37 Define PY_SSIZE_T_CLEAN to use PyObject_CallFunction
When using the building functions for the fallback scenario
in readBytes, a SystemError is raised in python 3.10 (raised
as a warning till python 3.9) due to the use of "#yi" for the output
buffer argument.

Extra test cases are added to cover serialization/deserialization
both with compact & binary protocol both with and without the
c-extension
2021-12-16 13:12:44 -08:00
kpandit
c6c5a0596f THRIFT-5486 : fix issues found by spotbugs 2021-12-13 08:56:54 +01:00
Ali-Akber Saifee
b597043146 Pin clap to 2.33 as 2.34 results in build failures 2021-12-13 08:55:45 +01:00
Anshul M Gupta
98be76fc03 THRIFT-5482: Fix memory leak during SSL handshake in C++ library
Client: C++
2021-12-06 23:01:25 +01:00
Kevin Wojniak
2853af2d02 Compile TWebSocketServer with CMake only when OpenSSL is found
When compiling the C++ library and OpenSSL wasn't found, TWebSocketServer will fail as it includes OpenSSL headers.
2021-12-06 23:00:37 +01:00
Jens Geyer
4c7b9fd38a THRIFT-5479 Add net 6 support
Client: netstd
Patch: Jens Geyer
2021-12-05 13:05:58 +01:00
kpandit
4637f6d5f8 [skip ci] updated README.md to reflect final merged changes (THRIFT-5443) 2021-11-23 21:54:05 +01:00
kpandit
5a9d139be4 THRIFT-5443: add support for partial Thrift deserialization
Client: java
Patch: Bhalchandra Pandit

This closes #2439
2021-11-20 00:57:57 +01:00
Jens Geyer
2c0927826d *.local deleted 2021-11-15 19:32:18 +01:00
Jens Geyer
443a03c558 FIX: Python code style / flake8: TProcessPoolServer.py:46:14: E225 missing whitespace around operator 2021-11-15 19:31:21 +01:00
Jens Geyer
50f97135cc FIX Python code style TTransport.py:400:5: E301 expected 1 blank line, found 0 2021-11-14 12:35:52 +01:00
Jens Geyer
ea1e8ff140 THRIFT-5481 consolidate netstd server implementation details into one common model
Client: netstd
Patch: JensG
2021-11-14 12:35:30 +01:00
Jens Geyer
7156940c1d Refactoring test server/client to use async/await more consistently 2021-11-14 12:35:30 +01:00
Yiyang Zhou
da1e19b72b THRIFT-5454: add __setState__ function to TProcessPoolServer to enable correct multiprocessing behavior related to pickling
Client: Python
2021-11-14 00:54:12 +01:00
Jens Geyer
ea39a14a1f THRIFT-5480 TThreadPoolAsyncServer using TFramedTransport mistakenly drops client
Client: netstd
Patch:  Ioannis Efthymiou & Jens Geyer

This closes #2478
2021-11-14 00:20:19 +01:00
Jens Geyer
591575a8a8 THRIFT-5476 Deprecate Common Lisp support
Client: cl
Patch: Jens Geyer
2021-10-31 12:03:12 +01:00
Jens Geyer
3f1fd59925 - Fixed a few XML comments and ArgumentException arguments
- Suppressed certain unwanted CS1591 "XML comments missing" warnings
2021-10-28 23:02:12 +02:00
Jens Geyer
007b99b72a THRIFT-5408 Support for deprecated methods - follow_up fix 2021-10-27 16:43:12 +02:00
Jens Geyer
2b8be5154f ran npm audit fix to fix several reported issues 2021-10-23 13:41:38 +02:00
Kevin Wojniak
839a1daf5a THRIFT-5456 Disable SIGPIPE on TSocketServer
CLient: cpp
Patch: Kevin Wojniak

This closes #2440
2021-10-21 22:57:04 +02:00
郑桐
0f760537c3 skip map value with depth limit 2021-10-18 23:00:55 +02:00
Kevin Wojniak
6a7278b9db Fix processing typo in TSocketServer.swift 2021-10-18 22:10:16 +02:00
Brian Forbis
50dd262f28 THRIFT-5416: Allow UDP Sockets 2021-10-18 22:08:49 +02:00