* if vm state is not ACTIVE, associate floating ip to it will fail.So we should wait for state of vm is ACTIVE,then associate the assigned floating ip to it
* Pylint fix
Previous behavior if an invalid profile parameter was used:
TypeError: 'NoneType' object has no attribute '__getitem__'
New Behavior:
Error: There was a profile error: Failed to deploy VM
Also fix up some pylint complaints
My understanding is that this should always appear at 169.254.169.254.
This is specifically used with ec2 and openstack, and possible some
other cloud providers, but this format should work for the two I know
of.
Closes#37436
This commit completely breaks the salt-master on all non-Linux systems:
fb763d91e8
Why?
_hw_data(osdata) is called before `osdata` includes the key 'kernel', resulting
in a KeyError. Steps to reproduce:
(saltenv) $ salt-master -l debug
The `describe_parameters` function in the boto_rds execution module was
using inconsistent return data depending on where in the function the
return was generated. There were also inappropriate uses of `bool` that
resulted in incorrect return values.
The `parameter_present` state was also incorrectly accessing invalid
keys in the return data from `describe_parameters`. Updated to properly
use the data returned to check for existence of parameters.
The current implementation will return an invalid response if the
requested parameter group is not present. Added a check for the
parameter group not found error case and set the exists value in the
return to False.
The way that optional parameters are handled forces some of them to be
defined even when that is not necessary. Updated handling to use a
mapping of snake_case to CamelCase names and only include defined
parameters in the call to boto for the `create` and `modify` actions.
This is based on the `info_installed` function in the `zypper` module
in that it accepts an optional extra `attr` kwarg.
One extra feature it has is that it will return information on all
packages if no `names` are specified.
Signed-off-by: Sergey Kizunov <sergey.kizunov@ni.com>