Commit Graph

77322 Commits

Author SHA1 Message Date
Erik Johnson
cdbfb94cfe Handle a few edge/corner cases with non-string input to cmd.run
1. Handle non-string environment variables
2. Ensure that we pass a string to subprocess.Popen() when shell=True
3. Avoid traceback in state.single when a non-string ID dec is used

The third case above is not specific to cmd.run, it can happen with any
call to state.single in which the ID dec (i.e. the "name" argument) is
not a string. This is because state.single does not set the __sls__ key
in the chunk being called.
2017-06-12 09:50:06 -05:00
Nicole Thomas
564d5fd9d3 Merge pull request #41661 from whiteinge/rest_cherrypy-keys-headers
Add note about avoiding the `-i` flag for the /keys endpoint
2017-06-09 09:03:39 -06:00
Nicole Thomas
38424f3e3e Merge pull request #41660 from garethgreenaway/41651_fixing_aptpkg_held_unheld_with_test
Fix to modules/aptpkg.py for unheld
2017-06-09 08:53:22 -06:00
Nicole Thomas
a308b960d8 Merge pull request #41656 from rallytime/bp-41575
Back-port #41575 to 2016.11
2017-06-08 16:43:22 -06:00
Nicole Thomas
4374e6b034 Replace "tbd" with release version information 2017-06-08 15:43:33 -06:00
Seth House
a66ffc9d3e Add note about avoiding the -i flag for the /keys endpoint 2017-06-08 13:56:01 -06:00
rallytime
81413896d1 Lint: Add index numbers to format {} calls 2017-06-08 12:32:00 -06:00
Gareth J. Greenaway
30da2370a4 Fix when test=True and packages were being set to unheld. 2017-06-08 11:21:35 -07:00
Mike Place
e6d37b5f3e Merge pull request #41456 from bdrung/fix-pkgrepo.managed-changes-check
Fix pkgrepo.managed always return changes for test=true
2017-06-08 13:21:04 -05:00
Mike Place
721e5b6cb9 Merge pull request #41530 from gtmanfred/2016.11
Set default for consul_pillar to None
2017-06-08 13:13:14 -05:00
Mike Place
8926d1c731 Merge pull request #41638 from gtmanfred/cmdscript
don't overwrite args if they are passed to the script
2017-06-08 12:48:48 -05:00
Derek Schaller
384570384e only list top level npm modules during {un)install 2017-06-08 10:06:33 -06:00
Nicole Thomas
ecb09b8694 Merge pull request #41639 from dmurphy18/minion_netstat_check
Update notrim check, netstat takes minutes if large number connections
2017-06-07 17:03:23 -06:00
Nicole Thomas
2913a33b27 Merge pull request #41611 from garethgreenaway/41309_right_return_res
Additional fixes to states/saltmod.py
2017-06-07 16:58:24 -06:00
Mike Place
334a5fc2a0 Merge pull request #41637 from gtmanfred/cmd
never run bg for onlyif or unless cmd states
2017-06-07 12:37:46 -05:00
Daniel Wallace
6c7d68b97d don't overwrite args if they are passed to the script 2017-06-07 10:53:03 -06:00
David Murphy
7ab3319090 Update notrim check, netstat takes minutes if large number connections - 260K 2017-06-07 10:47:06 -06:00
Daniel Wallace
40fb6c6249 never run bg for onlyif or unless cmd states 2017-06-07 10:22:46 -06:00
Daniel Wallace
2a4633ce16 Set default for consul_pillar to None
If these do not default to None, they will default to an empty string,
which could cause the pillar tree to leak to minions it should't.

Also, allow role and environment to be pulled from pillars or minion
config by using config.get

Fixes #41478
2017-06-07 10:21:35 -06:00
Erik Johnson
34dd9ea862 Merge pull request #41255 from lordcirth/fix-sysctl-test-11
linux_syctl.default_config(): only return path, don't create it
2017-06-07 09:13:06 -05:00
Nicole Thomas
4cf577771b Merge pull request #41616 from rallytime/bp-41551
Back-port #41551 to 2016.11
2017-06-06 16:44:09 -06:00
Gareth J. Greenaway
fda41ede76 Updating result values to be None for test cases. 2017-06-06 13:01:22 -07:00
darenjacobs
53bca96328 Update __init__.py
Fix for #35481
2017-06-06 13:11:12 -06:00
Mike Place
846ca54688 Merge pull request #41552 from Enquier/neutron-floatingip-remove
Adding logic so that update_floatingip can dissassociate floatingip's
2017-06-06 13:25:55 -05:00
Mike Place
b720ecb732 Merge pull request #41569 from gtmanfred/fix_test_result_check
Check all entries in result
2017-06-06 13:18:16 -05:00
Gareth J. Greenaway
003f2d9323 Following the documentation, when passed the test=True argument the runner and wheel functions should return a result value of False. 2017-06-06 11:16:06 -07:00
Mike Place
d9546c6283 Merge pull request #41599 from garethgreenaway/41540_fixes_to_archive_module
Fixes to modules/archive.py
2017-06-06 13:02:13 -05:00
garethgreenaway
10ac80ee96 Merge pull request #41453 from peter-funktionIT/fix_win_pki_state_import_cert
Update win_pki.py
2017-06-06 10:15:54 -07:00
garethgreenaway
3335fcbc7d Merge pull request #41557 from dmurphy18/fix-proxy-service
Add symbolic link for salt-proxy service similar to other serivce files
2017-06-06 10:13:51 -07:00
Nicole Thomas
65ed230f45 Merge pull request #41597 from rallytime/bp-41533
Back-port #41533 to 2016.11
2017-06-06 09:15:09 -06:00
Gareth J. Greenaway
66a136e6d8 Fixing issues raised in #41540 when a zip file is created on a Windows system. The issue has two parts, first directories that end up in the archive end up in the results of aarchive.list twice as they show up as both files and directories because of the logic to handle the fact that Windows doesn't mark them as directories. This issue shows up when an extraction is run a second time since the module verified the file types and the subdirectory is not a file. The second issue is related to permissions, if Salt is told to extract permissions (which is the default) then the directory and files end up being unreadable since the permissions are not available. This change sets the permissions to what the default umask for the user running Salt is. 2017-06-05 20:54:05 -07:00
rallytime
535b8e8d8e Update new pyroute2 unit test to conform with 2016.11 branch standards 2017-06-05 20:55:44 -06:00
Nicole Thomas
bf8aed153d Merge pull request #41596 from rallytime/bp-41487
Back-port #41487 to 2016.11
2017-06-05 20:44:17 -06:00
Daniel Wallace
19ea5481b6 remove test that never passed 2017-06-05 17:45:23 -06:00
Peter V. Saveliev
5c86dee73c unit tests: test_pyroute2 -- add skipIf
... and comments

Bug-Url: https://github.com/saltstack/salt/pull/41533
2017-06-05 17:22:48 -06:00
Peter V. Saveliev
026b39493f unit tests: add encoding clause into test_pyroute2
Bug-Url: https://github.com/saltstack/salt/pull/41533
2017-06-05 17:22:48 -06:00
Peter V. Saveliev
9ab203d54b unit tests: fix absolute imports in test_pyroute2
Bug-Url: https://github.com/saltstack/salt/pull/41533
2017-06-05 17:22:48 -06:00
Peter V. Saveliev
1f507cfa7a unit tests: add pyroute2 interface dict test
Bug-Url: https://github.com/saltstack/salt/pull/41487
Bug-Url: https://github.com/saltstack/salt/issues/41461
2017-06-05 17:22:48 -06:00
Peter V. Saveliev
7b497d9ec6 clean up change attribute from interface dict
The attribute is hidden in IPDB from the high-level logics since
pyroute2 version 0.4.2.

Bug-Url: https://github.com/saltstack/salt/issues/41461
2017-06-05 17:21:41 -06:00
Nicole Thomas
cc6c98a8d8 Merge pull request #41509 from seanjnkns/fix-keystone-v3-endpoint_present
Add keystone V3 API support for keystone.endpoint_present|absent
2017-06-02 21:01:05 -06:00
Daniel Wallace
e2a4d5e1e2 Check all entries in result
Without this change, we ony check the first return from state tests, if
there is more than one state run, we do not check subsequent tests.
2017-06-02 17:26:07 -06:00
Mike Place
0a08649637 Merge pull request #41539 from gtmanfred/x509
allow digest to be empty in create_crl
2017-06-02 12:00:03 -05:00
Mike Place
3ae8336895 Merge pull request #41561 from terminalmage/issue41154
Redact HTTP basic authentication in archive.extracted
2017-06-02 10:33:13 -05:00
Erik Johnson
cbf8acbafc Redact HTTP basic authentication in archive.extracted 2017-06-02 01:12:08 -05:00
David Murphy
ffe492d6a9 Add symbolic link salt-proxy service similar to other service files 2017-06-01 16:05:46 -06:00
CEG
aeed51c1e3 Adding port=None default and documentation 2017-06-01 11:40:13 -06:00
CEG
fcce05e1e4 Adding logic so that update_floatingip can dissassociate floatingip's
Previously update_floatingip would cause an error if port is set to None.
2017-06-01 11:34:10 -06:00
Mike Place
39840bfe4e Merge pull request #41436 from skizunov/develop2
TCP transport: Fix occasional errors when using salt command
2017-06-01 11:37:42 -05:00
Sergey Kizunov
07d5862773 unit.transport.tcp_test: Clean up channel after use
Signed-off-by: Sergey Kizunov <sergey.kizunov@ni.com>
2017-05-31 18:30:19 -05:00
Sergey Kizunov
4b6aec7154 Preserve original IO Loop on cleanup
Signed-off-by: Sergey Kizunov <sergey.kizunov@ni.com>
2017-05-31 18:30:19 -05:00