This will show whether or not the test.ping was actually received by the
minion, and whether or not the minion attempted to send the return back
to the master.
Chocolatey added support for the --no-progress option in 0.10.4. This
option is super useful when calling chocolatey from automation tools
like Salt - as it can dramatically reduce the amount of output when
running certain commands (install, upgrade etc.). This is particularly
noticable when running commands which target a large number of packages,
for example when upgrading all the packages on a system.
Because this feature was only added in chocolatey 0.10.4 - we guard
against execution on previous versions of chocolatey using the same
pattern as the --yes flag.
Similar to the changes made for the vultr driver in PR #41600, we need
to be using the urlencode version from the six library instead of the
urllibe.urlencode function. The urlencode function was moved in PY3.
This PR removes the remaining instances of urllib.urlencode in the
salt directory.
If this is has any unicode characters in it, it won't load on systems that do
not default to a unicode locale.
find . -type f | while read line; do ret=$(file $line); if [[ $ret == *UTF-8* && $line == *.py ]]; then echo $line; fi; done
The above will list all files that have unicode characters in it and won't load
with locale set to C or POSIX
This fixes the test failures recently observed in
integration.shell.test_master.MasterTest.test_exit_status_correct_usage.
The test failures were not a regression, but rather a symptom of a
greater problem with the TestProgram class' shutdown() func. When
terminating the process using the terminate_process helper from
pytest-salt, it does not pass kill_children, which defaults to False.
This makes the helper only kill the main PID, leaving all the other PIDs
running.
This means that every time the integration suite was being run, each
time the TestProgram class was used to spawn a temporary daemon, it
would leave all the child PIDs running when the shutdown() is invoked.
By passing kill_children=True, we ensure that the child PIDs are also
killed. This should provide a significant perfomance improvement in the
test suite.
Either the get_cli_event_returns generator is not returning events, or
the events being yielded otherwise are evaluating as False. This line of
debugging code will help determine which is the case.
