Pedro Algarvio
606c6d5ffb
Add test case which tests if non proper arguments raise an exception.
2013-07-13 19:55:50 +01:00
Pedro Algarvio
9d7bb2257e
Only strip()
on strings.
2013-07-13 19:55:50 +01:00
Pedro Algarvio
5c3a406e17
Let us not use a deprecated option ourselves unless for testing the deprecation.
2013-07-13 19:55:50 +01:00
Pedro Algarvio
336135f3e8
Extra care regarding empty strings.
2013-07-13 19:55:49 +01:00
Pedro Algarvio
80f07c7922
No empty strings as defaults!
2013-07-13 19:55:49 +01:00
Pedro Algarvio
de572cb193
Fix the virtualenv
unittests which rely on it's version changing.
2013-07-13 19:55:49 +01:00
Pedro Algarvio
4b5f865404
Warn about using option not available for virtualenv
and pyvenv
respectively.
...
`False` defaults have been turned into `None` to know if the user is even passing `False` and fail.
2013-07-13 19:55:49 +01:00
Pedro Algarvio
c5917edb65
virtualenv
version checking is only done if using virtualenv
and not pyvenv
.
2013-07-13 19:55:49 +01:00
Pedro Algarvio
5aef21759e
Update doc string to make it explicit that it's salt we're mentioning.
2013-07-13 19:55:49 +01:00
Pedro Algarvio
606413c063
Show a deprecation warning if no_site_packages
is used. Fixes #6027 .
...
If both `no_site_packages` and `system_site_packages` are used, throw an error.
Added the appropriate tests.
2013-07-13 19:55:49 +01:00
Pedro Algarvio
cde1c628ac
Added a test case to check for multiple extra search dirs support. Refs #6031 .
2013-07-13 19:55:49 +01:00
Pedro Algarvio
2fd8dc299a
Add test case to check for proper handling of --never-download
. Refs #6030 .
...
Also added assertions to check for proper deprecation logging messages output.
2013-07-13 19:55:49 +01:00
Pedro Algarvio
8e8703ee80
Allow extra_search_dir
for virtualenv.create()
to be passed a list. Fixes #6031 .
2013-07-13 19:55:48 +01:00
Pedro Algarvio
6609b0414e
Set defaults to None
instead of ''
.
2013-07-13 19:55:48 +01:00
Pedro Algarvio
fd8b843de3
Warn and don't pass --never-download
to virtualenv
if it's version is >= 0.10
. Fixes #6030 .
2013-07-13 19:55:48 +01:00
Pedro Algarvio
a20dd32f61
Add missing import and instantiate a local logger instance.
2013-07-13 19:55:48 +01:00
Pedro Algarvio
7b11e3dbf3
Warn the users if they're using --distribute
without needing.
2013-07-13 19:55:48 +01:00
Pedro Algarvio
6126aa47be
Small code and print's cleanup.
2013-07-13 19:55:48 +01:00
Pedro Algarvio
8858d1183f
Add test case which tests for proper deprecated output based on virtualenv version.
2013-07-13 19:55:48 +01:00
Pedro Algarvio
9024966aa4
Don't obfuscate the original module name.
2013-07-13 19:55:47 +01:00
Pedro Algarvio
49bcbe9551
Don't overlap the virtualenv salt module with the virtualenv library.
2013-07-13 19:55:47 +01:00
Pedro Algarvio
64c9463a8b
Merge pull request #6143 from s0undt3ch/issues/6129-unexpected-__env__-keyword
...
Fix Issue #6129 unexpected `__env__` keyword
2013-07-13 11:53:19 -07:00
Pedro Algarvio
62287b8917
Merge pull request #6142 from s0undt3ch/hotfix/salt-modules-rvm-pylint
...
Update mocked rvm unit test since we now call `cmd.run_all` instead of `cmd.retcode`
2013-07-13 11:52:07 -07:00
Pedro Algarvio
96852d96ca
jinja2.ext.Extension
is apparently an old-style class.
2013-07-13 18:51:51 +01:00
Pedro Algarvio
5bee1ca7f3
Re-implement 06ac67c84a
the right way since the state __env__
was being confused by the shell environment. Fixes #6129 .
2013-07-13 18:45:30 +01:00
Pedro Algarvio
fc63bb4469
Revert "Fix pip module for python 3"
...
This reverts commit 06ac67c84a
.
2013-07-13 18:14:32 +01:00
Pedro Algarvio
269175145f
Update mocked rvm unit test since we now call cmd.run_all
instead of cmd.retcode
.
2013-07-13 17:46:46 +01:00
Thomas S Hatch
7c61db7260
Merge pull request #6141 from s0undt3ch/hotfix/pylint-salt.utils.jinja
...
Fix pylint issues regarding `salt.utils.jinja`
2013-07-13 09:28:23 -07:00
Thomas S Hatch
1a05cb7c2c
Merge pull request #6140 from s0undt3ch/hotfix/pylint-bad-first-argument
...
Hotfix pylint bad first argument
2013-07-13 09:27:29 -07:00
Thomas S Hatch
30dee739eb
Merge pull request #6139 from s0undt3ch/hotfix/pylint-unexpected-tty-argument
...
For @thatch45 to review. Remove the `tty` logic left from 0d6ff2e
.
2013-07-13 09:26:38 -07:00
Thomas S Hatch
c2f4200bb0
Merge pull request #6138 from s0undt3ch/hotfix/salt-modules-rvm-pylint
...
Fix the errors shown by pylint in the rvm module
2013-07-13 09:25:45 -07:00
Pedro Algarvio
3db3618e20
Implement SerializerExtension.parse()
to comply with pylint.
2013-07-13 17:19:37 +01:00
Pedro Algarvio
e40bb42210
Call self.environment
instead of environment
.
2013-07-13 17:19:00 +01:00
Pedro Algarvio
7d90720688
Make sure salt.utils.jinja.SerializerExtension
calls it's parent class __init__
method.
2013-07-13 17:15:25 +01:00
Pedro Algarvio
f4b015b88e
Double to single quotes and fix non python 2.6 compatible format()
call using {}
instead of {0}
.
2013-07-13 17:14:35 +01:00
Pedro Algarvio
1cfbbd3a69
Work around pylint bug of wrongly reporting too many arguments.
...
More info on http://hustoknow.blogspot.pt/2013/06/pylint.html
2013-07-13 17:05:56 +01:00
Pedro Algarvio
8512cff5a8
Fix bad first argument of SSHCopyID
.
...
* Keep a reference to the passed `opts` since they are used further down the class.
2013-07-13 16:54:32 +01:00
Pedro Algarvio
043b47f251
Remove the tty
logic left from 0d6ff2e
.
2013-07-13 16:48:35 +01:00
Joseph Hall
cba6ba0dff
Merge pull request #6137 from jpea/develop
...
OpenVZ Hardware Node process list fix
2013-07-13 08:38:25 -07:00
Pedro Algarvio
549633058b
Fix pylint errors, the _rvm()
and _do_rvm()
were being given runas
twice because of a badly constructed command
string.
2013-07-13 16:34:36 +01:00
Pedro Algarvio
95c7643849
Some formatting, logic, and speedup improvements(only create the same regexes once).
2013-07-13 16:34:36 +01:00
JP Espinosa
e208ebf994
OpenVZ Hardware Node process list fix
...
Fixed a bug with OpenVZ Hardware Node (virtual:openvzhn) using a
missing `vzps` command, not an official tool anymore
The Fix:
Obtain the processes running on hardware node as OpenVZ recommends and
format to looks like regular `ps -efH` for salt
2013-07-13 08:13:07 -05:00
Pedro Algarvio
e9b1fce088
Merge pull request #6135 from hvnsweeting/develop
...
indent code in doc
2013-07-13 05:08:30 -07:00
hvnsweeting
dc98fa6f88
indent code
2013-07-13 12:32:49 +07:00
Thomas S Hatch
bfcd814ca7
Deal with multi comp id decs wrt auto_order
2013-07-12 22:35:53 -06:00
Thomas S Hatch
79fed61dc4
Always use an ordered dict for yaml renderer
2013-07-12 22:23:37 -06:00
Thomas S Hatch
5d806a9f9e
fix bad var in state updates
2013-07-12 22:20:15 -06:00
Thomas S Hatch
c4b079e826
Add backing for running states imperitive
2013-07-12 22:08:02 -06:00
Thomas S Hatch
61a1f00882
Add docstrings to some state methods
2013-07-12 22:08:02 -06:00
Joseph Hall
5a1a283fb6
Merge pull request #6134 from terminalmage/issue5374
...
Allow alternate enc names to be used for ssh_auth states
2013-07-12 20:43:31 -07:00