* win_network.ping: add timeout and return_boolean
* win_network.ping: divide timeout by tries
Divide timeout by tries to mimic BSD behaviour. Specifying
a timeout of 10 seconds would take a Windows minion four times
longer than Linux to return when a target could not be reached.
* win_network.ping: minor doc formatting
Sometimes, when the salt-master exits, it will leave some `MWorker`
processes running. When you try to restart salt-master, you will get
errors telling you that some ports are in use (due to the leftover
`MWorker` processes) and it will fail to fully start up.
salt/utils/process.py:
- In `ProcessManager.send_signal_to_processes`, on Windows don't
send the `SIGTERM` or `SIGINT` signals to subprocesses. The reason
is explained in the inline comments.
- In `ProcessManager.send_signal_to_processes`, rename arg `signal` to
`signal_` because it collides with module `signal` and breaks when
the `in` check was added to test if the signal is `SIGTERM` or `SIGINT`.
- On Windows, when `os.kill` fails because the process no longer exists,
`OSError` is returned with errno of `EACCES`, not `ESRCH` like on other
platforms. Modified the code to account for this.
- In `ProcessManager.kill_children`, only call `taskkill` from the main
process, not any sub-processes. It has been observed that occasionally
there are zombie `taskkill` processes left over, probably due to a race
condition when both are run simultaneously from different processes.
Since the main process will kill all the other process trees,
sub-processes don't need to do anything.
Signed-off-by: Sergey Kizunov <sergey.kizunov@ni.com>
* properly set cron entries on Solarish systems
* also fix write_cron_file(_verbose_
* minor tweak to make merging into 2016.3 and develop easier
* per @damon-atkins, be more restrictive with fpopen for the user crontab
* fix another small security hole by swapping fopen to fpopen + mode. fixed previous commit by switching back to 0600
* Reset signal handling when restarting the minion.
This will avoid a hang on multiple failover masters on the 2nd restart.
This fix was hacked at +30000 feet. Kids, don't try this at home ;)
* Fix logging argument index. Switch to substitution.
* Added servicenow execution module
* Fixed up the linting
* Fix docstrings
* Setup basic unit test runner
* Setup basic loader mock and wrapper for declaring dependent packages
* Updated unit test runner and setup my first test example
* Update the servicenow module after a bad merge commit
* Code comments for the base unit test runners
* Fix linting issues
* remove empty line endings
* PSGet module for managing powershellgallery.com packages
* Linting fixes
* Converted docstrings to sphinx format
* Update LF
* Added servicenow execution module
* Fixed up the linting
* Fix docstrings
* arbitrary change to reset the build
* Setup basic unit test runner
* Setup basic loader mock and wrapper for declaring dependent packages
* Updated unit test runner and setup my first test example
* Update the servicenow module after a bad merge commit
* Code comments for the base unit test runners
* Fix linting issues
* remove empty line endings
* Added Cisco NSO Proxy for PR review
* Added RST for autodoc of new module
* Fix from comments in PR review @rallytime
* Added execution module for NSO proxy
* Revert "Merge branch 'unittest' into cisco_nso"
This reverts commit b93c0aa6913fb90d35d8cbe94533160c91dcef1a, reversing
changes made to cd50386031d61cdb630f7ef169062be8b3de6912.
* Added state for check config present
* Added autodoc for new modules
* fix lint issues
* Do a diff on the values
* Fix linting issues
* Add script to configure salt
* Add salt-config.sh to installer scripts
* Add additional information to welcome/conclusion
* Fix text in conclusion
* Make salt-config.sh executable
* Create symlink to salt-config.sh
* Create minion.d directory
* Fix changed comparison to determine restart
* Add -f option to symlink creation
* modules.virtualenv_mod: use correct pip bootstrap url
* modules.pip: raise error on mirrors arg
* states.pip: run mirrors test on < 7.0.0
* update pip integration test states to not use mirrors
* modules.pip: run mirrors tests on pip < 7.0.0
* salt.log.setup: process user args before format
Before:
[DEBUG ] too many %s
After:
[DEBUG ] too many secrets
* salt.log.setup: allow SaltLogRecord attrs on console
This change configures cherrypy to use an intermediate certificate.
I did some manual testing to make sure it works... self-signed
certs (with no intermediate configured in the master conf) still work...
and I tested with a valid GoDaddy cert and their intermediate too.
