https://github.com/saltstack/salt/pull/50417 caused a regression in
which the env name is not properly detected as `base` when
`get_checkout_target()` returns the branch name corresponding to that
repo's `base` config option. This corrects that regression.
See #51211.
2019-01-08 09:57:23,653 [salt.master :1795][ERROR ][28091] Error in function _file_list:
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/salt/master.py", line 1788, in run_func
ret = getattr(self, func)(load)
File "/usr/lib/python2.7/dist-packages/salt/utils/decorators/__init__.py", line 594, in wrapped
**salt.utils.data.decode_dict(kwargs)
File "/usr/lib/python2.7/dist-packages/salt/fileserver/__init__.py", line 752, in file_list
ret.update(self.servers[fstr](load))
File "/usr/lib/python2.7/dist-packages/salt/fileserver/roots.py", line 422, in file_list
return _file_lists(load, 'files')
File "/usr/lib/python2.7/dist-packages/salt/fileserver/roots.py", line 310, in _file_lists
__opts__, form, list_cache, w_lock
File "/usr/lib/python2.7/dist-packages/salt/fileserver/__init__.py", line 122, in check_file_list_cache
if not os.path.isfile(list_cache) and _lock_cache(w_lock):
File "/usr/lib/python2.7/dist-packages/salt/fileserver/__init__.py", line 56, in _lock_cache
os.mkdir(w_lock)
OSError: [Errno 2] No such file or directory: '/var/cache/salt/master/file_lists/roots/.foo/bar.w'
TypeError
https://docs.python.org/2/library/socket.html
RTFD "Note This method has historically accepted a pair of parameters
for AF_INET addresses instead of only a tuple. This was never
intentional and is no longer available in Python 2.0 and later.
"
This ends up in opts['master_ip'] where it can cause problems. I found
this while testng a git+pip based minion installation on Ubuntu Bionic.
I'm not sure why it doesn't affect other targeted OS versions in the
test framework. On Bionic, if 'salt' resolves to an IPv6 address,
zmq fails to connect to the master, and complains about the bracketed
address.
Error Message
object of type 'NoneType' has no len()
Stacktrace
Traceback (most recent call last):
File "/tmp/kitchen/testing/tests/unit/utils/test_network.py", line 225, in test_parse_host_port
host, port = network.parse_host_port(host_port)
File "/tmp/kitchen/testing/salt/utils/network.py", line 1957, in parse_host_port
raise _e_
TypeError: object of type 'NoneType' has no len()
