Thomas Jackson
44f1448d01
Remove "init_timeout" in RemoteFileClient.get_file
...
This timeout seems to attempt to retry in the event that the master returns nothing-- but the channel should be responsible for that.
In addition this would retry infinitely since the retry counter was re-initialized on every loop iteration. This meant you spun with an strace that looks something like:
```
read(12, "e\351\r\6y\357\331\313a0\233t\256\16qP", 16) = 16
close(12) = 0
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
write(8, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 60000) = 1 ([{fd=10, revents=POLLIN}])
poll([{fd=10, events=POLLIN}], 1, 0) = 1 ([{fd=10, revents=POLLIN}])
read(10, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
write(1, "('foo here', 'top.sls')\n", 24) = 24
select(0, NULL, NULL, NULL, {0, 20000}) = 0 (Timeout)
open("/dev/urandom", O_RDONLY) = 12
read(12, "\207L\210\340\314\203\353\207\236\231B{\304$\320\227", 16) = 16
close(12) = 0
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
write(8, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 60000) = 1 ([{fd=10, revents=POLLIN}])
poll([{fd=10, events=POLLIN}], 1, 0) = 1 ([{fd=10, revents=POLLIN}])
read(10, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
write(1, "('foo here', 'top.sls')\n", 24) = 24
select(0, NULL, NULL, NULL, {0, 20000}) = 0 (Timeout)
open("/dev/urandom", O_RDONLY) = 12
read(12, "\3\253\250\326w~\325\277\306\233'\355\300\225\202=", 16) = 16
close(12) = 0
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
write(8, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 60000) = 1 ([{fd=10, revents=POLLIN}])
poll([{fd=10, events=POLLIN}], 1, 0) = 1 ([{fd=10, revents=POLLIN}])
read(10, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
write(1, "('foo here', 'top.sls')\n", 24) = 24
select(0, NULL, NULL, NULL, {0, 20000}) = 0 (Timeout)
open("/dev/urandom", O_RDONLY) = 12
read(12, "\250\371\205\375\310\257\30\254\376\261\250o\177\357C6", 16) = 16
close(12) = 0
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
write(8, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 60000) = 1 ([{fd=10, revents=POLLIN}])
poll([{fd=10, events=POLLIN}], 1, 0) = 1 ([{fd=10, revents=POLLIN}])
read(10, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
write(1, "('foo here', 'top.sls')\n", 24) = 24
select(0, NULL, NULL, NULL, {0, 20000}) = 0 (Timeout)
open("/dev/urandom", O_RDONLY) = 12
read(12, "\322\0276\\\231\214v\5@pp\36\211\277\360\207", 16) = 16
close(12) = 0
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
write(8, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout)
poll([{fd=10, events=POLLIN}], 1, 60000) = 1 ([{fd=10, revents=POLLIN}])
poll([{fd=10, events=POLLIN}], 1, 0) = 1 ([{fd=10, revents=POLLIN}])
read(10, "\1\0\0\0\0\0\0\0", 8) = 8
poll([{fd=10, events=POLLIN}], 1, 0) = 0 (Timeout
```
Lastly, this retry attempt counter did nothing in the event of 10 failures (assuming it could get one) so it should be safe to remove it all together
Conflicts:
salt/fileclient.py
2014-12-16 07:44:09 -08:00