This is a frequent stumbling block for users unaccustomed to the older
`mod.setting` configuration syntax. Often they will interpret the list
of settings as needing to be underneat a top-level `smtp` dictionary.
This has been on my todo list for a looong time. :-P
YAML doesn't make sense here since we're just rendering a text email.
The user can still override in the smtp renderer settings if the user
has complex needs.
This pull request also adds some DRY logic to reduce code duplication,
adds an additional comment to the state return data in the event that
git.checkout was run, and fixes a minor logging inaccuracy (a
str.format() placeholder was used in a string but that string did not
call .format(), so the placeholder was being logged).
Other changes:
* If a new branch needs to be checked out, a hard reset to remote_rev was
unnecessarily being performed afterwards. This had no functional effect
since the act of checking out the new branch will place HEAD at
remote_rev, but the reset was still redundant.
* Also, when a new branch is being checked out, the tracking branch was
being unnecessarily set, since the act of checking out the branch would
setup the tracking branch if the rev being checked out is a branch.
Fixes#31229.
This fixes an exception that is thrown when using the 'when' clause in a
master scheduler. The master does not appear to create a 'pillar' entry
in self.opts
There is an issue reported #31137 where current logrotate module
create a .bak file, when using it. This will break logrotate since .bak
file will be left in /etc/logrotate.d directory.
At the same time and as a consecuence of fixing this, file.psed was
replace with file.replace since psed is deprecated since long time.
Fixes#31137.
When removing settings from dockerng.running state definition,
changes where ignored as `_compare()` was iterating only over user defined
parameters.
By looping over all available options we are now sure to not miss
removed entries.
Extend definition of expected default values:
- Some default values are predictable and hardcoded in the VALID_CREATE_OPTS dict.
- Some default needs to be read from images (`image_path`)
- Some defaults values are unpredictable (hostname, mac_address)
we are comparing desired value against value reported by the container
(`get_default_from_container`).
