Commit Graph

95901 Commits

Author SHA1 Message Date
Daniel Wozniak
094bd33279
Merge pull request #51184 from twangboy/fix_auditpol
Fix win_lgpo_auditpol salt util on Windows
2019-01-16 11:08:00 -07:00
Daniel Wozniak
ac719226c0
Merge pull request #51191 from Ch3LL/bp-50918
Backport #50918 into 2018.3
2019-01-16 11:02:18 -07:00
twangboy
7300d84d54
Skip debian tests on Windows 2019-01-16 09:31:37 -05:00
twangboy
4622433f84
Fix test_debian_ip on Windows 2019-01-16 09:31:33 -05:00
twangboy
2e68d35678
directly call cmd.run_all
Apparently, you can't always use __salt__ in a util
2019-01-15 18:09:36 -07:00
Daniel Wozniak
e7f53a3df0
Merge pull request #51144 from jgleissner/2018.3-azurearm-py3
2018.3 azurearm py3
2019-01-15 09:46:34 -07:00
Daniel Wozniak
1206f92357
Merge pull request #51171 from twangboy/fix_crypt
Add random sleep time to avoid overloading Windows
2019-01-15 09:45:32 -07:00
Daniel Wozniak
a96deed641
Merge pull request #51174 from jpsv/2018.3
Update OpsGenie to use their V2 API (2018.3)
2019-01-15 09:44:53 -07:00
Daniel Wozniak
563d4875b8
Merge pull request #51010 from amendlik/ldap-groups
Allow unauthenticated bind for listing LDAP groups
2019-01-15 09:43:41 -07:00
Daniel Wozniak
6dc375226d
Merge pull request #51112 from s0undt3ch/2018.3
[2018.3] Update to salt-bootstrap v2019.01.08
2019-01-15 09:42:08 -07:00
Daniel Wozniak
b19c990a16
Merge pull request #51097 from terminalmage/fix-keyerror-raise
Fix improper exception raises (2018.3)
2019-01-15 09:38:24 -07:00
Daniel Wozniak
8920a86f2c
Merge pull request #51169 from twangboy/fix_git_state
More descriptive error when missing GitPython or PyGit2
2019-01-15 09:37:43 -07:00
Daniel Wozniak
58eede65a7
Merge pull request #51173 from dwoz/issue51160
Avoid exceptions by passing bytes to idna
2019-01-15 09:32:30 -07:00
Jeremy McMillan
83c38c64a8 Revert "wordsmithing"
This reverts commit a07f3566516c3adb296e33fc0d3e2c9f30ac3eaf.

It wasn't necessary, and I want to trigger another round of tests on a Friday night.
2019-01-15 16:31:35 +00:00
Jeremy McMillan
a40739ce0a wordsmithing
confession: tests failed to complete on gitub notification auth failure,
so I want to trigger another test.
2019-01-15 16:31:35 +00:00
Pedro Algarvio
b348ace640 Make sure blackout tests clean up after themselves. Properly.
(cherry picked from commit 9ab0e98e2c)
2019-01-15 16:31:35 +00:00
Pedro Algarvio
68a12d50d0 These should not be considered destructive tests
(cherry picked from commit 479439ab99)
2019-01-15 16:31:35 +00:00
Jeremy McMillan
475404d14b fix docstring quote style 2019-01-15 16:31:35 +00:00
Jeremy McMillan
71c357414d Revert "backport test improvements from develop"
This reverts commit 0af7653dfa3fc9b30601dec2c8ac2ce3cba52e7f.

I guess that was way too optimistic.
2019-01-15 16:31:35 +00:00
Jeremy McMillan
e32d219599 backport test improvements from develop
Bogus random test failures
forklifted from develop at 414bfe61a4
2019-01-15 16:31:35 +00:00
Jeremy McMillan
42654d8df9 socket.connect needs a tuple
TypeError
https://docs.python.org/2/library/socket.html
RTFD "Note This method has historically accepted a pair of parameters
for AF_INET addresses instead of only a tuple. This was never
intentional and is no longer available in Python 2.0 and later.
"
2019-01-15 16:31:35 +00:00
Jeremy McMillan
27254fce37 syntax error bad parentheses 2019-01-15 16:31:35 +00:00
Jeremy McMillan
24bb94fb9e Don't ip_bracket addresses returned by check_dns.
This ends up in opts['master_ip'] where it can cause problems. I found
this while testng a git+pip based minion installation on Ubuntu Bionic.
I'm not sure why it doesn't affect other targeted OS versions in the
test framework. On Bionic, if 'salt' resolves to an IPv6 address,
zmq fails to connect to the master, and complains about the bracketed
address.
2019-01-15 16:31:35 +00:00
Jeremy McMillan
02b825ec3c expose error in tests
Error Message
object of type 'NoneType' has no len()
Stacktrace
Traceback (most recent call last):
  File "/tmp/kitchen/testing/tests/unit/utils/test_network.py", line 225, in test_parse_host_port
    host, port = network.parse_host_port(host_port)
  File "/tmp/kitchen/testing/salt/utils/network.py", line 1957, in parse_host_port
    raise _e_
TypeError: object of type 'NoneType' has no len()
2019-01-15 16:31:35 +00:00
Jeremy McMillan
0a92c4691d Need more detail on test failure 2019-01-15 16:31:35 +00:00
Jeremy McMillan
3574698a70 ip_address does not need str() and parse_host_port handles ipv6 or ipv4
note:
@isbm requested ip_address objects stay ip_address. They implement __str__
so they should work without explicit str() conversion if necessary.
2019-01-15 16:31:35 +00:00
Jeremy McMillan
7a6bc576d1 avoid TypeError by not constructing an ip_address from an ip_address 2019-01-15 16:31:35 +00:00
Jeremy McMillan
35410dde5c try to debug error in tests (revert me)
Error Message
object of type 'NoneType' has no len()
Stacktrace
Traceback (most recent call last):
  File "/tmp/kitchen/testing/tests/unit/utils/test_network.py", line 225, in test_parse_host_port
    host, port = network.parse_host_port(host_port)
  File "/tmp/kitchen/testing/salt/utils/network.py", line 1957, in parse_host_port
    raise _e_
TypeError: object of type 'NoneType' has no len()
2019-01-15 16:31:35 +00:00
Jeremy McMillan
2f8ca47549 wordsmithing 2019-01-15 16:31:35 +00:00
Jeremy McMillan
1dd1f7dd86 parsing logic error 2019-01-15 16:31:35 +00:00
Jeremy McMillan
98041c1158 minimize diff 2019-01-15 16:31:35 +00:00
Jeremy McMillan
c92a24752c don't try to handle/log test exception 2019-01-15 16:31:35 +00:00
Jeremy McMillan
eb605867c6 remove bad extra test assertion inside exception handler 2019-01-15 16:31:35 +00:00
Jeremy McMillan
e1e5d874ba checking for truthiness better than len 2019-01-15 16:31:35 +00:00
Jeremy McMillan
a984a43995 typo in ipaddress.IPv6Address() 2019-01-15 16:31:35 +00:00
Jeremy McMillan
5fc6c602c2 clear up lint, disambiguation 2019-01-15 16:31:35 +00:00
Jeremy McMillan
8c6dfea8eb lint pep8 whitespace 2019-01-15 16:31:35 +00:00
Jeremy McMillan
f9594b8a1f don't test invalid combination 2019-01-15 16:31:35 +00:00
Jeremy McMillan
de823fd3ae fix good_host_ports iteration 2019-01-15 16:31:35 +00:00
Jeremy McMillan
c5a5b34fc4 test assertion correction 2019-01-15 16:31:35 +00:00
Jeremy McMillan
e169e0df54 fixup rebase merge goof 2019-01-15 16:31:35 +00:00
Jeremy McMillan
d28bab6fd0 fix test setup 2019-01-15 16:31:35 +00:00
Jeremy McMillan
42c710e4d1 lint pep8 2019-01-15 16:31:35 +00:00
Jeremy McMillan
15c6deba62 fix horrible mistakes 2019-01-15 16:31:35 +00:00
Jeremy McMillan
c092baf9da fix indentation doh 2019-01-15 16:31:35 +00:00
Jeremy McMillan
9080745e3a debug ipaddress.ip_address TypeError 2019-01-15 16:31:35 +00:00
Jeremy McMillan
8bd82f44e4 debug ipaddress.ip_address TypeError 2019-01-15 16:31:35 +00:00
Jeremy McMillan
080ab702c1 fix parse_host_port() parse error on hostname only arg 2019-01-15 16:31:35 +00:00
Jeremy McMillan
571603c4ce coverage for master host:port ipv4 and ipv6 config value support
fix test_parse_host_port bad values
lint
2019-01-15 16:31:35 +00:00
Jeremy McMillan
f14ff16626 fix minion zmq connecting to master configured as IPv6 address 2019-01-15 16:31:35 +00:00