* Migrate Funnel visualization to React: Editor
* Migrate Funnel visualization to React: Renderer
* Replace Auto sort options with Sort Column + Reverse Order
* Add option for items limit (instead of hard-coded value)
* Add number formatting options
* Replace d3.max with lodash.maxBy; fix bug in prepareData
* Add options for min/max percent values
* Debounce inputs
* Tests
* Refine Renderer: split components, use Ant Table for rendering, fix data handling
* Extract utility function to own file
* Fix tests
* Fix: sometimes after updating options, funnel shows "ghost" rows from previous dataset
* Sort by value column by default
* Migrate Cohort to React: Editor
* Extract prepareData and getOptions to own files
* Refine CohortRenderer Angular component (js, less, prepareData) for easier migration
* Migrate Cohort to React: Renderer
* Migrate Cornelius to React: styles
* Migrate Cohort to React: Cornelius library
* Cornelius: add licence info; remove unused style
* Cornelius: use numeral to format numbers; revisit styles
* Cornelius: use moment to format date labels
* Cornelius: use chroma for cell backgrounds; update options; update proptypes; minor fixes
* Tidy up
* Tests
* add some logging to scheduler
* schedule jobs only if they are not already scheduled
* jobs scheduled with an interval over 24 hours were not repeated
* schedule version_check using standard scheduling
* clean up old jobs that are not part of the definition anymore
* add some tests
* add one more test to verify that reschedules are not done when not neccesary
* no need to check for func existence - all jobs have a func to run
* Migrate settings-screen to React
* Use black instead of blue color for active item
* Revert "Use black instead of blue color for active item"
This reverts commit 0e4ececa6aba68f6484fefaae8ab85153d177bf8.
* Add selectable=false to the Menu
* add some logging to scheduler
* clean failed RQ job data from Redis
* move stale job purging to tasks/general.py
* provide better documentation on why we don't reject keys in FailedJobRegistry at the moment
* pleasing the CodeClimate overlords
* simplified clenaup by deleting both job data and registry entry
* use FailedJobRegistry as source of truth for purging
* remove redundant key deletion
* Update redash/settings/__init__.py
Co-Authored-By: Arik Fraimovich <arik@arikfr.com>
* CircleCI workflow improvements
- Don't automatically build the Docker image.
- Make the Python lint step requirement for the follow up steps. When it fails it usually means there is a code error which will prevent the next steps anyway.
* Fix YAML syntax error.
* Add separate build Docker image step for master branch
* Start draft for new Parameter structure
* Add the rest of the methods
* EnumParameter
* QueryBasedDropdownParameter
* DateParameter
* DateRangeParameter
* Update Parameter usage on code
* Merge dynamicValue into normalizedValue
* Add updateLocals and omit unwanted props
* Allow null NumberParameter and omit parentQueryId
* Rename parameter getValue to getExecutionValue
* Update $$value to normalizedValue + omit on save
* Add a few comments
* Remove ngModel property from Parameter
* Use value directly in DateRangeParameter
* Use simpler separator for DateRange url param
* Add backward compatibility
* Use normalizeValue null value for isEmpty
* Start creating jest tests
* Add more tests
* Normalize null value for multi mode in Enum
* Use saved value for param isEmpty
* Make core app compatible with Python 3
No backward compatibility with Python 2.7 is kept.
This commit mostly contains changes made with 2to3 and manual
tweaking when necessary.
* Use Python 3.7 as base docker image
Since it is not possible to change redash/base:debian to Python 3
without breaking future relases, its Dockerfile is temporarly
copied here.
* Upgrade some requirements to newest versions
Some of the older versions were not compatible with Python 3.
* Migrate tests to Python 3
* Build frontend on Python 3
* Make the HMAC sign function compatible with Python 3
In Python 3, HMAC only works with bytes so the strings and the
float used in the sign function need to be encoded.
Hopefully this is still backward compatible with already generated
signatures.
* Use assertCountEqual instead of assertItemsEqual
The latter is not available in Python 3.
See https://bugs.python.org/issue17866
* Remove redundant encoding header for Python 3 modules
* Remove redundant string encoding in CLI
* Rename list() functions in CLI
These functions shadow the builtin list function which is
problematic since 2to3 adds a fair amount of calls to the builtin
list when it finds dict.keys() and dict.values().
Only the Python function is renamed, from the perspective of the
CLI nothing changes.
* Replace usage of Exception.message in CLI
`message` is not available anymore, instead use the string
representation of the exception.
* Adapt test handlers to Python 3
* Fix test that relied on dict ordering
* Make sure test results are always uploaded (#4215)
* Support encoding memoryview to JSON
psycopg2 returns `buffer` objects in Python 2.7 and `memoryview`
in Python 3. See #3156
* Fix test relying on object address ordering
* Decode bytes returned from Redis
* Stop using e.message for most exceptions
Exception.message is not available in Python 3 anymore, except
for some exceptions defined by third-party libraries.
* Fix writing XLSX files in Python 3
The buffer for the file should be made of bytes and the actual
content written to it strings.
Note: I do not know why the diff is so large as it's only a two
lines change. Probably a white space or file encoding issue.
* Fix test by comparing strings to strings
* Fix another exception message unavailable in Python 3
* Fix export to CSV in Python 3
The UnicodeWriter is not used anymore. In Python 3, the interface
provided by the CSV module only deals with strings, in and out.
The encoding of the output is left to the user, in our case
it is given to Flask via `make_response`.
* (Python 3) Use Redis' decode_responses=True option (#4232)
* Fix test_outdated_queries_works_scheduled_queries_tracker (use utcnow)
* Make sure Redis connection uses decoded_responses option
* Remove unused imports.
* Use Redis' decode_responses option
* Remove cases of explicit Redis decoding
* Rename helper function and make sure it doesn't apply twice.
* Don't add decode_responses to Celery Redis connection URL
* Fix displaying error while connecting to SQLite
The exception message is always a string in Python 3, so no
need to try to decode things.
* Fix another missing exception message
* Handle JSON encoding for datasources returning bytes
SimpleJSON assumes the bytes it receives contain text data, so it
tries to UTF-8 encode them. It is sometimes not true, for instance
the SQLite datasource returns bytes for BLOB types, which typically
do not contain text but truly binary data.
This commit disables SimpleJSON auto encoding of bytes to str and
instead uses the same method as for memoryviews: generating a
hex representation of the data.
* Fix Python 3 compatibility with RQ
* Revert some changes 2to3 tends to do (#4261)
- Revert some changes 2to3 tends to do when it errs on the side of caution regarding dict view objects.
- Also fixed some naming issues with one character variables in list comprehensions.
- Fix Flask warning.
* Upgrade dependencies
* Remove useless `iter` added by 2to3
* Fix get_next_path tests (#4280)
* Removed setting SERVER_NAME in tests setup to avoid a warning.
* Change get_next_path to not return empty string in case of a domain only value.
* Fix redirect tests:
Since version 0.15 of Werkzeug it uses full path for fixing the location header instead of the root path.
* Remove explicit dependency for Werkzeug
* Switched pytz and certifi to unbinded versions.
* Switch to new library for getting country from IP
`python-geoip-geolite2` is not compatible with Python 3, instead
use `maxminddb-geolite2` which is very similar as it includes
the geolite2 database in the package .
* Python 3 RQ modifications (#4281)
* show current worker job (alongside with minor cosmetic column tweaks)
* avoid loading entire job data for queued jobs
* track general RQ queues (default, periodic and schemas)
* get all active RQ queues
* call get_celery_queues in another place
* merge dicts the Python 3 way
* extend the result_ttl of refresh_queries to 600 seconds to allow it to continue running periodically even after longer executions
* Remove legacy Python flake8 tests
