Commit Graph

311 Commits

Author SHA1 Message Date
Boris
01c5dd2f37
HG-543: check risk score for predefined route (#462) 2020-07-28 10:30:30 +03:00
Boris
bda786fad9
HG-536: fix pouting reject context (#463) 2020-07-27 09:40:07 +03:00
Roman Pushkov
e2240008a0
HG-541: invoice adjustments (#458)
* some initial changes

* update hg_client

* change adjustment to payment adjustment in tests

* update damsel

* types in client

* Revert "change adjustment to payment adjustment in tests"

This reverts commit ff1633c41660b6f144f75ae067ea63eb33906981.

* rename payment adjustment functions

* fix hg_client adjustment calls

* update invoice events header

* add invoice adjustment tests

* working invoice adjustments

* uncomment other invoice tests

* minor cleanup

* fix some types

* fix more types

* temporarily comment out non-operational tests

* fix actions

* add more tests

* add exceptions

* run ci with disabled invoice adjustment tests

* Switch ti sequential

* uncomment tests

* minor cleanup

* uncomment pm tests

* add extra asserts

* add logging

* remove tests from invoice suite

* add invoice adjustment test suite

* minor cleanup

* fix test crashes

* minor cleanup

* more cleaning

* update invalid status exception handling

* increase party client timeout

* increase get timeout

* add pending payment test

* add pending adjustment test

* update tests

* update damsel

* update handling

* add expiration tests

* refactor tests

* update expiration handling

* tests cleanup

* do not expire while pending

* update timeouts

Co-authored-by: Sergey Yelin <elinsn@gmail.com>
2020-07-21 17:43:14 +03:00
Boris
9562cff4c2
fix wrong route format (#461) 2020-07-14 18:35:50 +03:00
Toporkov Igor
7bf0359c39
DC-122: Remove risk_coverage from Terminal (#459)
* Hard remove all risk_coverage-related code

* Upgrade dominant

* Remove risk_coverage from test terminals, rework routing tests so they pass

* Fix merge artifact

* Kek

* Remove outdated comment

* Improve test readability

* Delete trailing whitespaces
2020-07-14 16:40:04 +03:00
ndiezel0
101a6c72b0
HG-452: Update party_managements methods and tests (#460) 2020-07-10 16:54:31 +03:00
Andrey Fadeev
5bbac2a626
MSPF-561 Add new provider terms usage (#454) 2020-07-06 10:58:37 +03:00
Roman Pushkov
d75c012b4a
HG-542: chargebacks move_to_stage option (#456)
* add move_to_stage option handling

* add test placeholder

* finalise test

* uncomment move_to_stage option handling

* only allow skipping forward

* update damsel

* fix test

* update handling

* rework stage selection semantics

* fix stage handling

* fix dialyzer
2020-07-03 17:23:24 +03:00
Andrey Fadeev
3f3c8e18cd
MSPF-561 Update damsel (#455)
* Update damsel
* Reduce tests flapping
* Make eventsink test suite a bit more stable
2020-06-30 17:51:13 +03:00
Boris
8f8f7ad348
HG-536: impl rules for compute routes, filter deny routes (#446) 2020-06-30 11:05:09 +03:00
Andrew Mayorov
710f8ebe73
DC-120: Implement criteria in predicates (#453)
See rbkmoney/damsel#582
2020-06-23 17:00:46 +03:00
Sergey Yelin
59ec584071
P2C-8: Add attempt_limit (#452)
* P2C-8: Add attempt_limit

* Add missing merge

* Fix order
2020-06-22 18:21:22 +03:00
Andrew Mayorov
c2aed8c2d3
Refrain from synthesizing events on adjustment capture (#450) 2020-06-18 23:39:49 +03:00
Toporkov Igor
e558d123ed
DC-126: Add tokenization_method field (#449)
* Support tokenization_method field and condition

* Split very long line

* Threat none same as undefined when comparing tokenization methods

* Allow whatever payment method if condition is undefined

* Handle undefined tokenization method with defined tokenization method condition
2020-06-17 09:59:23 +03:00
Boris
03302b8788
MSPF-562: Add bank card category, condition category_is (#448) 2020-06-11 17:17:05 +03:00
Roman Pushkov
c42601e2c0
HG-529: add disable failover routing option (#447)
* Temporarily revert second part of HG-538

This reverts commit 7f23d74bf7.

* add enabled option to fd

* disable fd in tests by default

* update fd gathering test

* add enabled status handling to fd

* cleanup

* cleanup ct print

* update tests

* cleanup

* update existing fd config in tests

* update hg test config for fd
2020-06-09 14:03:10 +03:00
Andrey Fadeev
c2a1d07c31
Fix invoice expiration timeout set on finalized invoices (#442) 2020-06-03 20:23:29 +03:00
Roman Pushkov
7eea076a4d
Temporarily revert second part of HG-538 (#444)
This reverts commit 7f23d74bf7.
2020-06-03 20:23:10 +03:00
Roman Pushkov
7f23d74bf7
HG-538: fix possible hg and shumway disparities (#434)
* add failure activity

* add refund failure test

* add payment error handling placeholder

* minor cleanup

* add refund handling placeholders

* add events

* update event handling

* remove failure from state on status change

* update actions

* uncomment new changes

* update tests

* cleanup

* Update rebar.lock

* remove redundant clauses and activities

* Update apps/hellgate/src/hg_invoice_payment.erl

Co-authored-by: Andrey Fadeev <me@ciiol.net>

Co-authored-by: Andrey Fadeev <me@ciiol.net>
2020-06-03 13:08:23 +03:00
Roman Pushkov
37b8b08f01
HG-538: fix possible hg and shumway disparities, backwards compatibility (#438)
* add failure activity

* add refund failure test

* add payment error handling placeholder

* minor cleanup

* add refund handling placeholders

* add events

* update event handling

* remove failure from state on status change

* update actions

* Update rebar.lock

* revert action changes

* cleanup
2020-05-26 23:15:18 +03:00
ndiezel0
05e6c7ad91
HG-452: Further remove party management from hellgate (#433)
* HG-452: Further remove party management from hellgate

* HG-452: Add ComputeP2PProvider, ComputeWithdrawalProvider, ComputePaymentProvider implementation

* HG-452: Add ComputePaymentProviderTerminalTerms implementation

* HG-452: Add ComputeP2PProvider test

* HG-452: Fix test

* HG-452: Fix p2p provider test

* HG-452: Add the rest of the tests

* HG-452: Fix lint

* HG-452: Debug tests

* HG-452: Remove debug

* HG-452: Review fix
2020-05-25 13:50:45 +03:00
Roman Pushkov
c70299de31
HG-540: cash flow data in chargebacks (#440)
* update damsel

* add get_cash_flow to chargebacks

* update get_chargebacks/1

* okay, that looks weird

* typo fix

* oh come on

* typo fix

* update damsel

* handle get_chargebacks
2020-05-25 11:32:21 +03:00
Артем
ff2426f008
DC-123: P2P templates (#435)
* updated damsel

* added support for template terms

* added test for p2p template terms

* fixed merge

* minor
2020-05-08 13:29:43 +03:00
Andrey Fadeev
d14323d6f0
Use explicit timestamp to compute merchant terms (#436)
Also remove invoice timestamp usage in refund and payment terms computation
2020-05-07 15:59:21 +03:00
Boris
46398c3529
HG-539: change count refund amount without cash (#432) 2020-04-22 16:33:39 +03:00
Andrey Fadeev
6a6f193b72
Interpret undefined selector as a reason for route rejecting (#429)
... instead of failing with fucntion clause
2020-04-14 20:30:39 +03:00
Andrey Fadeev
3bfae85f23
Fix cash_flow in payment state asfter partial capture (#431) 2020-04-14 19:05:24 +03:00
Alexey
f5a7fc18a2
HG-535: Assert invoice payable (#428) 2020-04-06 12:28:00 +03:00
Roman Pushkov
6d4caf7548
HG-495: chargebacks (#346)
* wip chargeback handler

* add chargeback test draft

* update deps

* update deps

* create chargeback draft

* add create chargeback to client

* create chargeback test draft

* update dmsl

* update test

* cashflow wip

* update payment events

* update deps

* attempt fix deps

* update dmsl

* update test

* add get payment chargeback to client

* add get payment chargeback handler

* cashflow wip

* fix linter errors

* wip create chargeback

* damsel update

* fix dmsl

* update dominant

* merge cb terms

* update id generation

* add test placeheolders

* update hg client

* add update chargeback

* update client

* update tests

* update events

* add implementation wip

* update cancel

* update tests

* update damsel

* add more chargeback tests

* update implementation

* update dominant

* update damsel

* some fixes

* add reopen tests with hold funds

* update reopen logic

* udpate damsel

* add cancel after reopen test

* add cancel after reopen implementation

* add more tests

* add balance checks to tests

* cashflow fix

* add more balance checks in tests

* fix cashflow bug

* add tests for reopening chargebacks after failures

* add reopen after failures handling

* finalise test to be sure

* fix test

* do not change payment status on accept with partial cash

* remove failures from tests

* update damsel

* test updates and fixes

* update implementation

* update damsel

* type cleanup, some refactoring

* cleanup, remove ct:print, refactor

* minor cleanup

* update tests

* add inconsistent currency check

* udpate damsel

* update tests

* udpate damsel

* move chargebacks to separate module

* move chargebacks to a separate module

* fix types

* some refactoring

* types, some refactoring

* update damsel

* update dominant + minor

* update tests

* update implementation

* update damsel

* fix merge

* fix lost types

* add cash to pending, remove from cb changed

* update damsel

* update damsel

* update dominant

* minor

* update events

* add params to reject

* update damsel

* update tests WIP

* update invoice payment

* update chargebacks WIP

* update tests

* update damsel

* update events

* update invoice payment

* update chargeback implementation

* minor cleanup

* increase god module cap a bit

* cleanup

* update events

* update damsel

* update tests wip

* update implementation wip

* update events in tests

* update damsel

* update chargeback events

* clean prints, restore cash flow handling on first reopen, reset target status

* fix dialyzer

* update tests

* update cash flow handling and reject logic

* fix indentation

* refactoring, moved activities to chargebacks module

* move process result to chargeback

* fix config formatting

* move no pending chargebacks check to invoice

* move getters to chargebacks module

* idempotent creation

* merge party cb terms

* syntax fixes

* fail routing with no chargeback terms

* move choose_provider_account to payment institution

* fix export

* remove unnecessary validations

* revert accessibility validation

* fix deletion

* minor refactoring

* remove pending chargebacks check from invoice

* Fix postgresql link (#421)

* refactor chargeback activity, fix idempotency

* update tests

* update dmsl

* add cb to varset

* fix

* removed get_opts, set_opts

* clean up chargebacks

* update deps

* move choose_external_account

* fix types

* add todo for cash flow rework

* remove redundant aliases

* unified define_params_cash function

* remove contract validation

* remove contract validation

* cash flow handling rework, docs update

* remove redundant validation

* fix merge

* add partial capture chargeback test

* add separate plans for stages

* wrap events externally

* add partial payment chargeback test with exceeding body

* fix type errors

* rework event handling

* elvis update

* cleanup

* move pending chargebacks check

* move validations

* move more validations

* separate body and levy in cash flow

* minor

* update cb options

* minor rename

* disable cancel during initialisation

* update activity naming

* set operation_amount to 0 on reject

* update merge_change validations

* update test chargeback test fixture

* use remaining amount if body is undefined

* add double chargeback test

* fix wrong types

* move some validations

* move create validations, update opts

* longer hold period for capture

* update damsel

* add chargeback service terms validation

* add chargeback not allowed test

* minor cleanup

* tests cleanup, add chargeback fees placeholder

* add test placeholders for provider levy

* split service and provision cf contexts

* fix typo

* update dominant

* export hg_cashflow:compute_volume/2

* update test fixture

* implement provider levy

* formatting

* update tests

* fix types

* fix types

* prolong test timeout

* merge update

* reduce allow predicate

* cb provider levy cash flow update

* cleanup

* add chargebacks to reduce

* add eligibility validation

* fix chargeback terms reduction

* throw misconfiguration if allow can not be reduced

* use add_previous_stage function

* fix type errors

* update cancel handling, store last cash flow, use cb creation timestamp, cleanup

* update hg client

* update damsel

* update tests

* add occurred_at to invoice event

* update params macros

* implement occurred_at

* export cancel params

* disable flappy tests

* fix typo

* simplify occurred_at extraction

* restore explicit clause matching in finalise

* clean ct:prints

* fix whitespace

* attempt at unflapping tests

Co-authored-by: Sergey Yelin <elinsn@gmail.com>
2020-03-27 12:58:41 +03:00
Артем
49335d6697
FF-163: Fix - P2P tool condition test (#427) 2020-03-13 12:55:24 +03:00
Sergei Shuvatov
cf65a27efd
HG-525: add payment status adjustment (#414) 2020-03-12 13:17:13 +03:00
ndiezel0
4657aeb0e9
HG-452: Move party and claim management to its own app (#407)
* HG-452: Move party and claim management to it's own app

* HG-452: Remove unused exports

* HG-452: Fix tests, remove old eventsink on party

* HG-452: Revert pm_event_provider

* HG-452: Remove `hg_contract`

* HG-452: Add pm_client and pm_proto

* HG-452: Fix lint

* HG-452: Move party and claim management tests to `party_management`

* HG-452: Fix dialyzer

* HG-452: Fix tests

* HG-452: Fix tests

* HG-452: Remove some includes in hg, bring back `hg_party`

* HG-452: Remove party client from party management

* HG-452: Remove `hg_payout_tool` and rename `pm_invoice_utils` => `pm_currency`

* HG-452: Add party_management config

* HG-452: Remove unused function from common test helpers

* HG-452: Remove unused function from pm_ct_helper

* HG-452: hg_selector => pm_selector

* HG-452: Fix lint

* HG-452: Strip down party_management config and bring back party_events.hrl to hellgate

* HG-452: Fix order of app loads in tests

* HG-452: Bring back `hg_client_party`

* HG-452: Fix tests

* HG-452: Use pm_party in hg, where it is appropriate

* HG-452: Remove unused `hg_client_party` code

* HG-452: Remove unused macros in `hellgate/include/party_events.hrl`

* HG-452: Remove party_management from list of services in config

* HG-452: Remove hg_client and pm_client need to get service_spec

* HG-452: Clean up `party_management/include/domain.hrl` from unused macros

* HG-452: Format `xref_checks` like `erl_opts`

* HG-452: Bring back old event_sink for party events

* HG-452: Simplify include in test

* Merge branch 'master' into HG-452/ft/party_management_new

# Conflicts:
#	apps/hellgate/src/hg_party.erl

* HG-452: Review fix
2020-02-28 15:02:25 +03:00
Sergei Shuvatov
38f908b2c0
MSPF-532: get rid of rfc3339 library (#424) 2020-02-26 20:53:09 +03:00
Артем
80e7ab2f35
FF-160: Add w2w transfer (#425)
* added w2w transfer

* updated dominant

* fixed
2020-02-18 14:05:00 +03:00
Andrey Fadeev
da908c684e
PROX-386 Add shop to RecurrentTokenInfo in ProviderProxy.GenerateToken (#417) 2020-01-30 08:37:12 +03:00
Sergei Shuvatov
6cc97552b9
HG-533: actualize claim management protocol (#415) 2020-01-28 20:37:36 +03:00
Артем
c299b9ffd6
Revert "HG-469: Validate recurrent route (#410)" (#416)
This reverts commit 3460f019f0.
2020-01-28 18:54:02 +03:00
Roman Pushkov
42e9ffa76f
HG-532: add qps, zotapay (#413)
* add zotapay to payment tool

* add qps to payment tool
2020-01-24 14:17:38 +03:00
Артем
3460f019f0
HG-469: Validate recurrent route (#410)
* validate recurrent route

* added fixes and test

* added requested changes

* fixed test

* added requested changes

* Update apps/hellgate/src/hg_invoice_payment.erl

Co-Authored-By: Andrew Mayorov <a.mayorov@rbkmoney.com>

* added requested changes

Co-authored-by: Andrew Mayorov <encube.ul@gmail.com>
2020-01-22 14:45:32 +03:00
Andrew Mayorov
4aa61fdecc
Properly accrue waiting timing on capture start (#412) 2020-01-19 18:48:55 +03:00
Roman Pushkov
7f2f71cf1e
HG-530: handle certain errors as fd finishes (#406)
* add handling

* cleanup

* fix

* dialyzer fix

* fix typo

* improve naming

* add safe failures to config

* fix naming

* rename safe to benign

* make fd operations time-independent

* fix compilation errors
2020-01-09 12:26:17 +02:00
Roman Pushkov
a71b36b6ac
HG-526: handle cancel, capture business error (#405)
* add test

* fix failure

* update test

* add capture test

* add capture handling

* Revert "add capture handling"

This reverts commit 1a86a86b9c9552d0785bd2e9954f04f60a758eca.

* update tests

* fail on unsuccessful cancel

* revert activity changes
2019-12-26 17:19:29 +03:00
Andrew Mayorov
fe9186a6c2
Measure and log some timings over business events (#400) 2019-12-17 13:27:01 +03:00
Sergei Shuvatov
a930b2ce44
Update machinegun (#402) 2019-12-16 19:57:26 +03:00
Andrey Fadeev
eee8bf3d78 Add invoice id to conversion operation id in fault-detector call (#397) 2019-12-16 13:58:57 +03:00
Sergey Yelin
7f5fb02eac
Aaa 54 remove spaces (#401)
* AAA-54: Remove spaces in messages

* Update dmt_client and config
2019-12-13 18:36:31 +03:00
Sergey Yelin
d241bf0797
BJ-703: Add wechat and alipay to payment tool (#396)
* BJ-703: Add wechat and alipay to payment tool

* Fix tests
2019-12-12 07:15:17 +03:00
Sergey Yelin
3a83357b19
Switch to new woody with log formatter (#394)
* Switch to new woody with log formatter

* event_handler_opts -> scoper_event_handler_opts

* Fix lint

* Add limit to tests

* Fix formater option passing

* Fix woody params passing

* Update woody
2019-12-09 18:03:05 +03:00
Roman Pushkov
629f4b44a0
HG-527: recurrent paytool eventsink sequence (#391)
* update damsel

* update recurrent paytool client

* update eventsink client

* update event provider

* update recurrent paytool

* more recurrent paytool client updates

* revert event sink client changes

* finalise event sink test

* dialyzer fix

* review fixes

* review updates

* improve recurrent paytool eventsink test

* fix linter error
2019-12-05 14:18:38 +03:00
Alexey
e3ed327105
Switch to thrift binary serialization (#392) 2019-12-04 13:30:17 +03:00