fix wrong route format (#461)

apps/hellgate/src/hg_routing_rule.erl

@@ -92,7 +92,7 @@ collect_routes(Predestination, Candidates, VS, Revision) ->
             } = Candidate,
             {#domain_Terminal{provider_ref = ProviderRef}, Provider} = get_route(TerminalRef, Revision),
             try
-                Terminal = hg_routing:acceptable_terminal(Predestination, TerminalRef, Provider, VS, Revision),
+                {_, Terminal} = hg_routing:acceptable_terminal(Predestination, TerminalRef, Provider, VS, Revision),
                 {[{{ProviderRef, Provider}, {TerminalRef, Terminal, {Priority, Weight}}} | Accepted], Rejected}
             catch
                 {rejected, Reason} ->

apps/hellgate/test/hg_route_rules_tests_SUITE.erl

@@ -20,6 +20,7 @@
 -export([rejected_by_table_prohibitions/1]).
 -export([empty_candidate_ok/1]).
 -export([ruleset_misconfig/1]).
+-export([prefer_better_risk_score/1]).
 
 -behaviour(supervisor).
 -export([init/1]).
@@ -45,7 +46,8 @@ all() -> [
     gather_route_success,
     rejected_by_table_prohibitions,
     empty_candidate_ok,
-    ruleset_misconfig
+    ruleset_misconfig,
+    prefer_better_risk_score
 ].
 
 -spec groups() -> [{group_name(), list(), [test_case_name()]}].
@@ -201,6 +203,36 @@ ruleset_misconfig(_C) ->
 
     {[], []} = hg_routing_rule:gather_routes(payment, PaymentInstitution, VS, Revision).
 
+-spec prefer_better_risk_score(config()) -> test_return().
+prefer_better_risk_score(_C) ->
+    VS = #{
+        category        => ?cat(1),
+        currency        => ?cur(<<"RUB">>),
+        cost            => ?cash(1000, <<"RUB">>),
+        payment_tool    => {payment_terminal, #domain_PaymentTerminal{terminal_type = euroset}},
+        party_id        => <<"12345">>,
+        risk_score      => low,
+        flow            => instant
+    },
+
+    Revision = hg_domain:head(),
+    PaymentInstitution = hg_domain:get(Revision, {payment_institution, ?pinst(1)}),
+
+    {Routes, RC} = hg_routing_rule:gather_routes(payment, PaymentInstitution, VS, Revision),
+
+    {ProviderRefs, TerminalData} = lists:unzip(Routes),
+
+    ProviderStatuses = [{{dead, 1.0}, {normal, 0.0}}],
+    FailRatedRoutes  = lists:zip3(ProviderRefs, TerminalData, ProviderStatuses),
+
+    Result = hg_routing:choose_route(FailRatedRoutes, RC, VS),
+
+    {ok, #domain_PaymentRoute{provider = ?prv(3)}, Meta} = Result,
+    false = maps:is_key(reject_reason, Meta),
+
+    ok.
+
+
 %%% Domain config fixtures
 
 construct_domain_fixture() ->