valitydev/elixir-thrift
14
0
Fork 0
mirror of https://github.com/valitydev/elixir-thrift.git synced 2024-11-07 02:35:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Booleans can have integer default values (#143)

Browse Source 
Booleans can have 1 and 0 as default values. This converts them into
true and false, so we can deal with them properly.

Fixes #142
This commit is contained in:
Steve Cohen 2017-01-03 14:18:47 -08:00 committed by GitHub
parent 9cd1d502a1
commit fd8600815d
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/thrift/parser/conversions.ex
View File

@ -19,6 +19,9 @@ defmodule Thrift.Parser.Conversions do
val
end
def cast(:bool, 0), do: false
def cast(:bool, 1), do: true
def cast(:string, val) do
List.to_string(val)
end

6
test/parser_test.exs
View File

@ -380,6 +380,8 @@ defmodule ParserTest do
struct MyStruct {
1: optional bool negative;
2: optional bool positive = true;
3: optional bool c_positive = 1;
4: optional bool c_negative = 0;
}
"""
|> parse([:structs, :MyStruct])
@ -388,7 +390,9 @@ defmodule ParserTest do
name: :MyStruct,
fields: [
%Field{id: 1, name: :negative, type: :bool, required: false, default: nil},
%Field{id: 2, name: :positive, type: :bool, required: false, default: true}
%Field{id: 2, name: :positive, type: :bool, required: false, default: true},
%Field{id: 3, name: :c_positive, type: :bool, required: false, default: true},
%Field{id: 4, name: :c_negative, type: :bool, required: false, default: false},
]}
end