mirror of
https://github.com/valitydev/atomic-threat-coverage.git
synced 2024-11-06 09:35:21 +00:00
2.5 KiB
2.5 KiB
How to submit an issue?
First, please refer to contribution-guide.org for the steps we expect from contributors before submitting an issue or bug report. Be as concrete as possible, include relevant logs, package versions etc.
Also, please check our FAQ.
The proper place for open-ended questions is Slack or Telegram.
How to add a new feature or create a pull request?
- Fork the ATC repository
- Clone your fork:
git clone git clone https://gitlab.com/<YOUR GITLAB USERNAME>/atomic-threat-coverage.git
- Create a new branch based on
develop
:git checkout -b my-feature develop
- Setup your Python enviroment
- Create a new virtual environment:
pip install virtualenv; virtualenv atc_env
and activate it:- For linux:
source atc_env/bin/activate
- For windows:
atc_env\Scripts\activate
- For linux:
- Install ATC and its test dependencies in editable mode:
- For linux:
pip install -r requirements.txt
- For windows:
pip install -r requirements.txt
- For linux:
- Create a new virtual environment:
- Implement your changes
- Check your code for PEP8 requirements
- Add files, commit and push:
git add ... ; git commit -m "my commit message"; git push origin my-feature
- Create a PR on Github. Write a clear description for your PR, including all the context and relevant information, such as:
- The issue that you fixed, e.g.
Fixes #123
- Motivation: why did you create this PR? What functionality did you set out to improve? What was the problem + an overview of how you fixed it? Whom does it affect and how should people use it?
- Any other useful information: links to other related Github or mailing list issues and discussions, benchmark graphs, academic papers…
- Note that your Pull Request should be into develop branch, not master
- The issue that you fixed, e.g.
P.S. for developers: see our Developer Page for details on the code style, CI, testing and similar.
Thanks and let's improve the open source world together!