Commit Graph

7225 Commits

Author SHA1 Message Date
Jacob Shandling
bbc16ef180
UI: Make label same size as button to widen click functionality; handle missed edge case (#10581) 2023-03-20 10:36:54 -05:00
Sharon Katz
97cd0cf70f
Add Rachel to compliance code owners (#10572) 2023-03-20 10:20:09 -04:00
RachelElysia
95fb828a03
CIS - WIN10 - 18.8.17 - 18.8.27 (#10430) 2023-03-20 09:41:11 -04:00
Mike McNeil
99136e4965
welcome tee! (#10586) 2023-03-17 22:27:38 -05:00
Eric
7190b74f2f
Website: browser compatibility updates (Edge v17, Chrome v55, Firefox v54, Opera v42, & Safari v10) (#10583)
Closes: #10496 

Changes:
- Fixed alignment issues with the <scrollable-tweets> component's page
indicator (Edge v16 & Safari 10)
- Added a hard-coded height to embedded youtube videos in Markdown
content to fix it rendering with a height of 0 (Edge v17 & Firefox v54)
- Fixed table example syntax highlighting (Edge v17, Chrome v55, Firefox
v54, Opera v42, & Safari v10)
- Added a set width to the edit page button on tables pages (Safari v10,
Firefox v54)
- Fixed a bug with the sidebar height on tables pages (Edge v17)
- Fixed styling on the pricing calculator inputs (Safari v10 & Firefox
v54)
- Fixed a layout issue with the pricing calculator call-to-action
buttons (Safari v10)
- Hid browser-specific form input buttons (Firefox v54)
- Fixed the sidebar CTA image on documentation pages (Opera v42)
- Fixed a CSS issue with the user story banner on `/platform` (Safari
v10, Firefox v54, Chrome v55, Opera v42)
- Updated the documentation page script to only copy links to the user's
clipboard if the user's browser supports it.
- Updated minimum browser versions for Edge, Chrome, and Opera for async
functions support. (Edge v16 » Edge v17, Chrome v51 » Chrome v55, Opera
v38 » Opera v42)
2023-03-17 19:36:15 -05:00
Eric
767fc39387
Update osquery schema version & regenerate merged schema (#10471)
Changes:
- Changed the version of osquery schema we merge with Fleet's overrides
from `5.7.0` to `5.8.1`
- Rand the `generate-merged-schema` script to regenerate
`osquery_fleet_schema.json` .


## EDIT
Mike: Hi Eric, if my changes look good to you, and if it's passing CI,
would you merge?

.

---------

Co-authored-by: Mike McNeil <mikermcneil@users.noreply.github.com>
2023-03-17 19:32:34 -05:00
Luke Heath
0d9bd913fd
Revert file upload change to correct functionality (#10580)
For #10562 

--

This issue was introduced in
https://github.com/fleetdm/fleet/pull/10377, which was a minor styling
fix. Because this is a release blocker, and the styling issue is not, I
am reverting the change and re-opening the other bug so we can find an
alternate, non-breaking fix.
2023-03-17 15:26:15 -07:00
Roberto Dip
f04ff27180
Prevent user action in profiles managed by Fleet (#10559)
related to https://github.com/fleetdm/fleet/issues/10547,
https://github.com/fleetdm/fleet/issues/10549,
https://github.com/fleetdm/fleet/issues/10550 and
https://github.com/fleetdm/fleet/issues/10552 this prevents user
interaction with fleet-managed profiles, including:

- batch actions
- individual POST/UPDATE/DELETE actions
- listing

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] Added/updated tests
2023-03-17 18:52:30 -03:00
Noah Talerman
6b7192ada7
Fleet UI: Edit disk encryption copy (#10573)
- On Controls > macOS Settings > Disk encryption page, edit success and
error message copy
2023-03-17 17:37:58 -04:00
gillespi314
560af163a1
Include MDM profile name and identifier in activity details (#10575) 2023-03-17 16:16:18 -05:00
Jacob Shandling
d712811410
fix the link (#10567)
## Addresses #10558 
<img width="1127" alt="Screenshot 2023-03-17 at 10 28 24 AM"
src="https://user-images.githubusercontent.com/61553566/225976422-b2d3fce8-3bc9-40e1-a4ad-bf199c91d8fe.png">

# Checklist for submitter
- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-03-17 17:07:50 -03:00
Eric
6b0242fb35
Handbook: Add section about testing website changes (#10543)
Changes:
- Added a "How can I test changes to the website?" section to the
marketing handbook.
2023-03-17 14:45:29 -05:00
Mo Zhu
e632725a44
Break up MDM docs to be smaller articles for improved readability. (#10538)
- Broke up the single MDM doc into multiple ones organized by category
- Changed any links to point to the new docs

---------

Co-authored-by: Noah Talerman <noahtal@umich.edu>
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
2023-03-17 12:34:35 -07:00
RachelElysia
0614a8543f
CIS - WIN10 - 18.9.17.x (#10529) 2023-03-17 14:53:41 -04:00
Luke Heath
64e50ee916
Enable automatic OS updates (#10565) 2023-03-17 11:58:48 -05:00
Robert Fairburn
7a795ed31d
Allow VPN to Dogfood (#10564) 2023-03-17 11:06:46 -05:00
RachelElysia
25641c094c
Fleet UI: Fix unreleased typo (#10557) 2023-03-17 11:41:54 -04:00
RachelElysia
5af7aaf12a
CIS - WIN10 - 18.8.38+ (#10449) 2023-03-17 11:41:19 -04:00
Luke Heath
e0e4aaceb8
Temporarily remove profile aggregates UI (#10561) 2023-03-17 10:29:45 -05:00
Mike McNeil
e5f6b11fa0
ADd recommendations for the fleeties (#10556)
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2023-03-16 22:28:12 -05:00
Mike McNeil
34bb930ca7
Thanks for using correct formatting (#10555)
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2023-03-16 21:59:27 -05:00
Mike McNeil
7b2e846b4a
Thanks for being a helper (#10554) 2023-03-16 21:56:28 -05:00
Mike McNeil
1a8d5412c0
Make the CEO "archive channel" to eliminate back-and-forths (#10551) 2023-03-16 20:31:05 -05:00
Mike McNeil
bd623a7c94
Update offer acceptance process (#10548)
..
2023-03-16 20:14:04 -05:00
Mike McNeil
ca65f6593d
/renew goes to Zay (#10546) 2023-03-16 19:21:47 -05:00
Mike McNeil
d696c91dba
"Significant product changes" (#10539)
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2023-03-16 18:06:08 -05:00
Jacob Shandling
92f47c7716
Disk encryption loose ends (#10541)
## Addresses #9402, #9404

## Implements

- Hides the disk encryption aggregate table while API is WIP (#9434)
- Conditionally hits a different endpoint when setting disk encryption
for team_id = 0
<img width="1282" alt="Screenshot 2023-03-16 at 3 17 18 PM"
src="https://user-images.githubusercontent.com/61553566/225764940-afce847d-bac9-4d01-a17d-5a56c2ebf3b5.png">

## Checklist for submitter

If some of the following don't apply, delete the relevant line.
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-03-16 15:31:24 -07:00
Robert Fairburn
aadfb12d51
Update dogfood deploy help_p1 webhook secret name (#10537) 2023-03-16 16:56:46 -05:00
Roberto Dip
305392e7bb
enforce an uniform collation for all tables (#10515)
related to #10441, inspired by the prior work done in
https://github.com/kolide/fleet/pull/1360, this PR:

1. Adds a migration to use `utf8mb4_general_ci` as the default collation
for the database and all the tables. From [MySQL's documentation][1]:

> To change the table default character set and all character columns
    > (CHAR, VARCHAR, TEXT) to a new character set, use a statement like
    > this:
    >
    > ```
    > ALTER TABLE tbl_name CONVERT TO CHARACTER SET charset_name;
    > ```
> The statement also changes the collation of all character columns. If
> you specify no COLLATE clause to indicate which collation to use, the
    > statement uses default collation for the character set.

2. Changes the connection settings to use `utf8mb4_general_ci` as the
default collation, from the [driver docs][2]:

   > Sets the collation used for client-server interaction on
connection. In contrast to charset, collation does not issue additional
queries. If the specified collation is unavailable on the target server,
the connection will fail.

[1]: https://dev.mysql.com/doc/refman/5.7/en/alter-table.html
[2]: https://github.com/go-sql-driver/mysql


**TODO:** discuss how we can enforce this, is setting the database
default collation enough? should we add some kind of custom lint rule to
all migrations?

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
2023-03-16 15:49:24 -03:00
Zachary Winnerman
e78554540f
Add ability to tag data containing resources (#10534)
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2023-03-16 14:10:42 -04:00
RachelElysia
00629d6742
Fleet UI: Fix software table button tooltip to overflow (#10532) 2023-03-16 13:52:02 -04:00
Noah Talerman
8262878644
MDM docs: Fix bugs (#10535)
- Click “here” link to the team YAML docs was broken
- `minimum_version` and `deadline` value should be quoted in the
documentation. Fleet expects strings
- Updated "Team settings" section name to "Teams"
2023-03-16 13:51:46 -04:00
Eric
983d04156b
Website: browser compatibility updates (iOS 10) (#10531)
Closes #10497 

Changes:
- Fixed images overflowing onto text on `/compliance` and
`/osquery-management`
- Added a set width to the edit page button on `/tables/` pages
- Fixed the sticky header not scrolling with the page
- Fixed flexbox positioning issues on the homepage, in the scrollable
tweets component, and in the mobile navigation menu
2023-03-16 11:43:09 -05:00
Zach Wasserman
42b3e5602e
Fleetd for Chrome (#10281)
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
2023-03-16 09:01:10 -03:00
Lucas Manuel Rodriguez
296b70cda3
Add CI check for spec yamls (#10530)
This is to prevent merging broken yamls.
2023-03-16 08:54:21 -03:00
Robert Fairburn
b857fee61f
Terraform MDM make DEP/ABM optional (#10462) 2023-03-16 01:09:57 -05:00
Robert Fairburn
989e0f7121
Add rds_parameters to tf module for dogfood to apply sort_buffer_size (#10528) 2023-03-16 00:31:12 -05:00
Zach Wasserman
05d8f5dbbd
Fix indentation typo in CIS yaml (#10525)
Caused a failure in
b7ebddcd66/pkg/spec/spec_test.go (L64)
2023-03-15 17:05:31 -07:00
Jacob Shandling
6f9dd8e40b
Generalize logic to ensure macos_settings always filtered with a team_id; Apply to 3 places (#10472)
## Addresses [this
discussion](https://github.com/fleetdm/fleet/pull/10385#discussion_r1134668601)

## Implements

Abstract logic to ensure a team_id is always passed with the
macos_settings filter, allowing general usage and keeping that logic in
sync everywhere it is used.

Uses this in 3 places.

## Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Added/updated tests
- [x] Manual QA

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-03-15 15:44:48 -07:00
Jacob Shandling
50994e4695
unset loading state on invalid profile upload (#10521)
## Addresses #10242 

Profile upload button now correctly exits loading state when the user
tries to upload an invalid profile.

<img width="643" alt="Screenshot 2023-03-15 at 1 14 37 PM"
src="https://user-images.githubusercontent.com/61553566/225432159-70757da6-91e1-4abd-ad4f-72725321a63d.png">

## Checklist for submitter
- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-03-15 13:42:01 -07:00
Sharon Katz
58b8d65b6f
MAC CIS 13 2.5.1 (#10168) 2023-03-15 16:40:54 -04:00
Luke Heath
2844ed3157
Ignore .vscode changes (#10519) 2023-03-15 15:27:57 -05:00
Mike McNeil
1cd72cc43c
Whoever smelt it dealt it (#10501)
..
2023-03-15 15:09:25 -05:00
Jacob Shandling
7eb931fe92
Disk encryption activity items (#10421)
## Addresses #9406

Premium:
<img width="592" alt="Screenshot 2023-03-09 at 4 26 50 PM"
src="https://user-images.githubusercontent.com/61553566/224191932-bdb5934e-72ff-4ea2-b572-308bce93cecd.png">

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/` 
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-03-15 13:08:04 -07:00
Zachary Winnerman
3158da0985
Terraform version bump (#10513)
# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [ ] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)
- [ ] Documented any permissions changes
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
  - For Orbit and Fleet Desktop changes:
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2023-03-15 12:41:25 -04:00
Jacob Shandling
f72ed66607
Request encryption key change from API and update modal copy (#10495)
## Addresses the updated specs of #9414

Update the behavior and copy of the DiskEncryptionKeyResetRequired
banner and ResetKeyModal per new specs.
* Note that this feature working correctly depends on the completion of
the API speced in #9496

![Screenshot 2023-03-14 at 4 55 46
PM](https://user-images.githubusercontent.com/61553566/225168712-d5f62b7b-ca90-4876-9c77-f7c1d1436789.png)
![Screenshot 2023-03-14 at 4 56 44
PM](https://user-images.githubusercontent.com/61553566/225168730-7d0cb9ff-81ea-4ee6-92b4-14326f3b549e.png)
![Screenshot 2023-03-14 at 4 55 50
PM](https://user-images.githubusercontent.com/61553566/225168744-13368cc2-12ab-4b5f-9be5-03247529154f.png)

## Checklist for submitter
- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-03-15 09:26:02 -07:00
RachelElysia
b49c6c82c3
CIS - WIN10 - Move approved policies to correct file (#10509) 2023-03-15 11:33:30 -04:00
Noah Talerman
534e95fce8
MDM profiles: Update display names (#10506)
- Anyone at Fleet who views the **Controls > macOS settings** page can understand what settings Fleet
controls/enforces
2023-03-15 10:58:12 -04:00
Mike Thomas
64d32c194e
Capitalization fixes (#10502)
Just fixed up a couple of capitalization errors.
2023-03-15 09:32:06 -05:00
Lucas Manuel Rodriguez
b0f490b4d6
Run make dump-test-schema (#10505)
Forgot to run this in https://github.com/fleetdm/fleet/pull/10478
2023-03-15 10:47:49 -03:00