Commit Graph

8080 Commits

Author SHA1 Message Date
Roberto Dip
1ad80fa251
bugfixes + adjustments for the puppet module (#12221)
A few minor things going on:

1. Adjusted the Puppet module to send the profiles base64 encoded
2. Enabled FileVault by default on teams created using the `/match`
endpoint.
3. Remove profiles when a team is removed. We can't do a foreign key
because the global team.id is NULL. I also included a migration to
cleanup orphaned profiles.
2023-06-08 18:05:44 -03:00
Eric
dfe8d60025
Website: fix alignment issue in Handbook mobile navigation (#12224)
Closes: #12218

Changes:
- Updated the alignment of the mobile navigation "breadcrumbs" in the
Fleet handbook.
2023-06-08 15:26:09 -05:00
Jacob Shandling
1c18765dfa
UI: Security patch (#12229)
## Addresses
[confidential/2940](https://github.com/fleetdm/confidential/issues/2940)

Patched a potential security issue in UI

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-06-08 13:13:27 -04:00
Luke Heath
c36e3ec4b0
Update community PR process (#12228) 2023-06-08 12:03:19 -05:00
Jacob Shandling
35492bcef7
UI: Fix dropdown height bug (#12215)
**Disabled the Platform dropdown's default max-height to allow it to
fully encompass its contents, which are now longer with the addition of
the ChromeOS option.**

Before (Chrome and Safari):
<img width="273" alt="Screenshot 2023-06-07 at 6 14 56 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/8fb6d0b6-20e2-4a80-ad75-a56fc60f1697">

After (All 3 browsers):
<img width="246" alt="Screenshot 2023-06-07 at 6 08 35 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/374ca4bc-b532-487c-846a-46e505b77bf2">

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-06-08 12:11:18 -04:00
Jacob Shandling
0c9528d360
UI: Ensure 'Not supported' cell for Chromebooks never wraps (#12227)
Bug:
<img width="313" alt="Screenshot 2023-06-08 at 12 02 26 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/13c23e7e-9d3f-4684-acf9-c36805ec686e">
Fixed:
<img width="325" alt="Screenshot 2023-06-08 at 12 05 03 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/fbadcd67-fbf8-42d6-9150-ce9911ba537e">

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-06-08 12:10:37 -04:00
Mike Thomas
13dcc05538
Update osquery-management.ejs (#12191)
Fixed typo in the heading for the osquery management land page.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Manual QA
2023-06-08 10:26:53 -05:00
RachelElysia
cec139d19a
Fleet Frontend: Integration test for Add hosts modal (#12064) 2023-06-08 11:15:31 -04:00
Marcos Oviedo
05c24caa95
Addressing system test findings (#12210)
This relates to #11245
2023-06-08 10:47:04 -03:00
Marcos Oviedo
ebac8705ac
Addressing issues found during system test (#12205)
This relates to #11312 

`18.9.17.6`: Fixing the issue with policy pointing to a different GPO
and Registry value
`18.9.47.4.2`: Adding COLLATE NOCASE to avoid case sensitive issue with
SpynetReporting value
2023-06-08 10:45:43 -03:00
Roberto Dip
ba68082543
return a 4xx error if a SSO session is not found (#12211)
for #12113
2023-06-07 21:12:44 -03:00
Eric
9ab1eed003
Update invalid osquery slack invitation link in markdown files (#12186)
Changes:
- Updated the old (now invalid) osquery slack invitation link to go to
fleetdm.com/slack (which redirects to a valid osquery slack invitation)
2023-06-07 17:29:57 -05:00
Roberto Dip
ab9ac28538
upgrade go version to 1.19.10 (#12187)
for #12177
2023-06-07 17:59:30 -03:00
RachelElysia
13e3d8b9b2
Fleet UI: Click dropdown label option again to deselect on manage host table (#12202) 2023-06-07 16:47:10 -04:00
Martin Angers
de42164c53
Ignore fleet profiles when matching a set of custom profiles to a team (#12209) 2023-06-07 15:43:27 -04:00
Lucas Manuel Rodriguez
2a532ede94
Do not return empty SSO and SMTP settings for non-global-admins (#12180)
#11266

PS: I first attempted a serialization trick by introducing a new
`appConfigResponse` and implementing `json.Marshal` to exclude these
fields but it was too hacky and hard to maintain moving forward, so I'm
bitting the bullet now. Happy to hear other ideas.

- [X] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- ~[ ] Documented any API changes (docs/Using-Fleet/REST-API.md or
docs/Contributing/API-for-contributors.md)~
- ~[ ] Documented any permissions changes~
- ~[ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)~
- ~[ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.~
- [X] Added/updated tests
- [X] Manual QA for all new/changed functionality
  - ~For Orbit and Fleet Desktop changes:~
- ~[ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.~
- ~[ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).~
2023-06-07 16:06:36 -03:00
gillespi314
0271ff79cf
Fix unreleased UI bug in MDM profile status modal on host details and device user pages (#12201) 2023-06-07 13:58:38 -05:00
Martin Angers
f390055847
Fix table formatting of fleetctl get mdm-command-results output (#12197) 2023-06-07 14:35:48 -04:00
JD
4f6f714d4b
Grammar and spelling fixes (#12200)
Grammar and spelling corrections.
2023-06-07 14:32:36 -04:00
Mike McNeil
8ff4363bf3
Step 1: vendor questionnaires (#11928)
.

---------

Co-authored-by: Dave Herder <dherder@gmail.com>
Co-authored-by: Dave Herder <27025660+dherder@users.noreply.github.com>
2023-06-07 10:32:48 -07:00
Martin Angers
68ddaafac0
Fix bug preventing gitops role from fleetctl applying macos setup assistant (and bootstrap package) (#12193) 2023-06-07 13:29:36 -04:00
JD
9b876de99c
MDOYVR pun-filled announcement. (#12192)
MacDevOps:YVR announcement
2023-06-07 09:41:36 -07:00
RachelElysia
82e81c2840
Fleet Frontend: Create integration tests QuerySidePanel.tests.tsx (#12179) 2023-06-07 12:01:59 -04:00
RachelElysia
95e7b9eda3
Fleet UI: Improvements to Sandbox mode styling (#12195) 2023-06-07 12:00:02 -04:00
Mo Zhu
1f66aaaf2d
Clarify product process and update rituals to implement <=6 week SLA (#12154)
Co-authored-by: Luke Heath <luke@fleetdm.com>
2023-06-07 10:37:45 -04:00
Jacob Shandling
9c44ce040f
UI: Add ChromeOS supporting features to the ManageHosts page (#12185)
## Addresses #11828 
- [x] Add ChromeOS platform filter
- [x] Increase dropdown widths to 180px for screen >1100px of:
   - [x] platform dropdown
   - [x] Labels dropdown (for consistency)
- [x] Add new null empty cell value “Not supported” for Chromebooks
- [x] Apply to the following columns:
    - [x] Disk space available
    - [x] MDM status
    - [x] MDM server URL
    - [x] Last restarted
- [x] Fix a misaligned icon in the labels dropdown, other small fixes
 
<img width="1184" alt="Screenshot 2023-06-06 at 7 09 26 PM"
src="https://github.com/fleetdm/fleet/assets/61553566/ee6fb72c-f66e-44a4-a321-8eaefff3b70b">


# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-06-06 19:37:25 -04:00
Eric
a1b4c86289
Website: Update external footer links in a new tab (#12184)
Changes:
- Updated the external links in the Fleet website footer to open in a
new tab.
2023-06-06 18:20:52 -05:00
Luke Heath
6b80c97358
Move scaling Fleet section to its own handbook page (#12181) 2023-06-06 18:19:37 -05:00
Roberto Dip
6617938393
ensure we send post-enrollment commands if a DEP device is enrolling (#12159)
for #11257, h/t to @mna for the idea of resetting `token_update_tally`.

this is to cover scenarios where a host might be re-enrolling (eg: the
device has been wiped) but we don't know about it.

since `TokenUpdate` might be called multiple times during the lifecycle
of an MDM enrollment, we add a check on the value of
`nano_enrollments.token_update_tally`. For the scenarios described
above, the tally is still `> 0` even thought the host is enrolling for
the first time.

to mitigate this, we reset its value to 0 when we receive an
`Authenticate` message (which only happens only per enrollment)

I set the value to `0` because it's incremented to `current_value+1` by
nanomdm before calling our handler.
2023-06-06 20:18:14 -03:00
Eric
46d36f993a
Website: Update documentation landing page (#12182)
Closes #11843 
Changes:
- Removed the two cards from the fleetdm.com/docs landing page, and
replaced it with a link to the osquery slack.
2023-06-06 18:05:29 -05:00
Jacob Shandling
7da0503ada
UI: Add ChromeOS UI elements to the Host Details page (#12093)
## Addresses #11830 
[Demo with simulated Chromebook
host](https://loom.com/share/5d6dda3a9c4a47bfbf1aadc900e1750a)
- Add features for ChromeOS
- Address some technical debt around this area
<img width="441" alt="agent options with tooltip and hardcoded values"
src="https://github.com/fleetdm/fleet/assets/61553566/0e0448f6-a896-4804-9b65-8eb289798c55">
<img width="1150" alt="disabled Schedule tab for chromeOS"
src="https://github.com/fleetdm/fleet/assets/61553566/ce6963ca-643a-45d1-9e68-6699eaa3a8f6">
<img width="411" alt="disk encryption"
src="https://github.com/fleetdm/fleet/assets/61553566/df486abd-bca6-43d1-92ab-8f6ea33dfb39">
<img width="1118" alt="no disk space graph"
src="https://github.com/fleetdm/fleet/assets/61553566/91823896-c824-40f1-ac15-6c8197aedd6b">

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-06-06 17:30:51 -04:00
RachelElysia
717bd0423f
Fleet UI: [Unreleased bug] Fix position of host issue icon (#12171) 2023-06-06 17:07:26 -04:00
Jacob Shandling
5cc6e5e445
UI: Add ChromeOS features to the Dashboard page (#12105)
## Addresses #11825 

- [x] Add ChromeOS to Dashboard page: <img width="1365" alt="Screenshot
2023-06-02 at 4 01 12 AM"
src="https://github.com/fleetdm/fleet/assets/61553566/e846c4b6-5fcb-4847-af05-67b2237ada39">
- [x] Add to platforms dropdown, confirm order of platform options, add
route
    - [x] Hosts summary card
- [x] Add responsiveness for <980px <img width="952" alt="Screenshot
2023-06-02 at 4 02 44 AM"
src="https://github.com/fleetdm/fleet/assets/61553566/93662957-c590-40e0-876d-6ce4adabad2b">
- [x] TODO: Confirm label number of chrome hosts label - ask Juan on
[this issue](https://github.com/fleetdm/fleet/issues/11829) - needed to
call an API to get this id
    - [x] Missing hosts card (didn’t need any changes)
    - [x] Low disk space hosts card (Not supported)
    - [x] Operating systems card

**Note for reviewers:** There is an API call happening from the
HostsSummary component to get the id for the ChromeOS label needed for
the URL to the filtered manage hosts page. This feature working properly
depends on the response from that endpoint, which is WIP. UPDATE 6/5 -
the endpoint is now working and being called correctly, though the id
being returned is WIP (backend). No need to replace anything to test.


## Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/` 
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
2023-06-06 16:44:21 -04:00
Jacob Shandling
cecb96e828
Live query performance improvements (#11995)
## Addresses #11856 

Improve performance of the rendering of live query results by:
- rendering the table on a set interval instead of with each new result
- preventing redundant rerenders of various sorts



Partial run, with memory leak:
<img width="2552" alt="partial run with memory leak, after smaller
optimizations, before debouncing queryResults"
src="https://github.com/fleetdm/fleet/assets/61553566/5288bffb-6940-43da-9083-59adb4a25916">

Full run after debounce, no memory leak (10x improvement of max JS heap
size):
<img width="2559" alt="full run after debounce, no memory leak"
src="https://github.com/fleetdm/fleet/assets/61553566/be056610-e7a5-4289-a433-1070cf016e83">

**NOTE** - there are further optimizations to try on this page, and the
debounce interval can potentially be shortened to improve UX. In
experimenting with that, it's not immediately clear what a good balance
of UX / performance is. Since the customer seems keen to solve this, I
think we should merge as-is and send them a demo build to confirm this
fixes their problem, then iterate once they've confirmed it does.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Lucas Rodriguez <lucas@fleetdm.com>
Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Co-authored-by: Sarah Gillespie <sarah@fleetdm.com>
2023-06-06 16:23:09 -04:00
Juan Fernandez
801f38b80b
Renamed 'ChromeOS' label to 'chrome' (#12156)
Renamed 'ChromeOS' label to 'chrome'
2023-06-06 15:25:23 -04:00
RachelElysia
519edbf697
Fleet UI: Improve host details/device user responsiveness (#12161) 2023-06-06 15:00:49 -04:00
Robert Fairburn
cfe59b169e
remove s3 acl from terraform/addons/logging-alb (#12169)
Fixes "the bucket does not allow acls". If it doesn't allow them, then
don't make one.

Validated logging still works.
2023-06-06 14:42:04 -04:00
Martin Angers
f27fcddd55
Prevent clearing macos updates settings when applying/modifying a team without those settings (#12160) 2023-06-06 14:31:33 -04:00
Roberto Dip
3127c9fffd
handle "modified" and "deleted" operation types in DEP sync (#12150)
for #10605, this modifies the cron used to ping the list/sync devices
API from ABM to account for the "deleted" and "modified" operation
types.

We know that:

1. Sometimes, Apple sends a "modified" operation type when a device's
MDM server is reassigned in ABM, up until now, we were ignoring these
devices.
2. Devices that are no longer assigned to Fleet in ABM can't be
migrated.
2023-06-06 15:04:59 -03:00
Dave Herder
155f3f37eb
Update MDM-migration-guide.md (#12119)
Added clarification about the end user experience when walking through
migration in manual vs. automatic enrollment workflows.
2023-06-06 10:38:49 -07:00
Sharon Katz
dc46116d44
Address not installed issue (#12165) 2023-06-06 13:37:43 -04:00
Eric
a63ad1105a
Website: update osquery slack invitation link (#12167)
Changes:
- Updated the /slack and /community redirects to go to a valid osquery
slack invitation
2023-06-06 12:02:33 -05:00
Gabriel Hernandez
2c9c9b4f0e
add verified status to UI for profile statuses (#11886)
relates to #11238

This implements the Verified status for the profile statute on the macOS
settings pages and the Host Details and My Device pages.

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
- [x] Manual QA for all new/changed functionality
2023-06-06 15:52:10 +01:00
RachelElysia
f140797938
Fleet UI: Add ChromeOS to user flows related to policies (#12095) 2023-06-06 09:44:55 -04:00
Marcos Oviedo
c6338af0a3
Adding cast to 18.9.108.4.2 (#12131)
This relates to #11668 

This change fixes a CAST issue on 18.9.108.4.2. More details
[here](https://fleetdm.slack.com/archives/C019WG4GH0A/p1685565728281039).
2023-06-06 10:37:21 -03:00
Juan Fernandez
1eb8bb800e
Bug: spec/labels endpoint should include the id (#12135)
spec/labels endpoint should include the ID prop
2023-06-06 09:11:03 -04:00
RachelElysia
206c1e60df
Fleet UI: Add ChromeOS to view and run queries (#11992) 2023-06-06 08:58:32 -04:00
Juan Fernandez
90197d83ae
Bug 11525: Fixed navigation issues on 'My Device' page (#12102)
Fixed navigation on DeviceUserPage Tab components.
2023-06-06 06:46:46 -04:00
Mike McNeil
40d866a274
Update README.md (#12155) 2023-06-06 02:01:17 -05:00
Mo Zhu
186b76b4e8
Remove unknown TODO (#12079) 2023-06-05 19:06:40 -07:00