Rename "Repr" variables to "Constr"

src/yaml_constr.erl

@@ -123,16 +123,16 @@ node_pres(Node) when is_tuple(Node) ->
     end.
 
 %% -------------------------------------------------------------------
-%% Representation.
+%% Construction.
 %% -------------------------------------------------------------------
 
-construct(Repr, #yaml_doc_start{}) ->
+construct(Constr, #yaml_doc_start{}) ->
     %% Prepare a document node.
     Doc = #yaml_doc{},
-    Repr1 = Repr#yaml_constr{
+    Constr1 = Constr#yaml_constr{
       current_doc = [Doc]
     },
-    return_new_fun(Repr1);
+    return_new_fun(Constr1);
 
 construct(_, Token) when
   is_record(Token, yaml_stream_start) orelse
@@ -146,7 +146,7 @@ construct(_, Token) when
 
 construct(
   #yaml_constr{current_doc = Doc, current_node_is_leaf = false,
-    mods = Mods, tags = Tags} = Repr,
+    mods = Mods, tags = Tags} = Constr,
   Token) when Doc /= undefined andalso
   (is_record(Token, yaml_collection_start) orelse
    is_record(Token, yaml_scalar)) ->
@@ -160,12 +160,12 @@ construct(
         #yaml_tag{uri = {non_specific, _}} ->
             %% The node has a non-specific tag. We let each module
             %% decides if they want to construct the node.
-            try_construct(Repr, Mods, Token);
+            try_construct(Constr, Mods, Token);
         #yaml_tag{uri = URI} ->
             %% We look up this URI in the tag's index.
             case proplists:get_value(URI, Tags) of
                 Mod when Mod /= undefined ->
-                    Mod:construct_token(Repr, undefined, Token);
+                    Mod:construct_token(Constr, undefined, Token);
                 undefined ->
                     %% This tag isn't handled by anything!
                     Error = #yaml_parsing_error{
@@ -179,20 +179,20 @@ construct(
                     yaml_errors:throw(Error1)
             end
     end,
-    handle_construct_return(Repr, Doc, Ret);
+    handle_construct_return(Constr, Doc, Ret);
 
 construct(
   #yaml_constr{current_doc =
-    [#unfinished_node{module = Mod} = Node | Doc]} = Repr,
+    [#unfinished_node{module = Mod} = Node | Doc]} = Constr,
   Token) ->
     %% This token continues a node. We call the current node's module to
     %% handle it.
-    Ret = Mod:construct_token(Repr, Node, Token),
-    handle_construct_return(Repr, Doc, Ret).
+    Ret = Mod:construct_token(Constr, Node, Token),
+    handle_construct_return(Constr, Doc, Ret).
 
-try_construct(Repr, [Mod | Rest], Token) ->
-    case Mod:try_construct_token(Repr, undefined, Token) of
-        unrecognized -> try_construct(Repr, Rest, Token);
+try_construct(Constr, [Mod | Rest], Token) ->
+    case Mod:try_construct_token(Constr, undefined, Token) of
+        unrecognized -> try_construct(Constr, Rest, Token);
         Ret          -> Ret
     end;
 try_construct(_, [], Token) ->
@@ -205,46 +205,46 @@ try_construct(_, [], Token) ->
     },
     yaml_errors:throw(Error).
 
-construct_parent(#yaml_constr{docs = Docs, docs_count = Count} = Repr,
+construct_parent(#yaml_constr{docs = Docs, docs_count = Count} = Constr,
   [#yaml_doc{} = Doc], Root) ->
     %% This node is the root of the document.
     Doc1 = Doc#yaml_doc{
       root = Root
     },
-    Repr1 = Repr#yaml_constr{
+    Constr1 = Constr#yaml_constr{
       docs                 = Docs ++ [Doc1],
       docs_count           = Count + 1,
       current_doc          = undefined,
       current_node_is_leaf = false,
       anchors              = dict:new()
     },
-    return_new_fun(Repr1);
-construct_parent(Repr, [#unfinished_node{module = Mod} = Node | Doc], Child) ->
+    return_new_fun(Constr1);
+construct_parent(Constr, [#unfinished_node{module = Mod} = Node | Doc], Child) ->
     %% We call the parent node's module to handle this new child node.
-    Ret = Mod:construct_node(Repr, Node, Child),
-    handle_construct_return(Repr, Doc, Ret).
+    Ret = Mod:construct_node(Constr, Node, Child),
+    handle_construct_return(Constr, Doc, Ret).
 
-handle_construct_return(Repr, Doc, {finished, Node}) ->
+handle_construct_return(Constr, Doc, {finished, Node}) ->
     %% Give this node to the parent node.
-    construct_parent(Repr, Doc, Node);
-handle_construct_return(Repr, Doc, {unfinished, Node, Is_Leaf}) ->
+    construct_parent(Constr, Doc, Node);
+handle_construct_return(Constr, Doc, {unfinished, Node, Is_Leaf}) ->
     %% Unfinished node, wait for the next tokens.
-    Repr1 = Repr#yaml_constr{
+    Constr1 = Constr#yaml_constr{
       current_doc          = [Node | Doc],
       current_node_is_leaf = Is_Leaf
     },
-    return_new_fun(Repr1).
+    return_new_fun(Constr1).
 
-return_new_fun(#yaml_constr{simple_structs = Simple} = Repr) ->
+return_new_fun(#yaml_constr{simple_structs = Simple} = Constr) ->
     Fun = fun
         (get_docs) when Simple ->
-            [Doc#yaml_doc.root || Doc <- Repr#yaml_constr.docs];
+            [Doc#yaml_doc.root || Doc <- Constr#yaml_constr.docs];
         (get_docs) ->
-            Repr#yaml_constr.docs;
+            Constr#yaml_constr.docs;
         (get_constr) ->
-            Repr;
+            Constr;
         (T) ->
-            construct(Repr, T)
+            construct(Constr, T)
     end,
     {ok, Fun}.
 
@@ -252,23 +252,24 @@ return_new_fun(#yaml_constr{simple_structs = Simple} = Repr) ->
 %% Node modules.
 %% -------------------------------------------------------------------
 
-setup_node_mods(Repr) ->
+setup_node_mods(Constr) ->
     Mods1 = umerge_unsorted(
-      proplists:get_value(node_mods, Repr#yaml_constr.options, []),
+      proplists:get_value(node_mods, Constr#yaml_constr.options, []),
       yaml_app:get_param(node_mods)
     ),
-    Mods  = case proplists:get_value(schema, Repr#yaml_constr.options, core) of
+    Schema = proplists:get_value(schema, Constr#yaml_constr.options, core),
+    Mods   = case Schema of
         failsafe -> umerge_unsorted(Mods1, ?FAILSAFE_SCHEMA_MODS);
         json     -> umerge_unsorted(Mods1, ?JSON_SCHEMA_MODS);
         core     -> umerge_unsorted(Mods1, ?CORE_SCHEMA_MODS)
     end,
-    Auto  = filter_autodetection_capable_mods(Mods, []),
-    Tags  = index_tags(Mods, []),
-    Repr1 = Repr#yaml_constr{
+    Auto    = filter_autodetection_capable_mods(Mods, []),
+    Tags    = index_tags(Mods, []),
+    Constr1 = Constr#yaml_constr{
       mods = Auto,
       tags = Tags
     },
-    return_new_fun(Repr1).
+    return_new_fun(Constr1).
 
 umerge_unsorted(List1, List2) ->
     Fun = fun(Mod, List) ->
@@ -313,12 +314,12 @@ index_tags2(Tags, [], _) ->
 %% -------------------------------------------------------------------
 
 initialize(Options) ->
-    {Repr_Options, Parser_Options} = filter_options(Options),
-    Repr = #yaml_constr{
-      options        = Repr_Options,
-      simple_structs = proplists:get_value(simple_structs, Repr_Options, true)
+    {Constr_Options, Parser_Options} = filter_options(Options),
+    Constr = #yaml_constr{
+      options        = Constr_Options,
+      simple_structs = proplists:get_value(simple_structs, Constr_Options, true)
     },
-    {ok, Token_Fun} = setup_node_mods(Repr),
+    {ok, Token_Fun} = setup_node_mods(Constr),
     [{token_fun, Token_Fun} | Parser_Options].
 
 filter_options(Options) ->
@@ -327,8 +328,8 @@ filter_options(Options) ->
         ({Name, _}) -> not lists:member(Name, Parser_Options);
         (_)         -> true
     end,
-    {Repr_Options, _} = Filtered_Opts = lists:partition(Fun, Options),
-    check_options(Repr_Options),
+    {Constr_Options, _} = Filtered_Opts = lists:partition(Fun, Options),
+    check_options(Constr_Options),
     Filtered_Opts.
 
 check_options([Option | Rest]) ->

src/yaml_node_bool.erl

@@ -26,10 +26,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}},
   text = Text} = Token) when ?IS_TRUE(Text) orelse ?IS_FALSE(Text) ->
-    construct_token(Repr, Node, Token);
+    construct_token(Constr, Node, Token);
 try_construct_token(_, _, _) ->
     unrecognized.
 

src/yaml_node_ext_bool.erl

@@ -32,10 +32,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}},
   text = Text} = Token) when ?IS_TRUE(Text) orelse ?IS_FALSE(Text) ->
-    construct_token(Repr, Node, Token);
+    construct_token(Constr, Node, Token);
 try_construct_token(_, _, _) ->
     unrecognized.
 

src/yaml_node_ext_float.erl

@@ -22,10 +22,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}}} = Token) ->
     try
-        construct_token(Repr, Node, Token)
+        construct_token(Constr, Node, Token)
     catch
         _:#yaml_parsing_error{name = not_an_float} ->
             unrecognized

src/yaml_node_ext_int.erl

@@ -27,10 +27,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}}} = Token) ->
     try
-        construct_token(Repr, Node, Token)
+        construct_token(Constr, Node, Token)
     catch
         _:#yaml_parsing_error{name = not_an_integer} ->
             unrecognized

src/yaml_node_float.erl

@@ -22,10 +22,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}}} = Token) ->
     try
-        construct_token(Repr, Node, Token)
+        construct_token(Constr, Node, Token)
     catch
         _:#yaml_parsing_error{name = not_an_float} ->
             unrecognized

src/yaml_node_int.erl

@@ -22,10 +22,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}}} = Token) ->
     try
-        construct_token(Repr, Node, Token)
+        construct_token(Constr, Node, Token)
     catch
         _:#yaml_parsing_error{name = not_an_integer} ->
             unrecognized

src/yaml_node_ipaddr.erl

@@ -23,10 +23,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}}} = Token) ->
     try
-        construct_token(Repr, Node, Token)
+        construct_token(Constr, Node, Token)
     catch
         _:#yaml_parsing_error{name = not_an_ip_address} ->
             unrecognized

src/yaml_node_json_bool.erl

@@ -26,10 +26,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}},
   text = Text} = Token) when ?IS_TRUE(Text) orelse ?IS_FALSE(Text) ->
-    construct_token(Repr, Node, Token);
+    construct_token(Constr, Node, Token);
 try_construct_token(_, _, _) ->
     unrecognized.
 

src/yaml_node_json_float.erl

@@ -22,10 +22,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}}} = Token) ->
     try
-        construct_token(Repr, Node, Token)
+        construct_token(Constr, Node, Token)
     catch
         _:#yaml_parsing_error{name = not_an_float} ->
             unrecognized

src/yaml_node_json_int.erl

@@ -22,10 +22,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}}} = Token) ->
     try
-        construct_token(Repr, Node, Token)
+        construct_token(Constr, Node, Token)
     catch
         _:#yaml_parsing_error{name = not_an_integer} ->
             unrecognized

src/yaml_node_json_null.erl

@@ -20,10 +20,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}},
   text = "null"} = Token) ->
-    construct_token(Repr, Node, Token);
+    construct_token(Constr, Node, Token);
 try_construct_token(_, _, _) ->
     unrecognized.
 

src/yaml_node_map.erl

@@ -22,9 +22,9 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_collection_start{kind = mapping} = Token) ->
-    construct_token(Repr, Node, Token);
+    construct_token(Constr, Node, Token);
 try_construct_token(_, _, _) ->
     unrecognized.
 

src/yaml_node_null.erl

@@ -20,7 +20,7 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}},
   text = Text} = Token) when
   Text == "" orelse
@@ -28,7 +28,7 @@ try_construct_token(Repr, Node,
   Text == "Null" orelse
   Text == "NULL" orelse
   Text == "~" ->
-    construct_token(Repr, Node, Token);
+    construct_token(Constr, Node, Token);
 try_construct_token(_, _, _) ->
     unrecognized.
 

src/yaml_node_seq.erl

@@ -22,9 +22,9 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_collection_start{kind = sequence} = Token) ->
-    construct_token(Repr, Node, Token);
+    construct_token(Constr, Node, Token);
 try_construct_token(_, _, _) ->
     unrecognized.
 

src/yaml_node_size.erl

@@ -23,10 +23,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}}} = Token) ->
     try
-        construct_token(Repr, Node, Token)
+        construct_token(Constr, Node, Token)
     catch
         _:#yaml_parsing_error{name = not_a_size} ->
             unrecognized

src/yaml_node_str.erl

@@ -21,8 +21,8 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node, #yaml_scalar{} = Token) ->
-    construct_token(Repr, Node, Token);
+try_construct_token(Constr, Node, #yaml_scalar{} = Token) ->
+    construct_token(Constr, Node, Token);
 try_construct_token(_, _, _) ->
     unrecognized.
 

src/yaml_node_timestamp.erl

@@ -32,10 +32,10 @@
 
 tags() -> [?TAG].
 
-try_construct_token(Repr, Node,
+try_construct_token(Constr, Node,
   #yaml_scalar{tag = #yaml_tag{uri = {non_specific, "?"}}} = Token) ->
     try
-        construct_token(Repr, Node, Token)
+        construct_token(Constr, Node, Token)
     catch
         _:#yaml_parsing_error{name = not_a_timestamp} ->
             unrecognized

testsuite/Makefile.am

@@ -3,9 +3,9 @@ TPL_PL        = template.pl
 TPL_ERL       = template.erl
 COVER_TO_HTML = cover_to_html.sh
 
-TPL_FILES = parsing.erl representation.erl
+TPL_FILES = parsing.erl construction.erl
 
-ERL_TESTS = parsing representation
+ERL_TESTS = parsing construction
 
 TESTS = dialyzer $(ERL_TESTS)
 

testsuite/data/construction/bool.pattern

@@ -20,7 +20,7 @@
           "Not a bool"
         ]
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [
@@ -101,7 +101,7 @@
             23}
         }
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }

testsuite/data/construction/empty.pattern

@@ -8,11 +8,11 @@
   [
     ?_assertMatch(
       [],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }

testsuite/data/construction/erlang_atom.pattern

@@ -14,7 +14,7 @@
           'atom requiring quoting!'
         ]
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [
@@ -31,7 +31,7 @@
                 'atom requiring quoting!'}],
             2}}
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }

testsuite/data/construction/erlang_fun.pattern

@@ -9,7 +9,7 @@
   [
     {generator,
       fun() ->
-          [Erlang_Fun_Simple] = yaml_repr:file("${FILENAME}",
+          [Erlang_Fun_Simple] = yaml_constr:file("${FILENAME}",
             [{simple_structs, true}]),
           ?_assertMatch(
             "Hello World!",
@@ -24,7 +24,7 @@
                 [{line,1},{column,28}],
                 Erlang_Fun_Normal,
                 "fun() -> \"Hello World!\" end.\n"}}
-          ] = yaml_repr:file("${FILENAME}",
+          ] = yaml_constr:file("${FILENAME}",
             [{simple_structs, false}]),
           ?_assertMatch(
             "Hello World!",

testsuite/data/construction/int.pattern

@@ -17,7 +17,7 @@
           "Not an int"
         ]
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [
@@ -61,7 +61,7 @@
             11}
         }
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }

testsuite/data/construction/ipaddr.pattern

@@ -19,7 +19,7 @@
           "Not an IP address"
         ]
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [
@@ -59,7 +59,7 @@
                 "Not an IP address"}],
             7}}
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }

testsuite/data/construction/map.pattern

@@ -13,7 +13,7 @@
           {"second", [{"item", 2}]}
         ]
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [
@@ -47,7 +47,7 @@
                         [{line,2},{column,17}],
                         2}}]}}]}}
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }

testsuite/data/construction/null.pattern

@@ -10,7 +10,7 @@
       [
         [null, null, null, null, null, "Not a null"]
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [
@@ -33,7 +33,7 @@
                 "Not a null"}],
             6}}
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }

testsuite/data/construction/seq.pattern

@@ -13,7 +13,7 @@
           [ "item", 2 ]
         ]
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [
@@ -45,7 +45,7 @@
             2}
         }
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }

testsuite/data/construction/size.pattern

@@ -15,7 +15,7 @@
           "Not a size"
         ]
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [
@@ -51,7 +51,7 @@
                 "Not a size"}],
             9}}
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }

testsuite/data/construction/timestamp.pattern

@@ -18,7 +18,7 @@
           "Not a timestamp"
         ]
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, true}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, true}])
     ),
     ?_assertMatch(
       [
@@ -55,7 +55,7 @@
                 "Not a timestamp"}],
             6}}
       ],
-      yaml_repr:file("${FILENAME}", [{simple_structs, false}])
+      yaml_constr:file("${FILENAME}", [{simple_structs, false}])
     )
   ]
 }