Commit Graph

127 Commits

Author SHA1 Message Date
Roger Meier
0b92274003 THRIFT-1597 TJSONProtocol.php is missing from Makefile.am
Patch: Andrew Grumet


git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1335717 13f79535-47bb-0310-9956-ffa450edef68
2012-05-08 19:42:33 +00:00
Roger Meier
7c7679198f THRIFT-1577 Compile thrift with php module for php 5.4.0 failed. need to replace function_entry with zend_function_entry
Patch: Matrix Ji

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1327152 13f79535-47bb-0310-9956-ffa450edef68
2012-04-17 16:03:21 +00:00
Jake Farrell
c00d83b26a Thrift-1453:Don't change types of arguments when serializing with thrift php extension
Client:php
patch: Dave Watson

Don't change types of arguments when serializing with thrift php extension



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1236972 13f79535-47bb-0310-9956-ffa450edef68
2012-01-28 03:57:58 +00:00
Roger Meier
ac70b5f832 THRIFT-1478 TJSONProtocol in PHP
fix: remove dist and add lunit log format

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1235467 13f79535-47bb-0310-9956-ffa450edef68
2012-01-24 20:18:07 +00:00
Roger Meier
33b720a958 THRIFT-1478 TJSONProtocol in PHP
Patch: Greg Fodor, Andrew Grumet, Roger Meier

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1235403 13f79535-47bb-0310-9956-ffa450edef68
2012-01-24 18:42:46 +00:00
Jake Farrell
b03a59cc5c Thrift-1427: PHP library uses non-multibyte safe functions with mbstring function overloading
Client: php
Patch: Bryan Alves

Fixes issue with php overloaded mbstring to be binary-safe for strlen and substr.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1207960 13f79535-47bb-0310-9956-ffa450edef68
2011-11-29 16:45:51 +00:00
Jake Farrell
711c70c786 Thrift-1393: TTransportException's thrown from THttpClient contain superfluous slashes in the Exception message
Client : php
Patch: Nick Jones

The THttpClient class ensures the $uri_ property has a slash prefixed by appending one if needed in the constructor. However in THttpClient::read, there are 2 exceptions thrown where a slash is concatenated between the port and uri. This results in a superfluous slash in the TTransportException message.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1185723 13f79535-47bb-0310-9956-ffa450edef68
2011-10-18 15:31:17 +00:00
Jake Farrell
51700649d0 Thrift-1377: abort PHP deserialization on unknown field type
client: php
Patch: Dave Watson

Previously the code incorrectly ignored unknown field types. After
reading the field header, if it was an unknown type it would incorrectly
assume there was no data, and start trying to read the next field
immediately. 



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179907 13f79535-47bb-0310-9956-ffa450edef68
2011-10-07 00:17:25 +00:00
Jake Farrell
b5c618a66d Thrift-1240: TBinarySerializer.php invalid serialization due to TBufferTransport not flushing last chunk of data into TMemoryBuffer
Client: php
Patch: Marimuthu Ponnambalam

Simple Serialization errors out, due to the TBufferTransport not flushing the data into TMemoryBuffer after $object->write($protocol) in TBinarySerializer.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161968 13f79535-47bb-0310-9956-ffa450edef68
2011-08-26 02:42:14 +00:00
Bryan Duxbury
11dfc8bb73 THRIFT-1225. php: TCompactProtocol for PHP
Patch: Dave Watson

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1146185 13f79535-47bb-0310-9956-ffa450edef68
2011-07-13 18:15:41 +00:00
Bryan Duxbury
2323aa9c1c THRIFT-1228. php: The php accelerator module calls flush incorrectly
This patch makes sure that filling the php extension's internal buffer does not cause a premature flush of the whole transport.

Patch: Nathaniel Cook

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1141668 13f79535-47bb-0310-9956-ffa450edef68
2011-06-30 18:59:18 +00:00
Jake Farrell
ebf0bec670 Thrift-1152: attributes from private to protected
patch: jfarrell
clent: php

Changing the TForkingServer children_ from private to protected



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1095434 13f79535-47bb-0310-9956-ffa450edef68
2011-04-20 15:23:26 +00:00
Jake Farrell
10ed8e814f THRIFT-1144: PHP client Attributes from private to protected
Updating private variable for persistant connections in TSocket to protected.


git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1091897 13f79535-47bb-0310-9956-ffa450edef68
2011-04-13 19:42:35 +00:00
Bryan Duxbury
d26cb9b325 THRIFT-690. php: Update TApplicationException codes
Patch: Nicholas Telford

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1091150 13f79535-47bb-0310-9956-ffa450edef68
2011-04-11 17:59:27 +00:00
Bryan Duxbury
d3fceb02d4 THRIFT-1098. php: Undefined properties in TBinaryProtocolFactory
Corrected some typos. 

Patch: Torben Brodt

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1083882 13f79535-47bb-0310-9956-ffa450edef68
2011-03-21 18:04:08 +00:00
Bryan Duxbury
e7b1864d46 THRIFT-867. php: PHP accelerator module's output transport is incompatible with TFramedTransport
This patch prevents TFramedTransport from flushing empty frames.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1076918 13f79535-47bb-0310-9956-ffa450edef68
2011-03-04 01:35:17 +00:00
Bryan Duxbury
c46f32ce18 THRIFT-638. php: BufferedTransport + C extensions block until recv timeout is reached on last fread call
This patch refactors TSocket to make use of stream_select() for timeout detection. 

Patch: Nicholas Telford

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1076917 13f79535-47bb-0310-9956-ffa450edef68
2011-03-04 01:25:17 +00:00
Bryan Duxbury
f1ed926969 THRIFT-1067. php: Tons of bugs in php implementation
Patch: Ruslan Usifov

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1073446 13f79535-47bb-0310-9956-ffa450edef68
2011-02-22 18:20:13 +00:00
Bryan Duxbury
7d1517aa4c THRIFT-1067. php: Tons of bugs in php implementation
Patch: Ruslan Usifov

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1073444 13f79535-47bb-0310-9956-ffa450edef68
2011-02-22 18:17:23 +00:00
Bryan Duxbury
c0e2ef50b7 THRIFT-999. php: Add TForkingServer
Patch: Nick Jones

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1063814 13f79535-47bb-0310-9956-ffa450edef68
2011-01-26 18:25:17 +00:00
Bryan Duxbury
cecbe0fc52 THRIFT-347. php: PHP TSocket Timeout Issues
This patch appears to correct the infamous timeout issues.

Patch: Tyler Hobbs

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1036684 13f79535-47bb-0310-9956-ffa450edef68
2010-11-19 00:06:51 +00:00
Mark Slee
052bbef327 THRIFT-952. TBinarySerializer utility class for converting between byte strings and PHP objects
Adds a nice TBinarySerializer class to make it simple to convert between PHP objects and serialized strings using the Binary protocol.

Patch: Radu Marin


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@1021521 13f79535-47bb-0310-9956-ffa450edef68
2010-10-11 21:45:13 +00:00
Bryan Duxbury
ded25bbe0d THRIFT-941. php: Make PHP C Extension use the defined Protocol writeMessageBegin function
This patch causes the C extension to call into user-land to get the correct writeMessageBegin function.

Patch: Chris Goffinet

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@1004864 13f79535-47bb-0310-9956-ffa450edef68
2010-10-06 00:23:30 +00:00
David Reiss
653eadab2f THRIFT-841. Exclude generated php and erlang Makefiles from "make dist"
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@1004509 13f79535-47bb-0310-9956-ffa450edef68
2010-10-05 02:38:58 +00:00
Bryan Duxbury
89200e1c9d THRIFT-854. php: Provide configure option and make rules to build/install php extension
This patch adds a make target in lib/php that builds the php extension. By default configure will attempt to build this, but it can be disabled with --without-php_extension.

Patch: Anthony Molinaro

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@989226 13f79535-47bb-0310-9956-ffa450edef68
2010-08-25 17:09:02 +00:00
Bryan Duxbury
184d26237a THRIFT-851. php: php extension fails to compile on centos 5.x
This patch introduces an approach that is compatbile with both centos and Mac.

Patch: Todd Lipcon

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@986410 13f79535-47bb-0310-9956-ffa450edef68
2010-08-17 17:43:58 +00:00
Bryan Duxbury
7b1128c94f THRIFT-682. php: PHP extension doesn't compile on Mac OS X
This patch adds a bswap_64 implementation for OS X users.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@985050 13f79535-47bb-0310-9956-ffa450edef68
2010-08-13 00:17:16 +00:00
David Reiss
cf8fc15fa0 THRIFT-837. php: Fix accelerator bug affecting writes > 8k
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@985038 13f79535-47bb-0310-9956-ffa450edef68
2010-08-12 23:27:54 +00:00
Bryan Duxbury
17115d7a52 THRIFT-778. php: PHP socket listening server
This patch which adds TServerTransport/TServerSocket, along with a generic TServer and TSimpleServer implementation.

Patch: Nick Jones

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@984864 13f79535-47bb-0310-9956-ffa450edef68
2010-08-12 16:59:19 +00:00
Bryan Duxbury
7c74d9bfb1 THRIFT-780. php: Prevent aborts due to simultaneous exceptions
The bug was triggered when flush() threw an exception in the
PHPOutputTransport destructor.

The PHPOutputTransport in thrift_protocol_write_binary() wasn't
constructed inside of the try block, so exceptions thrown when it was
auto-flushing in the destructor were calling terminate().

Move the transport construction inside of the try block, and add an
explicit flush before the transport is destroyed (since throwing an
exception from a destructor is generally a bad thing).

Patch: David Reiss

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@984815 13f79535-47bb-0310-9956-ffa450edef68
2010-08-12 15:00:41 +00:00
Bryan Duxbury
b149bc7050 THRIFT-718. php: Thrift PHP library includes closing tags and extraneous whitespace
This patch trims closing tags to avoid potential for whitespace.

Patch: Nicholas Telford

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@984811 13f79535-47bb-0310-9956-ffa450edef68
2010-08-12 14:54:33 +00:00
David Reiss
1873fed342 THRIFT-647. php: Add license header and fix style in Makefile.am
The attachment was made with the "licensed for inclusion" option, so it
should get a standard Apache license header.  Our other makefiles use
$() style for variables and don't include extra spaces before
backslashes.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@940936 13f79535-47bb-0310-9956-ffa450edef68
2010-05-04 16:32:33 +00:00
Bryan Duxbury
6a68187338 THRIFT-647. php: PHP library is missing install target
This patch adds a 'make install' target to a new PHP makefile. 

Patch: Anthony Molinaro

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@940325 13f79535-47bb-0310-9956-ffa450edef68
2010-05-02 22:39:31 +00:00
David Reiss
eb598b8c89 THRIFT-755. php: Fix compilation as a static module
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@934036 13f79535-47bb-0310-9956-ffa450edef68
2010-04-14 17:33:01 +00:00
David Reiss
006260f07a THRIFT-659. php: Make php_thrift_protocol handle std::exception cleanly
Any std::exceptions thrown from within the extension will now be
converted into php exceptions.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@920662 13f79535-47bb-0310-9956-ffa450edef68
2010-03-09 05:19:20 +00:00
David Reiss
3bb5e0581a THRIFT-683. Remove profanity
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@902941 13f79535-47bb-0310-9956-ffa450edef68
2010-01-25 19:31:31 +00:00
David Reiss
70c89d4ae0 THRIFT-350. php: Fix the extension build when C++ is not already used
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@793630 13f79535-47bb-0310-9956-ffa450edef68
2009-07-13 17:21:03 +00:00
Bryan Duxbury
af3b6309b5 THRIFT-349. php: Accelerated binary protocol serialization segementation fault
Check to make sure that the object being serialized has a valid struct spec, error otherwise.



git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@773976 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 16:53:23 +00:00
Bryan Duxbury
c2a9245d25 THRIFT-499. php: Thrift_protocol PHP extension does not handle signedness correctly
Cast all the number types to signed values before making PHP longs out of them.



git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@773974 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 16:44:52 +00:00
Bryan Duxbury
def30a6072 THRIFT-387. Add appropriate Apache header to all code files
This hits all the documentation and some misc code files that have avoided the license up to this point.



git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@763048 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 00:19:37 +00:00
David Reiss
deda141392 THRIFT-388. Create a "ONEWAY" message type that is an alias for "CALL"
Pave the way for a new message type for oneway function calls.
For now, just define the constant in all languages and make
server implementations treat it the same way as a normal call.
Only C++ and Erlang currently check the message type (on the
server side).

There is a little bit of redundancy in the Erlang code, but
the alternative is a bit gross, and this split-up will be
necessary eventually when we start handling one-way calls
differently.


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@761389 13f79535-47bb-0310-9956-ffa450edef68
2009-04-02 19:22:31 +00:00
David Reiss
887bd33772 Remove obsolete php extension tag
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760218 13f79535-47bb-0310-9956-ffa450edef68
2009-03-30 22:52:39 +00:00
David Reiss
f82aee5087 THRIFT-387. Add license statements to some autoconf macro files
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760216 13f79535-47bb-0310-9956-ffa450edef68
2009-03-30 22:52:29 +00:00
David Reiss
ea2cba8ba8 THRIFT-387. Add license headers to a bunch of files
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@760189 13f79535-47bb-0310-9956-ffa450edef68
2009-03-30 21:35:00 +00:00
David Reiss
be648eee8c THRIFT-404. php: Make TPhpStream work for cli (cgi) scripts
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758526 13f79535-47bb-0310-9956-ffa450edef68
2009-03-26 06:14:45 +00:00
David Reiss
5ab303c165 php: Improve some docblock comments for TSocket
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758516 13f79535-47bb-0310-9956-ffa450edef68
2009-03-26 04:27:47 +00:00
Bryan Duxbury
13083d6d52 THRIFT-294. Remove @author tags
They're gone. Don't add any new ones!



git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@756307 13f79535-47bb-0310-9956-ffa450edef68
2009-03-20 02:19:46 +00:00
David Reiss
a9ea68b907 Make the PHP generator dynamic.
- Modify the PHP generator constructor to fit the new generic interface.
- Register the PHP genrator with the central registry.
- Deprecate the old way of invoking the PHP generator.
- main.cc no longer includes t_php_generator.h.


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@745238 13f79535-47bb-0310-9956-ffa450edef68
2009-02-17 20:28:24 +00:00
Mark Slee
fc8a1e0469 THRIFT-169: Fixes framed/buffered transport state on underlying flush failure
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@704710 13f79535-47bb-0310-9956-ffa450edef68
2008-10-14 22:00:36 +00:00
David Reiss
1f5ce50186 THRIFT-99. php: Add scheme (http[s], etc.) support to THttpClient
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@680211 13f79535-47bb-0310-9956-ffa450edef68
2008-07-27 23:41:13 +00:00