Commit Graph

142 Commits

Author SHA1 Message Date
jfarrell
16ff233a73 Thrift-2129: php ext missing from dist
Client: php
Patch: jfarrell

Adds php extension back to dist build.
2013-08-16 09:48:42 -04:00
jfarrell
102c600bbb Thrift-2124: .o, .so, .la, .deps, .libs, gen-* files left tutorials, test and lib/cpp when making DIST
Client: build
Patch: jfarrell

Fixing all the missing files and dist build issues that have been ignored.
2013-08-15 21:20:19 -04:00
jfarrell
aa721610da THRIFT-2111: typo in php readme
Client: php
Patch: Jeremy Thomerson

Fixes type in php readme.
2013-08-02 21:55:22 -04:00
Roger Meier
1e3c884636 THRIFT-1981 Not all PHP libraries are installed when building an installing a debian package
Patch: Ricky Cormier
2013-05-30 14:04:11 +02:00
jfarrell
6bdb10b592 Thrift-1942: Binary accelerated cpp extension does not use Thrift namespaces for Exceptions
Client: php
Patch: Tyler Hobbs

Adds namespaced TException to the accelerated php client lib.
2013-04-23 15:42:04 -05:00
Jake Farrell
de262dc77e Thrift-1903: PHP namespaces cause binary protocols to not be used
Client: php
Patch: Tyler Hobbs

Resolves the issue by importing TBinaryProtocolAccelerated and checking if $this->output_ is an instance of that instead of using a static string in TProtocol.
2013-04-19 21:58:33 -04:00
Roger Meier
1f9717d192 THRIFT-1878 php: THttpClient - Add the possibility to send custom headers
Patch: Laurent Sarrazin
2013-03-23 16:03:38 +01:00
Roger Meier
9b2524415c THRIFT-1861 PHP Makefile does not include TStringFuncFactory
Patch: Logan Owen
2013-03-22 17:05:53 +01:00
Roger Meier
87afaacb95 THRIFT-1822 PHP unit test does not work
Patch: Roger Meier
2013-01-06 20:10:42 +01:00
Roger Meier
0193149842 THRIFT-1801 Sync up TApplicationException codes across languages and thrift implementations
Patch: Andrew Cox
2012-12-22 21:31:03 +01:00
Jake Farrell
7c7a5e05ba Thrift-1721:Dist broken due to 0.8.0 to 0.9.0 changes
Client: build
Patch: Jake Farrell

Fix dist build to create the 0.9.0 release



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1396880 13f79535-47bb-0310-9956-ffa450edef68
2012-10-11 00:29:11 +00:00
Roger Meier
819ad6ed3f remove unused stuff
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1395316 13f79535-47bb-0310-9956-ffa450edef68
2012-10-07 14:56:05 +00:00
Jake Farrell
78a54a17f1 THRIFT-1521:patches for more Performance
Client: php
Patch: D. Edler

Removes double function calls in the transport classes to strlen.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1390051 13f79535-47bb-0310-9956-ffa450edef68
2012-09-25 18:58:27 +00:00
Roger Meier
814818e779 THRIFT-1615
cleanup: remove empty stuff


git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1381333 13f79535-47bb-0310-9956-ffa450edef68
2012-09-05 20:07:52 +00:00
Roger Meier
21c0a85079 THRIFT-1615 PHP Namespace (was Thrift for Symfony 2)
Patch: Xavier HAUSHERR


git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1381323 13f79535-47bb-0310-9956-ffa450edef68
2012-09-05 19:47:14 +00:00
Roger Meier
0b92274003 THRIFT-1597 TJSONProtocol.php is missing from Makefile.am
Patch: Andrew Grumet


git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1335717 13f79535-47bb-0310-9956-ffa450edef68
2012-05-08 19:42:33 +00:00
Roger Meier
7c7679198f THRIFT-1577 Compile thrift with php module for php 5.4.0 failed. need to replace function_entry with zend_function_entry
Patch: Matrix Ji

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1327152 13f79535-47bb-0310-9956-ffa450edef68
2012-04-17 16:03:21 +00:00
Jake Farrell
c00d83b26a Thrift-1453:Don't change types of arguments when serializing with thrift php extension
Client:php
patch: Dave Watson

Don't change types of arguments when serializing with thrift php extension



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1236972 13f79535-47bb-0310-9956-ffa450edef68
2012-01-28 03:57:58 +00:00
Roger Meier
ac70b5f832 THRIFT-1478 TJSONProtocol in PHP
fix: remove dist and add lunit log format

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1235467 13f79535-47bb-0310-9956-ffa450edef68
2012-01-24 20:18:07 +00:00
Roger Meier
33b720a958 THRIFT-1478 TJSONProtocol in PHP
Patch: Greg Fodor, Andrew Grumet, Roger Meier

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1235403 13f79535-47bb-0310-9956-ffa450edef68
2012-01-24 18:42:46 +00:00
Jake Farrell
b03a59cc5c Thrift-1427: PHP library uses non-multibyte safe functions with mbstring function overloading
Client: php
Patch: Bryan Alves

Fixes issue with php overloaded mbstring to be binary-safe for strlen and substr.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1207960 13f79535-47bb-0310-9956-ffa450edef68
2011-11-29 16:45:51 +00:00
Jake Farrell
711c70c786 Thrift-1393: TTransportException's thrown from THttpClient contain superfluous slashes in the Exception message
Client : php
Patch: Nick Jones

The THttpClient class ensures the $uri_ property has a slash prefixed by appending one if needed in the constructor. However in THttpClient::read, there are 2 exceptions thrown where a slash is concatenated between the port and uri. This results in a superfluous slash in the TTransportException message.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1185723 13f79535-47bb-0310-9956-ffa450edef68
2011-10-18 15:31:17 +00:00
Jake Farrell
51700649d0 Thrift-1377: abort PHP deserialization on unknown field type
client: php
Patch: Dave Watson

Previously the code incorrectly ignored unknown field types. After
reading the field header, if it was an unknown type it would incorrectly
assume there was no data, and start trying to read the next field
immediately. 



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179907 13f79535-47bb-0310-9956-ffa450edef68
2011-10-07 00:17:25 +00:00
Jake Farrell
b5c618a66d Thrift-1240: TBinarySerializer.php invalid serialization due to TBufferTransport not flushing last chunk of data into TMemoryBuffer
Client: php
Patch: Marimuthu Ponnambalam

Simple Serialization errors out, due to the TBufferTransport not flushing the data into TMemoryBuffer after $object->write($protocol) in TBinarySerializer.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1161968 13f79535-47bb-0310-9956-ffa450edef68
2011-08-26 02:42:14 +00:00
Bryan Duxbury
11dfc8bb73 THRIFT-1225. php: TCompactProtocol for PHP
Patch: Dave Watson

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1146185 13f79535-47bb-0310-9956-ffa450edef68
2011-07-13 18:15:41 +00:00
Bryan Duxbury
2323aa9c1c THRIFT-1228. php: The php accelerator module calls flush incorrectly
This patch makes sure that filling the php extension's internal buffer does not cause a premature flush of the whole transport.

Patch: Nathaniel Cook

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1141668 13f79535-47bb-0310-9956-ffa450edef68
2011-06-30 18:59:18 +00:00
Jake Farrell
ebf0bec670 Thrift-1152: attributes from private to protected
patch: jfarrell
clent: php

Changing the TForkingServer children_ from private to protected



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1095434 13f79535-47bb-0310-9956-ffa450edef68
2011-04-20 15:23:26 +00:00
Jake Farrell
10ed8e814f THRIFT-1144: PHP client Attributes from private to protected
Updating private variable for persistant connections in TSocket to protected.


git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1091897 13f79535-47bb-0310-9956-ffa450edef68
2011-04-13 19:42:35 +00:00
Bryan Duxbury
d26cb9b325 THRIFT-690. php: Update TApplicationException codes
Patch: Nicholas Telford

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1091150 13f79535-47bb-0310-9956-ffa450edef68
2011-04-11 17:59:27 +00:00
Bryan Duxbury
d3fceb02d4 THRIFT-1098. php: Undefined properties in TBinaryProtocolFactory
Corrected some typos. 

Patch: Torben Brodt

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1083882 13f79535-47bb-0310-9956-ffa450edef68
2011-03-21 18:04:08 +00:00
Bryan Duxbury
e7b1864d46 THRIFT-867. php: PHP accelerator module's output transport is incompatible with TFramedTransport
This patch prevents TFramedTransport from flushing empty frames.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1076918 13f79535-47bb-0310-9956-ffa450edef68
2011-03-04 01:35:17 +00:00
Bryan Duxbury
c46f32ce18 THRIFT-638. php: BufferedTransport + C extensions block until recv timeout is reached on last fread call
This patch refactors TSocket to make use of stream_select() for timeout detection. 

Patch: Nicholas Telford

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1076917 13f79535-47bb-0310-9956-ffa450edef68
2011-03-04 01:25:17 +00:00
Bryan Duxbury
f1ed926969 THRIFT-1067. php: Tons of bugs in php implementation
Patch: Ruslan Usifov

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1073446 13f79535-47bb-0310-9956-ffa450edef68
2011-02-22 18:20:13 +00:00
Bryan Duxbury
7d1517aa4c THRIFT-1067. php: Tons of bugs in php implementation
Patch: Ruslan Usifov

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1073444 13f79535-47bb-0310-9956-ffa450edef68
2011-02-22 18:17:23 +00:00
Bryan Duxbury
c0e2ef50b7 THRIFT-999. php: Add TForkingServer
Patch: Nick Jones

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1063814 13f79535-47bb-0310-9956-ffa450edef68
2011-01-26 18:25:17 +00:00
Bryan Duxbury
cecbe0fc52 THRIFT-347. php: PHP TSocket Timeout Issues
This patch appears to correct the infamous timeout issues.

Patch: Tyler Hobbs

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1036684 13f79535-47bb-0310-9956-ffa450edef68
2010-11-19 00:06:51 +00:00
Mark Slee
052bbef327 THRIFT-952. TBinarySerializer utility class for converting between byte strings and PHP objects
Adds a nice TBinarySerializer class to make it simple to convert between PHP objects and serialized strings using the Binary protocol.

Patch: Radu Marin


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@1021521 13f79535-47bb-0310-9956-ffa450edef68
2010-10-11 21:45:13 +00:00
Bryan Duxbury
ded25bbe0d THRIFT-941. php: Make PHP C Extension use the defined Protocol writeMessageBegin function
This patch causes the C extension to call into user-land to get the correct writeMessageBegin function.

Patch: Chris Goffinet

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@1004864 13f79535-47bb-0310-9956-ffa450edef68
2010-10-06 00:23:30 +00:00
David Reiss
653eadab2f THRIFT-841. Exclude generated php and erlang Makefiles from "make dist"
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@1004509 13f79535-47bb-0310-9956-ffa450edef68
2010-10-05 02:38:58 +00:00
Bryan Duxbury
89200e1c9d THRIFT-854. php: Provide configure option and make rules to build/install php extension
This patch adds a make target in lib/php that builds the php extension. By default configure will attempt to build this, but it can be disabled with --without-php_extension.

Patch: Anthony Molinaro

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@989226 13f79535-47bb-0310-9956-ffa450edef68
2010-08-25 17:09:02 +00:00
Bryan Duxbury
184d26237a THRIFT-851. php: php extension fails to compile on centos 5.x
This patch introduces an approach that is compatbile with both centos and Mac.

Patch: Todd Lipcon

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@986410 13f79535-47bb-0310-9956-ffa450edef68
2010-08-17 17:43:58 +00:00
Bryan Duxbury
7b1128c94f THRIFT-682. php: PHP extension doesn't compile on Mac OS X
This patch adds a bswap_64 implementation for OS X users.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@985050 13f79535-47bb-0310-9956-ffa450edef68
2010-08-13 00:17:16 +00:00
David Reiss
cf8fc15fa0 THRIFT-837. php: Fix accelerator bug affecting writes > 8k
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@985038 13f79535-47bb-0310-9956-ffa450edef68
2010-08-12 23:27:54 +00:00
Bryan Duxbury
17115d7a52 THRIFT-778. php: PHP socket listening server
This patch which adds TServerTransport/TServerSocket, along with a generic TServer and TSimpleServer implementation.

Patch: Nick Jones

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@984864 13f79535-47bb-0310-9956-ffa450edef68
2010-08-12 16:59:19 +00:00
Bryan Duxbury
7c74d9bfb1 THRIFT-780. php: Prevent aborts due to simultaneous exceptions
The bug was triggered when flush() threw an exception in the
PHPOutputTransport destructor.

The PHPOutputTransport in thrift_protocol_write_binary() wasn't
constructed inside of the try block, so exceptions thrown when it was
auto-flushing in the destructor were calling terminate().

Move the transport construction inside of the try block, and add an
explicit flush before the transport is destroyed (since throwing an
exception from a destructor is generally a bad thing).

Patch: David Reiss

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@984815 13f79535-47bb-0310-9956-ffa450edef68
2010-08-12 15:00:41 +00:00
Bryan Duxbury
b149bc7050 THRIFT-718. php: Thrift PHP library includes closing tags and extraneous whitespace
This patch trims closing tags to avoid potential for whitespace.

Patch: Nicholas Telford

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@984811 13f79535-47bb-0310-9956-ffa450edef68
2010-08-12 14:54:33 +00:00
David Reiss
1873fed342 THRIFT-647. php: Add license header and fix style in Makefile.am
The attachment was made with the "licensed for inclusion" option, so it
should get a standard Apache license header.  Our other makefiles use
$() style for variables and don't include extra spaces before
backslashes.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@940936 13f79535-47bb-0310-9956-ffa450edef68
2010-05-04 16:32:33 +00:00
Bryan Duxbury
6a68187338 THRIFT-647. php: PHP library is missing install target
This patch adds a 'make install' target to a new PHP makefile. 

Patch: Anthony Molinaro

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@940325 13f79535-47bb-0310-9956-ffa450edef68
2010-05-02 22:39:31 +00:00
David Reiss
eb598b8c89 THRIFT-755. php: Fix compilation as a static module
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@934036 13f79535-47bb-0310-9956-ffa450edef68
2010-04-14 17:33:01 +00:00
David Reiss
006260f07a THRIFT-659. php: Make php_thrift_protocol handle std::exception cleanly
Any std::exceptions thrown from within the extension will now be
converted into php exceptions.

git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@920662 13f79535-47bb-0310-9956-ffa450edef68
2010-03-09 05:19:20 +00:00