Commit Graph

1657 Commits

Author SHA1 Message Date
Jens Geyer
bb5f7ec6b0 THRIFT-5091 Netstd generator produces uncompileable code for struct names ending with "_result" or "_args"
Client: netstd
Patch: Jens Geyer

THis closes #2006
2020-02-14 09:15:17 +01:00
Homarechan
ded326101a THRIFT-5072 Fix data type generation.
Client: hs
Patch: Homarechan <tikuwakunn@icloud.com>

This closes #1974
2020-02-06 23:21:02 +01:00
Gaurav Singh
7d30e2c0b6 (no ticket) catch exception by ref
Patch: Gaurav Singh

This closes #1998
2020-02-06 23:10:08 +01:00
David Mollitor
e8f82da45e THRIFT-5016 Do Not Check 'other' For Null in Equals
Client: Java
Patch: David Mollitor

This closes #1937
2020-01-28 22:53:58 +01:00
belugabehr
44d8cc6b43 THRIFT-5014: Do Direct Comparison on Raw Values Instead of Objects
Client: java

This closes #1935.
2019-12-14 09:33:37 +00:00
Duru Can Celasun
b374ce3555
THRIFT-5046: Better struct tag overrides
Custom go.tag in an IDL no longer removes the existing "db" and "json"
tags but can override them.

This allows us to change default tags in the future without affecting
user defined ones.

Client: go

This closes #1963.
2019-12-13 13:10:23 +00:00
belugabehr
418d88b447 THRIFT-5013: Replace NullPointerException with RequireNonNull
Co-Authored-By: Christopher Tubbs <ctubbsii@apache.org>

Client: java

This closes #1934.
2019-12-13 09:13:12 +00:00
Elvis Pranskevichus
9c43962da8 Revert "Revert "THRIFT-4002: Make generated exception classes immutable by default""
This reverts commit 1234ddf8a5.
2019-12-12 13:50:42 +00:00
D. Can Celasun
1234ddf8a5
Revert "THRIFT-4002: Make generated exception classes immutable by default"
This reverts commit b40f5c227f.
2019-12-10 22:13:06 +00:00
Elvis Pranskevichus
b40f5c227f
THRIFT-4002: Make generated exception classes immutable by default
Currently, the generated exception classes are not hashable under
Python 3 because of the generated `__eq__` method.  Exception objects
are generally expected to be hashable by the Python standard library.
Post-construction mutation of an exception object seems like a very
unlikely case, so enable hashing for all exceptions by making them
immutable by default.  This also adds a way to opt-out of immutability
by setting the `python.immutable` annotation to `"false"`.
2019-12-10 20:44:24 +00:00
Jens Geyer
e780855d33 THRIFT-5044 Improve serialization support for TApplicationExceptions and custom exceptions
Client: Delphi
Patch: Jens Geyer

This closes #1960
2019-12-05 09:03:10 +01:00
kahotv
1e049101c5 Generate comments for the output cpp file
Client: cpp
Patch: kahotv <root@kaho.tv>

This closes #1954
2019-12-03 23:02:15 +01:00
Paulo Neves
4266faef0e THRIFT-5032 netstd: Use PascalCase for Properties.
Client: netstd
Patch: Paulo Neves

This closes #1949
2019-11-28 21:34:32 +01:00
Duru Can Celasun
f4475ff76f
THRIFT-5019: Duplicate imports from multiple includes from a namespace
If a thrift file includes two files from the same namespace into a
separate file, the generated Go code has duplicate imports for that
namespace. This fixes that.

Client: go
2019-11-20 15:31:35 +00:00
John Boiles
59694a796f THRIFT-5002: Fix argument containers for inherited functions
Fix a bug where remote.go client fails to compile when services 
extend other services and the parent service has a function that 
needs a container for its arguments.

Client:go

This closes #1925.
2019-11-09 19:22:26 +00:00
David Furey
b1d4b3afcc THRIFT-4989: Fix run time exception when using Swift TCompactProtocol
Client: Swift
Patch: David Furey

This closes #1908

Sort TStruct members by key before generating class properties so that Swift Thrift lib can use delta encoding for CompactProtocol.
2019-11-02 15:02:54 +01:00
Jens Geyer
3f3567a114 THRIFT-4981 Remove deprecated netcore bindings from the code base
Client: netcore
Patch: Jens Geyer

This closes #1901
2019-10-20 16:21:29 +02:00
Jens Geyer
7199741f44 THRIFT-4938 Issues with version.h treatment
Client: Compiler
Patch: Jens Geyer

This closes #1902
2019-10-20 16:20:57 +02:00
Qinghui Xu
6701dbb8e8 THRIFT-4976: Delay 1 second before recompiling
Patch: Qinghui Xu

This closes #1898

In some environment, the file system only has second accuracy on
file modification timestamp, so delay of 0.1 second before
recompiling could makes the modification timestamp unchanged.
2019-10-19 21:03:08 +02:00
Jens Geyer
a899fe8412 THRIFT-4973 Add deprecation messages for csharp and netcore
Client: csharp, netcore
Patch: Jens Geyer

This closes #1895
2019-10-11 00:27:00 +02:00
Elvis Pranskevichus
ec8c7c419b THRIFT-4920: Fix generation of binary string constants
Currently, the thrift compiler generates regular string literals for
string constants marked as `binary`.  This makes the resulting type
inconsistent under Python 3.

Client: python

This closes #1843.
2019-10-08 22:51:19 +01:00
Allen George
786c019476
Merge pull request #1870 from dbcfd/thrift-4953
THRIFT-4953: Missing Field Identifiers
2019-09-23 08:41:30 -04:00
Ewan Higgs
b3745eea10 THRIFT-4932: Using a default string on a binary field results in invalid Java code.
Client: Java
Patch: Ewan Higgs

This closes #1875.
2019-09-20 16:15:04 +01:00
Danny Browning
77d96c18c3 THRIFT-4960 bare trait (dyn) warnings
Client: Rust
Patch: Danny Browning

This closes #1851
2019-09-11 23:35:26 +02:00
Danny Browning
236032a8af THRIFT-4953: Missing Field Identifiers
When identifiers are not specified, negative id will be converted to a valid
rust identifier.
2019-09-06 10:40:53 -06:00
Danny Browning
942bd8403b Bare Trait Warnings
Fixes bare trait (dyn) warnings in the library as well as generated code.
2019-09-06 10:28:24 -06:00
Laeeth Isharc
74d6d9d3d6 Initialisation of immutable data in static constructors has been
deprecated.  They now need to be initialised in shared static
constructors.

This change brings the generator for D up to date with the latest
version of the compiler, but it should continue to work with older
versions.
2019-08-11 07:54:36 -04:00
Robert Schadek
3e95c533be THRIFT-4918: Avoid dlang name conflicts
Client: dlang

Currently Thrift generates members that are invalid for D because
they are D reserved words. This change fixes the problem by 
appending a '_' to such names.

This closes #1842.
2019-08-07 09:04:46 +01:00
soroshsabz
6a61dfabbf THRIFT-4830: Add to_string helper function for cpp generator (#1765) 2019-07-01 20:13:54 -04:00
Phil Price
35cda2fa85 Fix typescript generation for multi include cases
- Ensure imports are generated for includes in *_types.d.ts files
- Ensure generated type names for struct fields and function arguments
   are prefixed with import name if the type is not defined within the same
   program.
2019-07-01 14:09:28 -04:00
Kevin Wojniak
a392566e9b THRIFT-4896 - prevent cpp and c_glib include directories from leaking into other targets (#1821)
- enable the automake `nostdinc` option
- fix up include paths
2019-07-01 14:07:45 -04:00
John Boiles
d9019fc5a4 THRIFT-4797: Fix import collisions in Go
Client: go

This closes #1811.
2019-06-29 07:07:10 +01:00
Mustafa Senol Cosar
3f0d444791 Implement episodic compilation for js code generation 2019-06-21 06:38:32 -04:00
John Boiles
5eef01f231 THRIFT-4868: Fix Go compilation for optional sets with default values (#1802)
Client: go
2019-06-13 19:49:45 +02:00
Jens Geyer
5a17b13ebc THRIFT-4879 general performance improvements for netstd library
Client: netstd
Patch: Jens Geyer

This closes #1808
2019-06-04 22:31:58 +02:00
Sergey Elin
f3d4d51d42 Add missing autogenerated comment to header files
Client: erl
2019-05-12 07:07:28 -04:00
Jens Geyer
85431d9c6a THRIFT-4862 better ToString() support for enums and container types
Client: Delphi
Patch: Jens Geyer
2019-05-10 22:49:20 +02:00
Jens Geyer
8f7487e108 THRIFT-4862 better ToString() support for enums and container types
Client: Delphi
Patch: Jens Geyer

This closes #1795
2019-05-10 00:39:30 +02:00
Danny Browning
ddec431b4a TryFrom stable
TryFrom is now stable, so use that. Additionally re-export OrderedFloat since
it is used by the generated code. Relax dependencies to reduce downstream
conflicts.
2019-03-22 14:38:36 -04:00
Jens Geyer
73a0272d66 THRIFT-4832 superfluous backing field causes CS0169 "field never used"
Client: netstd
Patch: Jens Geyer

This closes #1768
2019-03-21 09:03:19 +01:00
Jens Geyer
c6b019affd THRIFT-4768 Remove "nullable" option from the code base (netstd ONLY)
Client: netstd
Patch: Jens Geyer
2019-02-15 13:55:11 -05:00
James E. King III
393f6c93e1 THRIFT-3877: fix py/py3 server, java client with http transport
The java TestClient asks the server to runa  oneway request that
sleeps for 3 seconds.  If the java TestClient sees the duration
of the call exceed one second, it fails the test.  This means the
server did not participate in the "fire and forget" dynamics of
ONEWAY requests.  In this case the THttpServer was processing the
RPC before sending the transport response.  The fix was to enhance
the TProcessor so that the THttpServer has an opportunity to inspect
the message header before processing the RPC.

This is partly due to the violation of the THttpServer in the
layered architecture.  It is essentially implementing a combined
server and transport, whereas there should be a distinct server,
protocol, and transport separation.  Many languages seem to have
this problem where HTTP was introduced.
2019-02-11 17:46:30 -05:00
cyy
647501693b THRIFT-4776:Modernize c++11 code by clang-tidy (#1732)
* use override
* use make_shared
* use emplace
* use range for
* fix error on MSVC
* replace boost functions with std functions
* fix static analyzer warnings
* check api return value
* initialize member
* check the return value of SSL_peek > 0
* add override
2019-02-08 00:40:59 -05:00
James E. King III
4c57be0b60 THRIFT-4384: fix concurrent sync in cpp async client code 2019-02-02 22:10:41 -05:00
James E. King III
53bd0e6295 THRIFT-4745: fixes compiler warnings 2019-02-01 11:13:49 -05:00
Sebastian Zenker
2ec93c8a2d THRIFT-4763: HTML compiler produces invalid HTML document (#1720)
* HTML: the html generator did generate a closing </code> tag without a match <code>
* THRIFT-4763: added HTML test and fixed up additional HTML generation issues
2019-01-30 20:14:27 -05:00
Sebastian Zenker
042580f534 THRIFT-4762: Applied some C++11 refactorings to the runtime library and compiler (#1719)
* make use of C++11 override keyword
* added const specifier to TTransport::getOrigin()
* added more const correctness to the compiler
* make use of auto keyword
* replaced usage of NULL with nullptr
* make use of explicitly-defaulted function definition
* extended changelog
2019-01-29 09:48:12 -05:00
Jens Geyer
aa0c8b35d8 THRIFT-4723 Consolidate C#/netcore into new netstd language target
Client: netstd
Patch: Jens Geyer

This closes #1710
2019-01-28 23:12:28 +01:00
James E. King III
29f7f8f32f THRIFT-4743: remove cpp compiler plugin support to simplify the project 2019-01-26 23:53:38 -05:00
Mustafa Senol Cosar
129bb3e10d THRIFT-4675: Fix int64 constants generation for map keys 2019-01-25 10:03:37 -05:00