Commit Graph

3622 Commits

Author SHA1 Message Date
Jens Geyer
9f11c1e545 THRIFT-5004 Make exception implementations more consistent [ci skip]
Client: Delphi
Patch: Jens Geyer
2019-11-13 09:34:57 +01:00
Yuxuan 'fishy' Wang
24fa9d0728 THRIFT-4914: Add GetResponseHeadersFromClient helper function
This is the fourth and final part of THRIFT-4914, which handles the
client reading part in the response (server -> client direction).

Client: go

This closes #1926.
2019-11-09 22:21:09 +00:00
John Boiles
59694a796f THRIFT-5002: Fix argument containers for inherited functions
Fix a bug where remote.go client fails to compile when services 
extend other services and the parent service has a function that 
needs a container for its arguments.

Client:go

This closes #1925.
2019-11-09 19:22:26 +00:00
Yuxuan 'fishy' Wang
4c27181a06 THRIFT-4914: Add TResponseHelper
This is the third part of THRIFT-4914, which handles the server writing
part in the response (server -> client direction).

Define a new type, TResponseHelper, which only contains THeader related
functions for now, but can be extended for other functions in the
future.

In TSimpleServer, inject a TResponseHelper into the context object
passed into the handler functions. Handler function code could retrieve
the injected TResponseHelper to set headers to be written to the client.

Client: go

This closes #1923.
2019-11-09 19:20:09 +00:00
zembord
50caa4de84 THRIFT-4990: Upgrade to .NET Core 3.0
Client: netstsd
Patch: Edward Zhuravlov

This closes #1921
2019-11-08 19:24:59 +01:00
Yuxuan 'fishy' Wang
963812ae62 THRIFT-4984: Handle wrapped io.EOF errors
TCompactProtocol (which is used by THeaderTransport to read headers)
could wrap the underlying error with TProtocolException, which breaks
err == io.EOF test in some cases.

Client: go

This closes #1922.
2019-11-08 09:02:00 +00:00
Kevin Wojniak
596e25f9b0 Fix unknown pragma warnings on mingw
Client: cpp
Patch: Kevin Wojniak

This closes #1917

These pragmas are only valid for MSVC. Fixes warnings found in the logs:

> In file included from C:\projects\thrift\lib\cpp\test\processor\ProcessorTest.cpp:40:
731C:\projects\thrift\lib\cpp\test\processor\Handlers.h:143: warning: ignoring #pragma warning  [-Wunknown-pragmas]
732  143 |   #pragma warning( push )
733      |
734C:\projects\thrift\lib\cpp\test\processor\Handlers.h:144: warning: ignoring #pragma warning  [-Wunknown-pragmas]
735  144 |   #pragma warning (disable : 4250 ) //inheriting methods via dominance
736      |
737C:\projects\thrift\lib\cpp\test\processor\Handlers.h:172: warning: ignoring #pragma warning  [-Wunknown-pragmas]
738  172 |   #pragma warning( pop )
739      |
2019-11-06 01:11:55 +01:00
Yuxuan 'fishy' Wang
4653009035 THRIFT-4984: Ignore EOF errors in TSimpleServer, take 2
This is a different approach to take THRIFT-4984: Instead of checking
EOF errors in place, handle them in a consolidated, deferred function.

Also improve test error messages.

Client: go

This closes #1907.
2019-11-05 21:31:13 +00:00
Eugen Kandakov
f7b2197916 THRIFT-4994 changed this to self in forEach callback
Client: nodejs
Patch: Eugen Kandakov

This closes #1918
2019-11-04 22:00:24 +01:00
xiongjieqing
a5b2bf5b0b THRIFT-4992 thrift lua TcompactProtocol bug fix #1881
Client: Lua
Patch: xiongjieqing <xiongjieqing@gmail.com>
2019-11-03 19:07:13 +01:00
Jens Geyer
c5fadee94a Revert "thrift lua TcompactProtocol bug fix"
This reverts commit 3adb44aa26.
2019-11-03 19:07:04 +01:00
xiongjieqing
3adb44aa26 thrift lua TcompactProtocol bug fix 2019-11-03 18:59:39 +01:00
Kevin Wojniak
cf73b66cd8 Remove unused exception variable
Client: Python
Patch: Kevin Wojniak

This closes #1912

Fixes MSVC warning seen in logs:
> [00:11:03] src\ext/protocol.tcc(177): warning C4101: 'ex': unreferenced
> local variable [C:\projects\build\MSVC2015\x86\lib\py\python_build.vcxproj]
2019-11-03 18:42:11 +01:00
Kevin Wojniak
bc75467e44 Fix "thruth" typo
Client: Go
Patch: Kevin Wojniak

This closes #1911
2019-11-03 18:39:38 +01:00
Jens Geyer
43a93f1e6e fix typo in cmake
Patch: Jens Geyer

This closes #1910
2019-11-03 18:34:24 +01:00
Jens Geyer
ec439548c5 THRIFT-4990 Switch to .NET core 3.0
Client: netstsd
Patch: Jens Geyer

This closes #1909
2019-11-02 17:34:23 +01:00
Jens Geyer
9ea48f362a Fix PHP style errors (by means of phpcbf) [ci skip] 2019-11-02 12:24:12 +01:00
Yuxuan 'fishy' Wang
e4870a3571 THRIFT-4985: Refactor logging in Go library
- Add a new Logger type to make logging configurable
- Use the new logger in TSimpleServer and TDebugProtocol
- Remove pointless log in TZlibTransport
- Remove panic recovery from TSimpleServer. Thrift shouldn't catch panics caused by caller-defined RPC handlers.

Client: go

This closes #1906.
2019-10-24 21:23:30 +01:00
Yuxuan 'fishy' Wang
c03e2aa196 THRIFT-4984: Ignore EOF error in TSimpleServer ReadFrame call
EOF isn't an error that should be bubbled up to the 
caller and we are already ignoring other EOF errors in 
TSimpleServer.processRequest [0].

Client: go

This closes #1904.

[0]: cecee50308/lib/go/thrift/simple_server.go (L265-L266)
2019-10-23 21:43:09 +01:00
pengzhouhu
6e4c581fdd THRIFT-4949: Improve HTTP/1 server test case
Client: java

This closes #1886.
2019-10-21 15:21:11 +01:00
Jens Geyer
3f3567a114 THRIFT-4981 Remove deprecated netcore bindings from the code base
Client: netcore
Patch: Jens Geyer

This closes #1901
2019-10-20 16:21:29 +02:00
Jens Geyer
616df98f00 fix veralign.sh and bump version (again) 2019-10-20 00:12:14 +02:00
D. Can Celasun
76fa8c9a81
Update Java dependencies
Update most dependencies to their latest versions, replace findbugs with
spotbugs as the former is dead and was replaced with the latter.

Fixes THRIFT-4937.

Client: java
2019-10-18 15:15:45 +01:00
pengzhouhu
9f0548e05f THRIFT-4952 Modified ssl_read feedback value break all the time error.
Client: c_glib
Patch: pengzhouhu <pengzhouhu@huawei.com>

This closes #1869
2019-10-18 00:26:47 +02:00
Jens Geyer
5fe31ea7d7 bump version 2019-10-17 23:51:36 +02:00
Jens Geyer
4286054d3d Merge branch '0.13.0' 2019-10-17 23:49:41 +02:00
Jens Geyer
b75e88a33d FIX netstd assembly version 2019-10-17 23:47:40 +02:00
Jens Geyer
dd14e869ce Fix PHP style errors (by means of phpcbf) 2019-10-17 20:54:34 +02:00
Jens Geyer
e02559fd46 bump version
This closes #1899
2019-10-17 20:31:24 +02:00
Mario Emmenlauer
0f14e2f3f6 THRIFT-4977: Allow loading OpenSSL certificates from memory
Client: cpp

This closes #1860.
2019-10-15 10:25:10 +01:00
wineandcheeze
ab89b8b40e THRIFT-2530: Fix TIOStreamTransport#isOpen
isOpen should return false when close is called.

Client: java

This closes #1878.
2019-10-10 12:50:50 +01:00
Jens Geyer
224b43ec7e THRIFT-4874: Thrift 0.12.0 Source Distribution (.tar.gz) Contains Hardlinks - Extract Fails
Client: Build system
Patch: Jens Geyer

This closes #1894

The patch contains a modified version of tar.m4. The --hard-dereference option prevents from a situation, where symlinks (used in the compiler/src subtree) get converted into hard links.
2019-10-10 01:28:55 +02:00
wineandcheeze
904f5619a9 THRIFT-4858: Add error message to TTransportException
When the socket is closed (EOF of the inputstream), currently
TIOStreamTransport throws an TTransportException without message,
this is sometimes confusing for people maintaining a thrift server
(eg. apache hive).

Client: java

This closes #1876.
2019-10-09 09:27:23 +01:00
pengzhouhu
a152a0ad88 THRIFT-4945: Fix non-standard log output
Client: java

This closes #1862.
2019-10-08 23:18:30 +01:00
HIRANO Satoshi
8098428901 Add Node.js example for browsers
Client: js

This closes #1864.
2019-10-08 23:06:30 +01:00
Ben Evans
dfa74bc99e Upgrade to Gradle 5.6.2
This closes #1882.
2019-10-08 22:54:08 +01:00
Kengo Seki
5a8cd9d1fb THRIFT-4971: Fix lib/rb/spec/union_spec.rb so that CI succeeds
Client: Ruby
Patch: Kengo Seki

This closes #1891
2019-10-06 12:17:19 +02:00
Allen George
786c019476
Merge pull request #1870 from dbcfd/thrift-4953
THRIFT-4953: Missing Field Identifiers
2019-09-23 08:41:30 -04:00
pengzhouhu
2d03630b61 THRIFT-4950 fix bind print error and Macro call errors thrift_server_socket
Client: C_glib
Patch: pengzhouhu

This closes #1867
2019-09-22 11:38:29 +02:00
Guillaume Blanc
5e9203b2b2 THRIFT-4962 Fix deadlock in TimerManager::stop
Client: cpp
Author: Guillaume Blanc

This closes #1877
2019-09-21 14:40:15 +02:00
Ewan Higgs
b3745eea10 THRIFT-4932: Using a default string on a binary field results in invalid Java code.
Client: Java
Patch: Ewan Higgs

This closes #1875.
2019-09-20 16:15:04 +01:00
Danny Browning
77d96c18c3 THRIFT-4960 bare trait (dyn) warnings
Client: Rust
Patch: Danny Browning

This closes #1851
2019-09-11 23:35:26 +02:00
Vladimir Arkhipov
f1bc6aef7d Fix typo in xml comment
Client: C#
Patch: Vladimir Arkhipov

This closes #1874
2019-09-11 23:11:46 +02:00
Jens Geyer
b7bd211699 Prevent "Log file size too large" messages during CI tests 2019-09-11 22:52:40 +02:00
Jens Geyer
8ff8abd6f2 THRIFT-4957 testSanePartsOfCompactProtoTestStruct FAILED
Client: Java
Patch: Jens Geyer

This closes #1873
2019-09-11 00:41:49 +02:00
Danny Browning
236032a8af THRIFT-4953: Missing Field Identifiers
When identifiers are not specified, negative id will be converted to a valid
rust identifier.
2019-09-06 10:40:53 -06:00
Danny Browning
942bd8403b Bare Trait Warnings
Fixes bare trait (dyn) warnings in the library as well as generated code.
2019-09-06 10:28:24 -06:00
Jens Geyer
a715f701bf THRIFT-4944 Field IDs > 255 fail with compact protocol
Cliwent: Delphi
Patch: Jens Geyer
2019-08-28 22:56:35 +02:00
Jens Geyer
a4fc3d42e9 THRIFT-4907 strong named assemblies wanted
Client: netstd
Patch: Jens Geyer

This closes #1854
2019-08-25 14:04:58 +02:00
Alex-Rud
693e19cf48 THRIFT-4939 TThriftListImpl<T>.Sort() does not use comparer
Client: Delphi
Patch: Alex-Rud <Alex.van.rudik@gmail.com>
2019-08-25 00:20:55 +02:00