Commit Graph

70 Commits

Author SHA1 Message Date
Mark Slee
5ec19933cb Resolve complex typedefs in Thrift
Summary: For function returns

Reviewed By: aditya


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664917 13f79535-47bb-0310-9956-ffa450edef68
2007-01-16 23:53:53 +00:00
Mark Slee
a340e0d6fe Thrift should generate C++ enums first before typdefs
Summary: In case you want to typedef an enum

Reviewed By: aditya


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664916 13f79535-47bb-0310-9956-ffa450edef68
2007-01-16 23:00:31 +00:00
Mark Slee
406a40cf16 Prefix generated _args and _result helper classes with service name
Summary: To avoid conflicts when you have two services with the same name inside one .thrift file

Reviewed By: aditya


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664915 13f79535-47bb-0310-9956-ffa450edef68
2007-01-16 22:48:22 +00:00
Mark Slee
a45909b619 Thrift C++ code generator returns complex types by reference
Summary: Efficiency, Yo.

Reviewed By: aditya


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664910 13f79535-47bb-0310-9956-ffa450edef68
2007-01-12 21:44:14 +00:00
Mark Slee
529bfeef97 Committing code gen changes for const ref args to functions in Thrift
Reviewed By: aditya


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664909 13f79535-47bb-0310-9956-ffa450edef68
2007-01-12 02:10:16 +00:00
Mark Slee
e888b376ad Add PHP namespacing support to Thrift
Summary: "php_namespace Whoa" at the top of your Thrift file, then all your defined class names start with "Whoa_"

Reviewed By: aditya


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664908 13f79535-47bb-0310-9956-ffa450edef68
2007-01-12 01:06:24 +00:00
Mark Slee
f12865a338 Disallow keywords in Thrift files
Summary: Or else you are bound to get shitty errors in some generated languages.. They're not all covered here, but a lot of them are.

Reviewed By: dougb, bobby


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664907 13f79535-47bb-0310-9956-ffa450edef68
2007-01-12 00:23:26 +00:00
Mark Slee
706da40237 Fix exceptions throw() and virtual destructor
Reviewed By: yishan


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664897 13f79535-47bb-0310-9956-ffa450edef68
2006-12-16 00:59:29 +00:00
Mark Slee
971fda34b5 All user-defined thrift exceptions inherit from TException
Summary: So you can catch more effectively

Reviewed By: tbr-karl


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664896 13f79535-47bb-0310-9956-ffa450edef68
2006-12-15 19:07:04 +00:00
Mark Slee
0524bcee68 Another AccessNull bug fix in Thrift
Reviewed By: yhishan


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664895 13f79535-47bb-0310-9956-ffa450edef68
2006-12-13 01:54:56 +00:00
Mark Slee
069d31e7b9 Fix c++ Null inheritance issue
Reviewed By: yishan


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664894 13f79535-47bb-0310-9956-ffa450edef68
2006-12-13 01:45:26 +00:00
Mark Slee
cbea1c7ef3 Take out timestamps from generated files
Summary: File system does this for you.

Reviewed By: martin, yishan


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664893 13f79535-47bb-0310-9956-ffa450edef68
2006-12-13 01:07:33 +00:00
Mark Slee
962a858566 Generate a null implementation of thrift C++ class for easy subclassing
Summary: Sometimes you just want a subclass that only implements one method... annoying to fill in nulls for the others, so use the generated null class

Reviewed By: tbr-aditya


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664888 13f79535-47bb-0310-9956-ffa450edef68
2006-12-08 19:15:35 +00:00
Mark Slee
807b2c601d Missing file in thrift parser, sorry d00dz!
Summary: Forgot to svn add


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664885 13f79535-47bb-0310-9956-ffa450edef68
2006-11-30 00:55:41 +00:00
Mark Slee
7657fa9747 Oops take out printf debug
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664884 13f79535-47bb-0310-9956-ffa450edef68
2006-11-29 22:07:23 +00:00
Mark Slee
600cdb337e Thrift supports HEX notation for int consts and proper python/php sets
Reviewed By: yishan-tbr


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664883 13f79535-47bb-0310-9956-ffa450edef68
2006-11-29 22:06:42 +00:00
Mark Slee
67fc63410d Strings in JSON style thrift constants do not need quotes
Summary: Cause it's just too much work to put in quotes sometimes. struct thing = { a : 325, bb : 5632} OBVIOUSLY a and bb are strings. Duh.


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664882 13f79535-47bb-0310-9956-ffa450edef68
2006-11-29 03:37:04 +00:00
Mark Slee
aa7671d041 Thrift supports arbitrarily typed constants across all languages
Summary: Hot! Now you can defined your maps to strings and other constnats things in your .thrift file, so you can have the same symbols and useful defaults defined in your client as in your server.


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664881 13f79535-47bb-0310-9956-ffa450edef68
2006-11-29 03:19:31 +00:00
Mark Slee
301528702c Thrift compiler frontend support for constants
Summary: The parser now accepts constants and adds them into the parse tree


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664880 13f79535-47bb-0310-9956-ffa450edef68
2006-11-28 01:24:07 +00:00
Mark Slee
d3bc1a5f52 Fix _seqid to seqid_ name change in PHP
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664879 13f79535-47bb-0310-9956-ffa450edef68
2006-11-27 20:25:43 +00:00
Mark Slee
216e7d6a9a Fix thrift compiler typedef support
Summary: Typedefed containers were wonk'd

Reviewed By: martin


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664877 13f79535-47bb-0310-9956-ffa450edef68
2006-11-21 00:44:23 +00:00
Mark Slee
b9ff32ae30 Thrift: C++ peek() method and TException not Exception
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664876 13f79535-47bb-0310-9956-ffa450edef68
2006-11-16 01:00:24 +00:00
Mark Slee
04cc605597 Comma after ENUM with no explicit value
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664874 13f79535-47bb-0310-9956-ffa450edef68
2006-11-15 21:25:34 +00:00
Mark Slee
6e81b3fb5c Rest definition should not implement interface, the method signatures are different.
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664873 13f79535-47bb-0310-9956-ffa450edef68
2006-11-14 23:51:27 +00:00
Mark Slee
5ea94d444b Thrift generates a REST handler for PHP code
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664872 13f79535-47bb-0310-9956-ffa450edef68
2006-11-14 23:48:00 +00:00
Mark Slee
19e71c34b1 All thrift PHP class constructors can take an array as the constructor argument
Summary: It will init any field with the value in the array. Hot for converting DB rows into thrift objs.


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664871 13f79535-47bb-0310-9956-ffa450edef68
2006-11-10 23:07:35 +00:00
Mark Slee
52cb2234de I lied before, now thrift really supports single or double dashes
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664870 13f79535-47bb-0310-9956-ffa450edef68
2006-11-10 22:32:07 +00:00
Mark Slee
2329a83701 Allow single dash or double dash for thrift flags
Reviewed By: martin


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664869 13f79535-47bb-0310-9956-ffa450edef68
2006-11-09 00:23:30 +00:00
Martin Kraemer
32c66e1506 Thrift Include Path Specification
Summary:
Add support for include path specification in thrift.  Using a -I <dir> option you can build a list of search paths to resolve thrift includes.

Reviewed By: mcslee

Revert Plan: revertible


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664868 13f79535-47bb-0310-9956-ffa450edef68
2006-11-09 00:06:36 +00:00
Mark Slee
ae2bc3c8d6 Do not print ; in thrift parser
Reviewed By: bizsys d00dz


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664867 13f79535-47bb-0310-9956-ffa450edef68
2006-11-08 23:44:59 +00:00
Mark Slee
8d2b238697 Fix C++ skeleton code generator
Summary: Do not reference TBufferedTransportFactory.h

Reviewed By: yishan


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664865 13f79535-47bb-0310-9956-ffa450edef68
2006-11-06 21:40:11 +00:00
Mark Slee
207cb46af8 Make commas and/or semicolons both optional in thrift
Reviewed by: karl


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664864 13f79535-47bb-0310-9956-ffa450edef68
2006-11-02 18:43:12 +00:00
Mark Slee
b39dbc5891 Iterate python dictionaries with for k,v in dict.items()
Notes:


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664863 13f79535-47bb-0310-9956-ffa450edef68
2006-10-31 05:56:27 +00:00
Mark Slee
bc4bc0f8f4 Py inherited processor must pass handler to parent constructor
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664862 13f79535-47bb-0310-9956-ffa450edef68
2006-10-31 05:45:33 +00:00
Mark Slee
6b4783b96b Inherited processors must call parent constructor in python
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664861 13f79535-47bb-0310-9956-ffa450edef68
2006-10-31 05:43:53 +00:00
Mark Slee
725f9e6c71 Use AbstractMap instead of HashMap
Summary: So ConcurrentHashMap can be used safely


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664859 13f79535-47bb-0310-9956-ffa450edef68
2006-10-31 05:08:33 +00:00
Mark Slee
d07ce6013b Fix Python indentation for async methods
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664857 13f79535-47bb-0310-9956-ffa450edef68
2006-10-27 22:30:15 +00:00
Mark Slee
5ee76f8d7d Skeletons should use virtual inheritance from the interface base
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664856 13f79535-47bb-0310-9956-ffa450edef68
2006-10-26 18:15:02 +00:00
Mark Slee
5f8237d4de Thrift PHP update for new Protocol wraps Transport style
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664854 13f79535-47bb-0310-9956-ffa450edef68
2006-10-26 04:57:03 +00:00
Mark Slee
a3f3972e3d Fix bum Java indentation/scoping for async methods
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664850 13f79535-47bb-0310-9956-ffa450edef68
2006-10-26 02:52:47 +00:00
Mark Slee
5946a18596 New python operating model code-gen
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664848 13f79535-47bb-0310-9956-ffa450edef68
2006-10-25 21:38:39 +00:00
Mark Slee
575fa9a0df Protocol wraps transport code gen for Thrift Java
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664847 13f79535-47bb-0310-9956-ffa450edef68
2006-10-25 20:54:10 +00:00
Mark Slee
f0712dc994 Update thrift compiler for new syntax, generate new form of C++ code
Reviewed By: wayne, he loves less warnings


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664840 13f79535-47bb-0310-9956-ffa450edef68
2006-10-25 19:03:57 +00:00
Mark Slee
65681d061e Generate .cpp files instead of .cc in Thrift
Reviewed By: aditya

Notes: Be consistent on cpp, dunno why ever chose cc


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664829 13f79535-47bb-0310-9956-ffa450edef68
2006-10-12 03:58:49 +00:00
Mark Slee
4f8da1dfb4 Allow the specification of custom container types in Thrift IDL files
Summary: If you want your map to be a hash_map instead of an stl::map, we now have a directive in Thrift to let you do that.

Instead of:
map<i32,i32>

You can do:
map[cpp:hash_map<int32_t,int32_t>]<i32,i32>

This tells the Thrift compiler to explicitly use whatever type was specified in the brackets when generating C++ code, instead of the implied Thrift type.

Reviewed By: aditya


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664828 13f79535-47bb-0310-9956-ffa450edef68
2006-10-12 02:47:27 +00:00
Mark Slee
f5377b3e99 Thrift compiler code cleanup, comments, php inline generation, etc
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664822 13f79535-47bb-0310-9956-ffa450edef68
2006-10-10 01:42:59 +00:00
Mark Slee
96a6bbec1a Python remote printing fix
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664817 13f79535-47bb-0310-9956-ffa450edef68
2006-10-06 22:43:29 +00:00
Mark Slee
748e576f6c Python generator to make __str__ and __repr__ methods for generated structs
Summary: Also generate a nice command line -remote utility like pillar

Reviewed By: ccheever


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664816 13f79535-47bb-0310-9956-ffa450edef68
2006-10-04 21:51:05 +00:00
Mark Slee
f77ff06a3b Prefix php names with service_ to avoid naming conflicts and use False not false in python
git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664811 13f79535-47bb-0310-9956-ffa450edef68
2006-09-29 21:33:55 +00:00
Mark Slee
6979bdb557 Use vector<> instead of list<> in Thrift-gen'd C++ code
Summary: vector kindly provides [] access

Reviewed By: aditya


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664808 13f79535-47bb-0310-9956-ffa450edef68
2006-09-27 22:11:45 +00:00