Commit Graph

73 Commits

Author SHA1 Message Date
Jens Geyer
527b6d9c86 THRIFT-2854 Go Struct writer and reader looses important error information
Client: Go
Patch: Chi Vinh Le <cvl@chinet.info>

This closes #291

Fixes error reporting in go generator
2014-11-30 15:24:08 +01:00
Jens Geyer
1e7971cfff THRIFT-2851 Remove strange public Peek() from Go transports
Client: Go
Patch: Chi Vinh Le

This closes #283

In its current form Peek() is not only useless, but misleading.
If anyone can provide a better implementation, please do.
2014-11-25 21:43:54 +01:00
Jens Geyer
740db54d1a THRIFT-2853 Adjust comments that doesn't apply anymore because of THRIFT-2852
Client: Go
Patch: Chi Vinh Le <cvl@chinet.info> & Jens Geyer

This closes #286
2014-11-25 00:37:33 +01:00
Jens Geyer
cb0afcc035 THRIFT-2852 Better Open/IsOpen/Close behavior for StreamTransport.
Client: Go
Patch: Chi Vinh Le <cvl@chinet.info>

This closes #285
2014-11-24 22:55:42 +01:00
Konrad Grochowski
3b5dacba44 THRIFT-2849: spelling errors fixed using codespell tool
Client: All
Patch: Anatol Pomozov

This closes #281
2014-11-24 10:55:31 +01:00
Jens Geyer
5f9bdffd2a THRIFT-2841 Add comprehensive integration tests for the whole Go stack
Client: Go
Patch: Chi Vinh Le <cvl@chinet.info>

This closes #273
2014-11-18 22:18:15 +01:00
Jens Geyer
0dd4801ce5 THRIFT-2839 TFramedTransport read bug
Client: Go
Patch: Chi Vinh Le <cvl@chinet.info>
2014-11-18 22:18:13 +01:00
Jens Geyer
2f971e8f74 THRIFT-2817 Smarter buffer peeking for json protocols
Client: Go
Patch: Chi Vinh Le <cvl@chinet.info>
2014-11-18 22:18:09 +01:00
Jens Geyer
6794c62485 THRIFT-2812 Go server adding redundant buffering layer
Client: Go
Patch: Craig Peterson

This closes #259

It has been pointed out to me that #249 was wrong. It was not needed to allow server sockets to use buffering. The correct way is to pass in a TBufferedTransportFactory to the server. This will create buffered sockets as the processor starts up.

This change creates extra buffering, and is actually a real pain to deactivate. Sorry.
2014-11-11 00:11:16 +01:00
Jens Geyer
4c33094050 THRIFT-2811 Make remote socket address accessible
Client: Go
Patch: Craig Peterson

This closes #255

Go Library - Make remote socket address accessible

In my server I would like to log the remote ip address of incoming connections. This patch makes the addr available on TSocket via an accessor, so my server implementation can read it and log it or do other things with it.
2014-11-10 21:22:34 +01:00
Jens Geyer
cc15dff127 THRIFT-2791 Allowing use of buffered sockets in go server
Client: Go
Patch: Craig Peterson

This closes #249
2014-10-29 19:54:58 +02:00
Jens Geyer
157691fa98 THRIFT-2785 Wrap errors in iostream_transport.go
Client: Go
Patch: GitHub user cvlchinet <cvl@chinet.info>

This closes #246

Wrap errors in iostream_transport.go using NewTTransportExceptionFromError

When I used the StreamTransport to do unit tests I noticed that the EOF TTransportException is not correctly thrown. I quickly found out that the errors in iostream_transport.go where not wrapped with NewTTransportExceptionFromError.
2014-10-13 21:34:51 +02:00
Jens Geyer
79f988c27a THRIFT-2768: Whitespace Fixup
Client: General (Makefile.am)
Patch: Jens Geyer

Reverted makefile.am - tabs are not optional there
2014-10-03 20:42:54 +02:00
Jens Geyer
aaa8947f3a THRIFT-2768: Whitespace Fixup
Client: General (Makefile.am, *.thrift)
Patch: Jens Geyer

DocTest.thrift has NOT been changed, the trailing whitespaces are part of the test case.
2014-10-03 20:30:38 +02:00
Jens Geyer
a86886e77d THRIFT-2704 - compiler: T_ONEWAY type used for oneway methods instead of T_CALL
Patch: Konrad Grochowski

This closes #216
2014-09-17 22:36:00 +02:00
Jens Geyer
f04d9f45dd make clean should remove gen-go folder 2014-07-27 13:35:04 +02:00
Roger Meier
ce9cf13bb3 THRIFT-2619 Go lib http transport does not handle EOF correctly
Patch: Frank Schroeder
2014-07-25 23:20:54 +02:00
jfarrell
8fd8c6366d THRIFT-2602:Fix missing dist files
Client: build process
Patch: jfarrell

Add all missing files to the dist package.
2014-07-10 09:14:51 -04:00
Jens Geyer
104ecb6589 FIX broken test 2014-06-19 23:25:50 +02:00
Jens Geyer
c0d126fcaf THRIFT-2549 Generate json tag for struct members. use go.tag annotation to override the default generated tag.
Client: Go
Patch: Aleksey Pesternikov

This closes #128
2014-06-19 22:49:54 +02:00
henrique
4f073d8af4 THRIFT-2505 fix apache license header 2014-05-19 21:59:39 +02:00
Jens Geyer
91cfb9901e THRIFT-2500 sending random data crashes thrift(golang) service
Client: Go
Patch: Aleksey Pesternikov

This closes #117

commit 1bb25c4a48845e112847ca8293402f0294d8f597
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-05-02T21:40:59Z

recover from panic in processor

commit 8d1427a2c3c183d499442dc1f0437292e6641ac3
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-05-02T21:41:52Z

some sanity checks in binary protocol

commit 666cc87a51f86ca5940225c36716bbad467c6e73
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-05-02T21:53:59Z

some sanity checks in compact protocol
2014-05-17 01:07:28 +02:00
Jens Geyer
b7cb9457dc THRIFT-2537 Path for "go get" does not work
Client: Go
Patch: Jens Geyer

This closes #115
2014-05-17 00:38:06 +02:00
Jens Geyer
facc8dc6c7 THRIFT-2505 go struct should always be a pointer to avoid copying of potentially size-unbounded structs
Client: Go
Patch: Aleksey Pesternikov

This closes #116

commit 69bbf0e2b148cb1f48e24f46d181cc4d5dc35786
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-05-02T15:45:15Z

struct should always be a pointer to avoid copying of potentially size-unbounded structs
2014-05-09 23:48:57 +02:00
Jens Geyer
f459868f93 THRIFT-2497 server and client for test/go, also several fixes and improvements
Client: Go
Patch: Aleksey Pesternikov

This closes #109

commit f2e7186ca8d63f407dba0c56ee51afd6405926ba
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-22T12:48:14Z

add _ to generated filename if it ends with _test.go

commit a6ed88196fbf4622a3b0261bbac0fe6b258bdd36
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-22T14:19:13Z

use tcxx instead of tr1 in test/cpp

commit d1848fa05f4baefc66eb405f4b1a8657bb2869bd
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-23T01:01:03Z

Merge branch 'master' of https://github.com/apache/thrift into go_integration

commit 04d22fef228d3f868b32a296a38f99ff52ee2142
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-25T00:34:24Z

additions:
 test for client/server with several protocol/transport/ssl combinations
 bin/testclient and bin/testserver
 debug_transport

fixes:
 separate Listen() and AcceptLoop() instead of Serve() in SimpleServer
 if handler function returns any unknown exception, handler closes connection

commit ed88d57d977cffea9fac8f61143801f3097ef46c
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-25T13:29:54Z

Generate lowercase package name
 lowercased pkg name in thrift files
 underline() -> lowercase()

commit 498a910c6c6753a4b1e3633eb5c9c82be33e8c7b
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-25T13:32:26Z

Merge branch 'master' into go_test_service_name

commit 25792d7218a2c32ee3c2077f65ca7d0cea7f31f5
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-22T12:48:14Z

add _ to generated filename if it ends with _test.go

commit af994b415308a2e174d57a03675fc83d7cbd43d1
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-25T00:34:24Z

additions:
 test for client/server with several protocol/transport/ssl combinations
 bin/testclient and bin/testserver
 debug_transport

fixes:
 separate Listen() and AcceptLoop() instead of Serve() in SimpleServer
 if handler function returns any unknown exception, handler closes connection

commit f22a777a5d5b4d93a8d7981e7aadc2c63919518a
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-25T13:44:08Z

Merge branch 'go_integration' of github.com:apesternikov/thrift into go_integration

commit 49a33c8c80ea35f923ee9aa3577780fcf41fe840
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-25T13:49:05Z

Merge branch 'master' into test_cpp_on_mac

commit 81b402ec6301f6b132c9b346ad5481f55f0aff89
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-25T13:56:56Z

operator < for ThriftTest

commit cde312d940d12077274dd0ba677ca850b5b439a7
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-25T14:12:58Z

minor formatting

commit 0a693115c2c20a2a8375f3859ff7bed261e6c8da
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-25T14:13:20Z

Merge branch 'test_cpp_on_mac' into go_integration

commit e06b5d24e8b6d429723a3c77a58c6ce903e1366a
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-25T15:19:20Z

Merge branch 'go_test_service_name' into go_integration

commit 42d577c9812a070060c773fcd0598e58e6d6ba61
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-25T15:39:57Z

imported THRIFT-2491
 lowercase package names

commit 491ccf8b018c046c5ced72b1e19d9ac4ec48a6f5
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-25T15:51:53Z

--noinsane flag for c++ TestClient. works with go server now for other default params

commit 78db3c9a3a5742818a5de6e57f2fe9aed84919e5
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-25T16:03:23Z

license
2014-05-08 23:18:44 +02:00
Jens Geyer
6d1a83aa48 THRIFT-2506 Update TProtocolException error codes to be used consistently throughout the library
Patch: Jens Geyer
2014-05-03 00:49:05 +02:00
Jens Geyer
e52c046cb6 THRIFT-2491 unable to import generated ThriftTest service
Client: Go
Patch: Aleksey Pesternikov

This closes #105

commit f2e7186ca8d63f407dba0c56ee51afd6405926ba
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-22T12:48:14Z

add _ to generated filename if it ends with _test.go
2014-05-02 23:37:39 +02:00
Jens Geyer
0997250744 THRIFT-2502 Optimize go implementations of binary and compact protocols for speed
Client: Go
Patch: Aleksey Pesternikov

This closes #110

commit 7ece8e6f16f7ff46cda4b896215d595ac986d332
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-26T17:45:12Z

simplify buffered transport by reusing bufio

commit 814b661d7e5c3c27ad4035a42925eae619447ee3
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-26T18:05:12Z

zero-initialize buffers in framed transport

commit 0f576138e24fae8e7f8d210cfb480889a41d1d9a
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-26T19:19:39Z

do not buffer the whole frame while reading in framed transport
 reuse frame header buffer

commit 4db9b65458eb34e1b1676dba76d1e664c6339a57
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-26T19:43:07Z

enforce max frame size in framed transport

commit 58ecc23ec1a2176f7dc5db7a658a51817dc626e6
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-27T00:31:16Z

microbenchmarks for serialization/deserialization (binary,compact)x(memoryBuffer,Stream,framedMemoryBuffer)x(bool,byte,i16,i32,i64,double,string,binary)

commit 156116f484db513251e0e6c65942466ed5a8142c
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-27T00:32:09Z

Merge branch 'go_microbench' into go_simplify_and_optimize

commit 1c27c0913cf5a8c0352afff1dae9e9fc9f758409
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-27T22:45:52Z

do not allocate buffer in TBinaryProtocol.WriteByte

commit 86addfb0585e04c648cde1b9cb1566d7976f8cda
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-27T23:46:12Z

no extra alloc in double marshaling test

commit 98ac62b0a80d4f27dce736b561005953cb915a90
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-27T23:46:50Z

Merge branch 'go_microbench' into go_simplify_and_optimize

commit 76c26624578a5455cacd08bb0167444748aaa41d
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-28T12:48:41Z

optimized ReadByte, WriteByte

commit 5a79d81d326582dbbdcf523ebc0180390ac24497
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-28T13:03:26Z

optimized WriteString

commit f6d4a9aa65434831cbd2993148fa12c12b2a342c
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-28T15:35:06Z

compact protocol optimization

commit 03bdb6b9f097a47ef54826483867c23d49374ac0
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-28T16:08:52Z

cache reader and writer to aviod interface conversions
2014-05-02 01:35:24 +02:00
Jens Geyer
731975a645 THRIFT-2451: Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped to go map or slice. generate Get accessors
Client: Go
Patch: Aleksey Pesternikov

This closes #101

commit e6e5dcf3a07cd931183991ff031179b425e2740b
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-16T14:06:52Z

initial change

commit f65730e951a4310160a9f7e3e4eeb7e55abd2c55
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-16T14:16:03Z

no IsSet for required

commit 9865f700eb9354d6053994da989a907766c42d1d
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-17T19:32:13Z

inlined required structs

commit ca52300c07cefcf553f1ebf35569953c933b2367
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-17T19:44:24Z

do not use heap for args struct

commit 012ca3e512d2bc8822de8a715b4f3d3cae5c0c42
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-17T19:52:41Z

do not use heap for result struct

commit 2fc4afc53ff7db43e08eadeaa30e34bc1fd9c889
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-17T21:32:43Z

do not set result field on error

commit 6e5da0062b139f02dcafe3148cdf02f97c23442a
 Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
 Date: 2014-04-17T21:57:57Z

Jens' thrift source as test case

commit 7317957ed708831e280f182f081043fbe9d38a0c
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-17T23:43:08Z

support for cpp.ref

commit 1c4f3efc7b54fd335db633f86faf8c426ae9c87d
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-18T00:13:24Z

package flag

commit c9d7e54f5c5d29c776f42fb861bc9e82da4e542f
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-18T00:21:18Z

Merge branch 'master' into go_inlines
2014-05-02 00:24:24 +02:00
henrique
2bc4b130de THRIFT-2132 Go: Support for Multiplexing Services on any Transport, Protocol and Server
Patch: Aleksey Pesternikov

typo

This closes #112

----
commit f362570683f57ad9ee78cedc437babb697c6a8d1
Author: Aleksey Pesternikov <ap@alekseys-mbp.att.net>
Date:   2014-04-30T12:49:11Z

    THRIFT-2132 broken tests

----
2014-04-30 16:19:35 +02:00
Jens Geyer
751c97c2df THRIFT-2132 Go: Support for Multiplexing Services on any Transport, Protocol and Server
Client: Go
Patch: Aleksey Pesternikov
2014-04-22 23:36:27 +02:00
Jens Geyer
20bcf38be4 Added some more missing ASF headers, fixed go/test makefile structure 2014-04-16 00:27:31 +02:00
Jens Geyer
2335b96039 Added missing ASF header 2014-04-14 22:42:25 +02:00
Jens Geyer
a6c63deb06 THRIFT-2458 Generated golang server code for "oneway" methods is incorrect
Client: Go compiler
Patch: Jens Geyer & Aleksey Pesternikov

This closes #99

commit 5f4833d0dda663e8432c6ed61dae38fa42d52ed9
 Author: Aleksey Pesternikov <ap@alekseys-macbook-pro.local>
 Date: 2014-04-14T12:59:39Z

THRIFT-2458 Generated code for oneway function
2014-04-14 22:42:01 +02:00
Jens Geyer
c2ccca8e4b THRIFT-2458 Generated golang server code for "oneway" methods is incorrect
Client: Go compiler
Patch: Jens Geyer & Aleksey Pesternikov
2014-04-14 22:36:50 +02:00
Jens Geyer
456879288f THRIFT-2445 (code generation for go maps with binary keys) should be tested
Patch: Aleksey Pesternikov
2014-04-07 21:22:01 +02:00
Roger Meier
16fcad0b25 THRIFT-2407 use markdown (rename README => README.md)
Patch: Roger Meier
2014-03-19 06:47:47 +01:00
Jens Geyer
706cb4e4cb THRIFT-2377 Allow addition of custom HTTP Headers to an HTTP Transport
Patch: Sheran Gunasekera
2014-03-19 00:37:10 +02:00
Jens Geyer
c975bbcc9c THRIFT-2388 GoLang - Fix data races in simple_server and server_socket
Patch: Chris Bannister
2014-03-06 21:11:46 +01:00
jfarrell
3fa14a3990 THRIFT-2372:thrift/json_protocol.go:160: function ends without a return statement
Client: go
Patch: jfarrell

Removes else block from function and just returns.
2014-02-21 19:37:13 -05:00
Jens Geyer
54a6636c42 THRIFT-2337 Golang does not report TIMED_OUT exceptions
Patch: Chris Bannister
2014-01-30 20:57:08 +01:00
Jens Geyer
d9c80e2dae THRIFT-2322: serializer testcase helper file regenerated with most recent Thrift compiler
Patch: Jens Geyer
2013-12-21 20:14:45 +01:00
Jens Geyer
bf3a19dc7e THRIFT-2288 Go impl of Thrift JSON protocol wrongly writes/expects true/false for bools
Patch: Jens Geyer
2013-12-17 21:39:30 +01:00
Jens Geyer
0853ab67b4 THRIFT-2232 IsSet* broken in Go
Patch: Ben Sigelman
2013-12-17 21:38:44 +01:00
Jens Geyer
ce8d518166 THRIFT-2280 TJSONProtocol.Flush() does not really flush the transport
Patch: Jens Geyer
2013-12-07 00:11:34 +01:00
Jens Geyer
a596038327 THRIFT-2278 Buffered transport doesn't support writes > buffer size
Patch: Matt Jones
2013-12-03 22:57:59 +01:00
Jens Geyer
7949447efd THRIFT-2279 TSerializer only returns the first 1024 bytes serialized
Patch: Matt Jones
2013-12-03 22:57:05 +01:00
Jens Geyer
f322d917fb THRIFT-2275 Fix memory leak in golang compact_protocol.
Patch: bolin huang
2013-11-28 21:15:17 +01:00
Jens Geyer
9957d3022e THRIFT-2158 Compact, JSON, and SimpleJSON protocols are not working correctly
Patch: Jens Geyer
2013-11-04 22:18:40 +01:00
Jens Geyer
31aebbef19 THRIFT-2251 go test for compact protocol is not running
Patch: Aleksey Pesternikov
2013-11-04 22:17:48 +01:00