Commit Graph

2710 Commits

Author SHA1 Message Date
Jake Farrell
605c760ba6 Thrift-1251: Generated java code should indicate which fields are required and which are optional
Client: java
Patch: Jake Farrell

Fixes optional/required comments on fields.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1198386 13f79535-47bb-0310-9956-ffa450edef68
2011-11-06 15:02:30 +00:00
Roger Meier
6f7681f91d THRIFT-1361 revert compiler/cpp/src/thrifty.yy change
=> breaks mingw build
=> memleak fixes reported by cppcheck

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1198347 13f79535-47bb-0310-9956-ffa450edef68
2011-11-06 12:04:28 +00:00
Roger Meier
38315786e5 THRIFT-1361 Optional replacement of pthread by boost::thread
Patch: Alexandre Parenteau
rev3

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1198339 13f79535-47bb-0310-9956-ffa450edef68
2011-11-06 11:29:41 +00:00
Roger Meier
1b6153bdd1 THRIFT-1277 Node.js serializes false booleans as null
revert patch => breaks js

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1198334 13f79535-47bb-0310-9956-ffa450edef68
2011-11-06 10:37:11 +00:00
Jake Farrell
28459dc9c5 Thrift-1415: delphi: add version Info to the library
Client: delphi
Patch: Jens Geyer 

Adding versioning to delphi library



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1197957 13f79535-47bb-0310-9956-ffa450edef68
2011-11-05 13:36:27 +00:00
Jake Farrell
48bb0e2ad4 Thrift-1277: Node.js serializes false booleans as null
Client: js
Patch: Hans Duedal 

When serializing boolean types, false booleans are serialized as null instead of false switching to  using loose compare instead



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1197955 13f79535-47bb-0310-9956-ffa450edef68
2011-11-05 13:16:34 +00:00
Roger Meier
17b8469d16 THRIFT-1335: Add accept timeout to TServerSocket
Client: cpp
Patch: Dave Watson

FIX: add accTimout_ Initialization to DomainSocket Constructor

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1197523 13f79535-47bb-0310-9956-ffa450edef68
2011-11-04 11:55:49 +00:00
Bryan Duxbury
df971daf37 THRIFT-1420. java: Nonblocking and HsHa server should make sure to close all their socket connections when the selector exits
This patch makes the selector threads close out all of their open sockets before completely exiting. In testing, this appears to alleviate issues with hanging clients.

Patch: Thomas Kielbus

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1197370 13f79535-47bb-0310-9956-ffa450edef68
2011-11-04 00:23:30 +00:00
Bryan Duxbury
e7bdf70dab THRIFT-1419. java: AbstractNonBlockingServer does not catch errors when invoking the processor
This patch changes the invoke() method to catch Throwables instead of just Exceptions.

Patch: Thomas Kielbus"


git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1196848 13f79535-47bb-0310-9956-ffa450edef68
2011-11-02 22:40:01 +00:00
Roger Meier
61188a4797 THRIFT-1416 Python Unit test is broken on ci
remove repr from TestSuite

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1196273 13f79535-47bb-0310-9956-ffa450edef68
2011-11-01 21:03:33 +00:00
Jake Farrell
aad3d1d63e Thrift-1409: Name conflict check does not work properly for exception object(Delphi).
Client: delphi
Patch: Kenjiro Fukumitsu

Delphi compiler's naming check does not work properly with exception object in the function that generates struct writer.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1195747 13f79535-47bb-0310-9956-ffa450edef68
2011-11-01 01:08:46 +00:00
Jake Farrell
601bb5e87f THRIFT-1413: Generated code does not read MapEnd / ListEnd / SetEnd
Client: delphi
Patch: Jens Geyer

The generated code lacks calls to ReadMapEnd, ReadListEnd and ReadSetEnd. Although actually no problem occurs with the BinaryProtocol, other protocols (like JSON) do some important things there.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1195466 13f79535-47bb-0310-9956-ffa450edef68
2011-10-31 14:13:13 +00:00
Jake Farrell
73a921f85c Thrift-1408: Delphi Test Server: Exception test case fails due to naming conflict with e.message
Client: delphi
Patch: jens Geyer

Fix name comflict with e.message 



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1195461 13f79535-47bb-0310-9956-ffa450edef68
2011-10-31 14:07:14 +00:00
Jake Farrell
1290d42162 THRIFT-1407: Typo in Python socket server causes Thrift to fail when we enable a global socket timout
Client: py
Patch: adalc

Fixes typo in python socket server timeout



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1189170 13f79535-47bb-0310-9956-ffa450edef68
2011-10-26 12:36:17 +00:00
Jake Farrell
f55f33bfba THRIFT-1405: Delphi compiler does not generates container serializer properly
Client: delphi
Patch: Kenjiro Fukumitsu

Fixess a bug in the function that generates serializer of containers



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1189009 13f79535-47bb-0310-9956-ffa450edef68
2011-10-26 02:40:14 +00:00
Jake Farrell
806d298042 THRIFT-1399: One of the TServerImpl.Create CTORs lacks implementation
Client: delphi
Patch: Jens Geyer

Adding delphi test server missing constructor. 



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1189007 13f79535-47bb-0310-9956-ffa450edef68
2011-10-26 02:33:31 +00:00
Jake Farrell
d2b3bb4e23 THRIFT-1406: Build error after applying THRIFT-1395
Client: delphi
Patch: Jens Geyer

Fixes build failure due to t_delphi_generator.cc:780: error: integer constant is too 
large for 'long' type



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1189006 13f79535-47bb-0310-9956-ffa450edef68
2011-10-26 02:29:48 +00:00
Jake Farrell
d09362c5c7 THRIFT-1404: Delphi compiler generates struct reader code with problem.
Client: delphi
Patch: Kenjiro Fukumitsu

After recieved STOP,it calls additional ReadFieldEnd, which is different from the implementation of other language compiler.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1189005 13f79535-47bb-0310-9956-ffa450edef68
2011-10-26 02:25:07 +00:00
Jake Farrell
0c0f651e10 Thrift-1395: Patch to prevent warnings for integer types in some cases
Client: delpi
Patch: Jens Geyer

Constants such as i32 = 0x80000000 produce a Delphi warning. The current code renders such values as positive integer, which needs an explicit typecast to satisfy the Delphi compiler.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1188494 13f79535-47bb-0310-9956-ffa450edef68
2011-10-25 02:20:26 +00:00
Bryan Duxbury
bcbf6d6fcd THRIFT-1400. rb: Ruby native extension aborts with __stack_chk_fail in OSX
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1188248 13f79535-47bb-0310-9956-ffa450edef68
2011-10-24 17:29:16 +00:00
Jake Farrell
8514755daf THRIFT-1397: CI server fails during build due to unused parameters in delphi generator
Client: delphi
Patch: Kenjiro Fukumitsu 

Cleans up unused parameters in delphi generator.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1186794 13f79535-47bb-0310-9956-ffa450edef68
2011-10-20 13:30:08 +00:00
Jake Farrell
3b54621793 Thrift-1396: Dephi generator has dependacy on boost 1.42 later.
Client: delphi
Patch: Kenjiro Fukumitsu 

Patch to fully remove boost uuid within the delphi generator.  



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1186603 13f79535-47bb-0310-9956-ffa450edef68
2011-10-20 02:49:48 +00:00
Jake Farrell
c92b65311c Thrift-1390L Debian package build fix for squeeze
Client: build
Patch: Jake Farrell

Fix debian build deps for libmomo-system-web2.0-cil.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1186602 13f79535-47bb-0310-9956-ffa450edef68
2011-10-20 02:11:02 +00:00
Roger Meier
266a6b5c11 THRIFT-1361 Optional replacement of pthread by boost::thread
revert boost changes

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1186049 13f79535-47bb-0310-9956-ffa450edef68
2011-10-19 09:27:01 +00:00
Roger Meier
0dab3832c7 THRIFT-1361 Optional replacement of pthread by boost::thread
Patch: Alexandre Parenteau

Remark: lib/cpp/src/concurrency/BoostMutex.cpp is unmodified

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1185904 13f79535-47bb-0310-9956-ffa450edef68
2011-10-18 22:19:30 +00:00
Jake Farrell
711c70c786 Thrift-1393: TTransportException's thrown from THttpClient contain superfluous slashes in the Exception message
Client : php
Patch: Nick Jones

The THttpClient class ensures the $uri_ property has a slash prefixed by appending one if needed in the constructor. However in THttpClient::read, there are 2 exceptions thrown where a slash is concatenated between the port and uri. This results in a superfluous slash in the TTransportException message.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1185723 13f79535-47bb-0310-9956-ffa450edef68
2011-10-18 15:31:17 +00:00
Jake Farrell
7ae13e10f7 Thrift-1366: Delphi generator, lirbrary and unit test.
Client: delphi
Patch: Kenjiro Fukumitsu

Adding delphi XE generator, lib and unit tests.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1185688 13f79535-47bb-0310-9956-ffa450edef68
2011-10-18 14:35:26 +00:00
Roger Meier
857a8b8bf8 THRIFT-1261 STDIO support for node-thrift
Patch: Jordan Shaw

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1183221 13f79535-47bb-0310-9956-ffa450edef68
2011-10-14 06:35:28 +00:00
Bryan Duxbury
6c928f3f5f THRIFT-1130. compiler: Add the ability to specify symbolic default value for optional boolean
Patch: Nevo Hed

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1183115 13f79535-47bb-0310-9956-ffa450edef68
2011-10-13 21:32:52 +00:00
Roger Meier
bf12239d2e THRIFT-1381 Thrift C++ libs have incorrectly versioned names
Patch: Jake Farrell

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1182052 13f79535-47bb-0310-9956-ffa450edef68
2011-10-11 19:48:57 +00:00
Roger Meier
878a948894 THRIFT-1387 Build MSVC libraries with Boost Threads instead of Pthreads
Patch: Peace C & Alexandre Parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1182024 13f79535-47bb-0310-9956-ffa450edef68
2011-10-11 19:02:37 +00:00
Jake Farrell
fae04ead81 THRIFT-1384: Java help meny missing newline near javame flag
Client: build
patch: Jake Farrell

Adds newline to java stanza in thrift --help menu



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1180276 13f79535-47bb-0310-9956-ffa450edef68
2011-10-07 23:15:03 +00:00
Jake Farrell
2361dd1711 Thrift-1373: Fix user-defined exception generation in thrift (python)
Client: py
Patch: Dave Watson

forgotten include of TException in py imports section



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1180119 13f79535-47bb-0310-9956-ffa450edef68
2011-10-07 17:41:48 +00:00
Jake Farrell
581481f232 Thrift-1379: fix uninitialized enum values in thrift C++ objects
Client: cpp
Patch: Dave Watson

The thrift-generated code for C++ class objects does not provide any
initialization for enum values, so they wind up containing random/uninitialized
data. This causes problems when clients do not send argument data, as the server
receives random data rather than zero for unpassed args.
Enums should be initialized to zero.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179909 13f79535-47bb-0310-9956-ffa450edef68
2011-10-07 00:25:46 +00:00
Jake Farrell
51700649d0 Thrift-1377: abort PHP deserialization on unknown field type
client: php
Patch: Dave Watson

Previously the code incorrectly ignored unknown field types. After
reading the field header, if it was an unknown type it would incorrectly
assume there was no data, and start trying to read the next field
immediately. 



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179907 13f79535-47bb-0310-9956-ffa450edef68
2011-10-07 00:17:25 +00:00
Jake Farrell
b5d94e07c4 Thrift-1376: Make port specification option in thrift remote
Client: py
Patch: Dave Watson

The thrift-generated Python service client allows overriding the default host/port by doing "-h host:port" on the command line. Oftentimes, you want to override the host but not the port, as most services run on well-defined ports.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179905 13f79535-47bb-0310-9956-ffa450edef68
2011-10-07 00:14:34 +00:00
Jake Farrell
336a1599d7 Thrift-1375: fixed a hex char conversion bug in TJSONProtocol
Client: java
Patch: Dave Watson

Fixed a hex char conversion bug in TJSONProtocol: 10 ~ 15 <=> 'a' ~ 'f'.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179904 13f79535-47bb-0310-9956-ffa450edef68
2011-10-07 00:10:20 +00:00
Jake Farrell
2ce7f66dea Thrift-1373: Fix user-defined exception generation in thrift (python)
Client: py
Patch: Dave Watson

Fixed python code generation so that user-defined exceptions have a
base class of TException rather than Exception.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1179903 13f79535-47bb-0310-9956-ffa450edef68
2011-10-07 00:04:56 +00:00
Jake Farrell
7301eced16 THRIFT-1370: Debian packaging should Build-Depend on libglib2.0-dev
Client: build
Patch: Christian Hofstaedtler

The Debian packaging builds the c_glib interface library, but does not name libglib2.0-dev as a Build-Dependency. While this usually won't affect manual builds, this is a problem for automated build environments which will not have libglib2.0-dev installed unless explicitly requested by Build-Depends.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1178823 13f79535-47bb-0310-9956-ffa450edef68
2011-10-04 14:59:40 +00:00
Roger Meier
20e6ef136e THRIFT-1361 Optional replacement of pthread by boost::thread (minor fix)
FIX: member initialization order within constructor

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1178532 13f79535-47bb-0310-9956-ffa450edef68
2011-10-03 19:37:09 +00:00
Roger Meier
3faaedf46b THRIFT-1361 Optional replacement of pthread by boost::thread
Patch: alexandre parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1178176 13f79535-47bb-0310-9956-ffa450edef68
2011-10-02 10:51:45 +00:00
Roger Meier
3516e0e306 THRIFT-1031 Patch to compile Thrift for vc++ 9.0 and 10.0
Patch: Peace

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1177817 13f79535-47bb-0310-9956-ffa450edef68
2011-09-30 20:23:34 +00:00
Bryan Duxbury
9a1d2f01c6 add utility for benchmarking protocols against each other
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1177458 13f79535-47bb-0310-9956-ffa450edef68
2011-09-29 22:51:54 +00:00
Bryan Duxbury
44b2bb6bb5 revert THRIFT-959
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1176472 13f79535-47bb-0310-9956-ffa450edef68
2011-09-27 17:07:19 +00:00
Bryan Duxbury
40d51a28d7 THRIFT-1365. java: TupleProtocol#writeBitSet unintentionally writes a variable length byte array
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1176072 13f79535-47bb-0310-9956-ffa450edef68
2011-09-26 21:29:15 +00:00
Bryan Duxbury
f35741729f inconsequential indentation fix to java compiler
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1176034 13f79535-47bb-0310-9956-ffa450edef68
2011-09-26 20:32:59 +00:00
Jake Farrell
7dcd49f1f9 THRIFT-1357: Erlang dependency breaks build
Client: erl
Patch: Peter Neumark

Updates json protocol to work with JSX 0.9.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1175906 13f79535-47bb-0310-9956-ffa450edef68
2011-09-26 15:29:03 +00:00
Roger Meier
db3c9249c8 THRIFT-1359 --gen-cob cpp:cob_style does not compile anymore
Patch: Alexandre Parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1175308 13f79535-47bb-0310-9956-ffa450edef68
2011-09-25 07:16:17 +00:00
Jake Farrell
5209237739 Thrift-1355: Running make in lib/rb doesn't build the native extensions
Client: rb
Patch: jfarrell

Builds extension prior to running spec calls to resolve test deps.




git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1174896 13f79535-47bb-0310-9956-ffa450edef68
2011-09-23 17:24:00 +00:00
Roger Meier
8cd3b1aa3c THRIFT-1031 Patch to compile Thrift for vc++ 9.0 and 10.0
=> some more improvements

Patch: James Dickson

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1174801 13f79535-47bb-0310-9956-ffa450edef68
2011-09-23 14:25:22 +00:00