Commit Graph

97 Commits

Author SHA1 Message Date
Henrique Mendonça
1568aef7d4 THRIFT-3122 Javascript struct constructor should properly initialize struct and container members from plain js arguments
Client: Node and JS
Patch: Igor Tkach

    This closes #476
2015-05-27 22:15:46 +10:00
Nobuaki Sukegawa
113b638790 THRIFT-3148 Markdown links to coding_standards are dead
This closes #491
2015-05-13 21:40:26 +02:00
Simon Hürlimann (CyT)
b818185cf8 nodejs: Add main header to example README. 2015-04-07 22:59:12 +02:00
Simon Hürlimann (CyT)
d732321bed nodejs: Fix Markdown syntax for README. 2015-04-07 22:59:12 +02:00
Randy Abernethy
cada37008c THRIFT-3048: Repair node i64 compact interface
Client: Node lib
Patch: Will Demaine

Github Pull Request:

This closes #403
commit 11d0a661985cabe63c1dc1b47576bb2b2d6c2e54
Author: Willyham <willyd@uber.com>
Date: 2015-03-20T22:28:01Z
Make TCompactProtocol always return an object for i64
2015-03-26 16:03:08 -07:00
Roger Meier
41ad4342c5 THRIFT-847 Test Framework harmonization across all languages
THRIFT-2946 Enhance usability of cross test framework

Patch: Nobuaki Sukegawa

This closes: #358
2015-03-24 22:30:40 +01:00
Roger Meier
47accfc802 nodejs: fix typo 2015-03-24 21:01:46 +01:00
Randy Abernethy
bd60b92c6f THRIFT-3008: Node.js server does not fully support exceptions
Client: Node.js
Patch: Nobuaki Sukegawa

Github Pull Request:
This closes #382
commit 0c0d51ca1dafa5f8e0004563df780a92580590f3
Author: Nobuaki Sukegawa <nsukeg@gmail.com>
Date: 2015-02-22T16:49:22Z
THRIFT-3008 - Node.js server does not fully support exception
2015-02-26 16:59:14 -08:00
Randy Abernethy
d8187c5ff1 THRIFT-2976: add browserify support and tests
Client: nodejs
Patch: Andrew de Andrade
2015-02-16 01:25:53 -08:00
Randy Abernethy
3b9ff4de6e THRIFT-2969
Client: nodejs
Patch: Andrew de Andrade

General node test cleanup and consolidation.
2015-02-16 00:51:24 -08:00
Randy Abernethy
96f4f07beb THRIFT-2964: nodejs file breakout
Client: NodeJS
Patch: Andrew de Andrade

Moves protocols and transports (among others) into seperate files.
2015-02-10 02:29:15 -08:00
Konrad Grochowski
3bc6424c76 THRIFT-2724 - Coding standards template added all over project
Client: All
Patch: Konrad Grochowski

This closes #371
2015-02-05 12:15:19 +01:00
Randy Abernethy
a7270074d3 THRIFT-2932: Node.js Thrift connection libraries throw Exceptions into event emitter
Client: Nodejs
Patch: Tom Croucher and Andrew de Andrade

This commits a limited set of hunks from teh original patch.
2015-02-04 13:18:53 -08:00
Roger Meier
281bdae6b2 THRIFT-2940 nodejs: move package.json to root folder
fix make dist & co
2015-02-03 23:45:21 +01:00
Randy Abernethy
8e73137c27 THRIFT-2963: add code coverage to nodejs lib
Client: Node
Patch: Tom Croucher and Andrew de Andrade
2015-02-03 00:04:40 -08:00
Roger Meier
1abd746b9c THRIFT-2940 nodejs: move package.json to root folder 2015-02-02 21:59:38 +01:00
Randy Abernethy
97c4398c38 THRIFT-2963: repairs bad error refs and exceptions
Client: Nodejs
Patch: Tom Croucher

Repairs various error code blocks in nodejs TCompactProtocol
2015-02-02 06:51:25 -08:00
Randy Abernethy
cf743d7ac7 THRIFT-2959: reenable binary.test.js in testAll.sh
Client: Nodejs
Patch: Andrew de Andrade
2015-02-02 05:56:14 -08:00
Randy Abernethy
1097c40ed0 THRIFT-2934: make node server options optional
Client: Nodejs
Patch: Randy Abernethy
2015-02-02 05:18:59 -08:00
Randy Abernethy
4e1e132142 THRIFT-2933: Repairs incorrect double byte order in Node compact proto
Client Nodejs
Patch: Dan Heller
2015-02-02 04:43:23 -08:00
Konrad Grochowski
f9c4be80a5 line endings fix
git merge on linux can fail due to wrong line endings...
2015-01-09 11:32:26 +01:00
Jens Geyer
8bcfdd98ae THRIFT-2886 Integrate binary type in standard Thrift cross test
Client: C_glib, C++, D, Erlang, Go, Haskell, Lua, Java/Me, JavaScript, Node, Ocaml, Perl, PHP, Python, Ruby
Patch: Jens Geyer

This closes #341

Minimal server-side implementations and TODO stubs for various languages to let "make check" succeeed.
Not contained in this patch and still TODO:
- client side implementations, i.e. calls to testBinary() and appropriate tests
- server side hex printout missing for some languages
2015-01-03 17:37:54 +01:00
Jens Geyer
78c57e1720 THRIFT-2871 Missing semicolon in thrift.js
Client: NodeJS
Patch: Chi Vinh Le <cvl@chinet.info>

This closes #300

JSHint complains about missing semicolon. Might break older browser compatibility.
2014-12-02 21:22:04 +01:00
Randy Abernethy
878483759c THRIFT-2844:Add Browserify support to node
Client: Node
Patch Cameron Ring

Adds Node support for ArrayBuffer when run in Browser
under Browserify.
2014-12-02 05:42:00 -08:00
Konrad Grochowski
28d9315de8 THRIFT-2849: nodejs - some typos fixed
Client: Node.JS
Patch: Konrad Grochowski

codespell was trying to make wrong fix, so this had to be applied
manually
2014-11-24 11:36:20 +01:00
Konrad Grochowski
3b5dacba44 THRIFT-2849: spelling errors fixed using codespell tool
Client: All
Patch: Anatol Pomozov

This closes #281
2014-11-24 10:55:31 +01:00
Randy Abernethy
9c0316bbf3 THRIFT-2831:Eliminates dead code in node web server
Clinet: Node
Patch: Chi Vinh Le

Github Pull Request: This closes #270
2014-11-18 12:11:31 -08:00
Randy Abernethy
2e091f681b THRIFT-2819
Client Node
Patch: Chi Vinh Le

Adds websocket client to Node with tests
2014-11-15 23:05:22 -08:00
Jens Geyer
565ea0c497 THRIFT-2818 Trailing commas in array
Client: Node.js
Patch: Chi Vinh Le

This closes #263
2014-11-14 21:29:19 +01:00
Randy Abernethy
1107b17ae4 THRIFT-2783:Prop bin encoding in node
Client: Node Lib
Patch: John Campbell

Fixes node web socket lib bin encoding propagation.
2014-10-11 13:42:31 -07:00
jfarrell
dabdf659ef THRIFT-2778 - nodejs build cleanup
Client: nodejs
Patch: jfarrell

nodejs test file cleanup
2014-10-08 23:41:47 -04:00
Roger Meier
25023b16eb THRIFT-809 Javascript client: Please make required fields actually required.
Patch: noazark

Github Pull Request: This closes #232
2014-10-09 02:01:17 +02:00
Jens Geyer
79f988c27a THRIFT-2768: Whitespace Fixup
Client: General (Makefile.am)
Patch: Jens Geyer

Reverted makefile.am - tabs are not optional there
2014-10-03 20:42:54 +02:00
Jens Geyer
aaa8947f3a THRIFT-2768: Whitespace Fixup
Client: General (Makefile.am, *.thrift)
Patch: Jens Geyer

DocTest.thrift has NOT been changed, the trailing whitespaces are part of the test case.
2014-10-03 20:30:38 +02:00
Randy Abernethy
bd2fce6fa3 THRIFT-2751: repair node oneway bug and symlink issue
Client: Node Lib
Patch: Randy Abernethy

This patch keep npm from creating sym links on npm install.
Sym links fail when writting to some shared volumes.

Also fixes multiplex oneway bug in nodejs
2014-09-30 17:12:27 -07:00
Jens Geyer
a86886e77d THRIFT-2704 - compiler: T_ONEWAY type used for oneway methods instead of T_CALL
Patch: Konrad Grochowski

This closes #216
2014-09-17 22:36:00 +02:00
jfarrell
8fd8c6366d THRIFT-2602:Fix missing dist files
Client: build process
Patch: jfarrell

Add all missing files to the dist package.
2014-07-10 09:14:51 -04:00
Wade Simmons
0dd35a6c4b fix global leaks and copy-paste errors
- TCompactProtocol.prototype.writeBool not referencing `booleanField_`
  on `this` correctly. Also using `NULL` instead of `null`.

- TCompactProtocol.prototype.writeVarint64 had a typo for TProtocolException

- TCompactProtocol.prototype.readMapBegin had a typo between `kvtype` and
 `kvType`

- createMultiplexServer leaked a global var `processStatus`

- TFramedTransport had a line that was accidently copy pasted, leading
  to a global leak of `frameLeft`. (I created the patch the introduced
  this copy paste error in Thrift-1353, so I can confirm it was
  a mistake).

- createWebServer tried to check a non-existent var `route` and leaked
  a global `result`

Signed-off-by: Roger Meier <roger@apache.org>
2014-07-04 21:28:44 +02:00
Wade Simmons
35c8b97fbf fix TFramedTransport residual continuation
There were many bugs in the current TFramedTransport.receiver caused by
merge mistakes and bad patches. Simplify the logic so it is easier to
reason about and prevent future issues.

- THRIFT-2194 Fixed one bug with residual not being set
- THRIFT-2205 Reverted the above fix (by accident) and broke it further
  by including InputBufferUnderrunError in TFramedTransport (which is
  incorrect)

This patch cleans up TFramedTransport.receiver by only have one hold
over buffer instead of two (frame + residual).
2014-06-29 22:53:23 +02:00
Roger Meier
32f3982275 THRIFT-2578 Moving 'make cross' from test.sh to test.py
Patch: Chamila Dilshan Wijayarathna
2014-06-18 22:43:17 +02:00
Roger Meier
f8c1c989f2 THRIFT-847 Test Framework harmonization across all languages
Added
--port arg (=9090) Port number to listen
to nodejs server at lib/nodejs/test/server.js and added
--host arg (=localhost) Host to connect
--port arg (=9090) Port number to connect
to nodejs client at lib/nodejs/test/client.js

Patch: Chamila Dilshan Wijayarathna
2014-05-28 00:04:32 +02:00
ra
20aeba3e38 THRIFT-2511 Node.js compact protocol
Client: Node
Patch: Randy Abernethy

Adds Compact Protocol to Node.js, tests in testAll.sh and repairs all
library JSHint warnings.
2014-05-11 00:25:01 -07:00
Jens Geyer
6d1a83aa48 THRIFT-2506 Update TProtocolException error codes to be used consistently throughout the library
Patch: Jens Geyer
2014-05-03 00:49:05 +02:00
ra
779b9ac2ef THRIFT-2493:Node.js lib needs HTTP client
Client: node
Patch: Randy Abernethy

Clean up of many jshint warnings/errors, jsdoc for HttpConnect,
added support for https and Python to HttpConnect, added tests
for HttpConnect with https and promises.
2014-04-23 20:04:23 -07:00
ra
8f697cb649 THRIFT-2493:Node.js lib needs HTTP client
Client: node
Patch: Randy Abernethy

Adds http client to node.js along with tests.
2014-04-23 02:23:18 -07:00
ra
7201c0d38f THRIFT-2405:Node.js Multiplexer tests fail (silently)
Client: node
Patch: Randy Abernethy

Repairs client side multiplex protocol.
2014-04-22 06:37:37 -07:00
Roger Meier
a6415bc985 THRIFT-2325: SSL test certificates
CN for servername was ssltest instead of localhost
+ little update of README.md

Patch: Roger Meier
2014-04-07 23:45:19 +02:00
ra
1be80dce36 THRIFT-2446: cause servers to emit stream errors
Client: node
Patch: alexey

Mods Thrift Node Servers to emit stream errors

This closes #94
----
commit 296f296db1d415b1d2a7bd8168f48cec5766a210
Author: gruzovator <gruzovator@gmail.com>
Date: 2014-04-03T15:16:07Z
nodejs server stream error handling
2014-04-03 09:02:30 -07:00
ra
7f76e1d9f4 THRIFT-2443: node fails cross lang tests
Client: node
Patch: Randy Abernethy

adds support for recursive tests of i64 types and fixes cross
lang test failure with C++.
2014-04-02 12:31:05 -07:00
ra
a2e4e56598 THRIFT-2398:Improve Node Server Library
CLIENT: node
Patch: Randy Abernethy

Update node hello web example and line ending clean up.
2014-03-29 01:14:48 -07:00