Commit Graph

870 Commits

Author SHA1 Message Date
Christopher Piro
ea7b21d175 fix TApplicationException not imported in Python gencode
used unconditionally in the generated code. "from thrift.Thrift import *" included it before r1169492 but not since.

Reviewed By: dreiss

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1335325 13f79535-47bb-0310-9956-ffa450edef68
2012-05-08 01:45:21 +00:00
Roger Meier
7abda07738 THRIFT-681 The HTML generator does not handle JavaDoc style comments very well
add missing file t_html_generator.h

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1333398 13f79535-47bb-0310-9956-ffa450edef68
2012-05-03 10:23:15 +00:00
Bryan Duxbury
b2f3bcdd08 THRIFT-681. The HTML generator does not handle JavaDoc style comments very well
Patch: Kevin Burnett

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1333222 13f79535-47bb-0310-9956-ffa450edef68
2012-05-02 21:39:01 +00:00
Roger Meier
95b1bd71e3 THRIFT-1588 Java Generated Exceptions don't follow inheritance pattern as other Languages
- reduce NUM_QUERIES within test for slow machines ;-r

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1332809 13f79535-47bb-0310-9956-ffa450edef68
2012-05-01 20:43:26 +00:00
Roger Meier
c75797d906 THRIFT-1583 c_glib leaks memory
THRIFT-1578 C_GLib generated code does not compile
THRIFT-1582 Bad includes of nested thrift files in c_glib

Patch: José Antonio Santos
Minor Modificatons by roger:
- thrift prefix for includes
- g_object_unref instead of g_clear_object (needs glib>=2.28)

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1331752 13f79535-47bb-0310-9956-ffa450edef68
2012-04-28 11:33:58 +00:00
Roger Meier
b661e83fab THRIFT-1277 Node.js serializes false booleans as null
Patch: Henrique Mendonca

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1326371 13f79535-47bb-0310-9956-ffa450edef68
2012-04-15 15:58:43 +00:00
Roger Meier
1516be04e0 Merge branch 'trunk' of https://github.com/benoitdion/thrift into trunk
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1326086 13f79535-47bb-0310-9956-ffa450edef68
2012-04-14 11:03:21 +00:00
Roger Meier
5346e7200a THRIFT-1570 Correctly generate code for empty services.
Patch: Dave Watson

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1325786 13f79535-47bb-0310-9956-ffa450edef68
2012-04-13 14:38:19 +00:00
Roger Meier
629d5a9bcf THRIFT-1565 Thrift/cpp: Use default constructor for strings
Patch: Dave Watson

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1325785 13f79535-47bb-0310-9956-ffa450edef68
2012-04-13 14:33:56 +00:00
Roger Meier
49ff8b123a THRIFT-1552 Include paths for c/c++ should be prefixed with 'thrift/'
To ensure there are no include path collisions the C and C++ header
include paths should include 'thrift' as the root leaf. This will
prevent having to place /usr/include/thrift into the compilers include
header search path, which might otherwise result in the compiler
accidentally picking up headers that it shouldn't.

e.g. #include <foo/bar.h> should be #include <thrift/foo/bar.h>

Change-Id: I48f2b0f549bda0fc81e85506ac857adc800b98a1

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1325674 13f79535-47bb-0310-9956-ffa450edef68
2012-04-13 09:12:31 +00:00
Roger Meier
49ef6587b4 THRIFT-1079 Support i64 in AS3
Patch: Ethan Urie

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1325048 13f79535-47bb-0310-9956-ffa450edef68
2012-04-11 22:28:26 +00:00
Roger Meier
380e919a13 THRIFT-1554 Inherited service methods are not resolved in derived service implementations
Patch: Jens Geyer

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1311311 13f79535-47bb-0310-9956-ffa450edef68
2012-04-09 16:25:47 +00:00
Roger Meier
c64d6f0992 THRIFT-1398 Compiler warning on generated code (Multiface kills -Wall -Werror on gcc 4.6.1)
Patch: Nevo Hed

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1311066 13f79535-47bb-0310-9956-ffa450edef68
2012-04-08 18:18:56 +00:00
Roger Meier
5c80802332 THRIFT-1553 thrift nodejs service side can't read map structure, key as enum, value as Object
Patch: Henrique Mendonca

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1310986 13f79535-47bb-0310-9956-ffa450edef68
2012-04-08 12:30:00 +00:00
Jake Farrell
b95b0ffa72 THRIFT-1500: d programming language support
Client: D
Patch: David Nadlinger

D program language library and additions



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1304085 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 21:49:10 +00:00
Anthony F. Molinaro
3bba214c13 THRIFT-1532 - slightly better fix, take into account requiredness when adding default values
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1303666 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 06:48:33 +00:00
Anthony F. Molinaro
31835148b2 THRIFT-1532/THRIFT-1475 - fix record generation for erlang
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1303663 13f79535-47bb-0310-9956-ffa450edef68
2012-03-22 06:23:36 +00:00
Jake Farrell
17515db934 THRIFT-1534:Required fields in the Delphi code generator.
Client:delphi
Patch:Jens Geyer

Required field changes to isset and generated Read-methods.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1298265 13f79535-47bb-0310-9956-ffa450edef68
2012-03-08 04:05:58 +00:00
Bryan Duxbury
68839504c2 THRIFT-1527. java: Generated implementation of tupleReadStruct in unions return null when the setfield is unrecognized
Unrecognized fields will now result in a TProtocolException when reading with the TupleProtocol.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1295997 13f79535-47bb-0310-9956-ffa450edef68
2012-03-01 23:43:54 +00:00
Ilya Maykov
9be7b38860 THRIFT-481: indentation of ruby classes is off by a few
Compiler: Ruby
Patch: Ilya Maykov

Fixed indentation of gen-rb files by wrapping each file
output stream in a class that keeps track of the indent
level instead of using the global indent.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1295423 13f79535-47bb-0310-9956-ffa450edef68
2012-03-01 05:56:39 +00:00
Ilya Maykov
c00011a752 THRIFT-1204: Ruby autogenerated files should require 'thrift' gem
Library: Ruby
Patch: Ilya Maykov
This patch does 2 things:
1) Adds a "require 'thrift'" line to the *_types.rb and *_constants.rb files,
   to be consistent with *_service.rb which was generating the thrift require
   already.
2) Adds a "rubygems" option to the --gen rb compiler target. When this option
   is specified, the compiler will add a "require 'rubygems'" line to the top
   of each gen-rb file. Defaults to false.


git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1294949 13f79535-47bb-0310-9956-ffa450edef68
2012-02-29 02:40:28 +00:00
Bryan Duxbury
b2507dbb0c THRIFT-1518. cpp: Generated C++ code only sends the first optional field in the write() function for a struct
There was some incorrect else if logic added to the CPP generated code, which this patch replaces with the proper functionality.

Patch: Thomas Wiggins

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1292508 13f79535-47bb-0310-9956-ffa450edef68
2012-02-22 21:14:10 +00:00
Bryan Duxbury
b405ca6be8 THRIFT-1447. java: NullpointerException in ProcessFunction.class :in 'oneway' method
Patch: Ihor Mysak

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1244272 13f79535-47bb-0310-9956-ffa450edef68
2012-02-14 23:35:22 +00:00
Jake Farrell
afb9f970a4 Thrift-556:Ruby compiler does not correctly referred to top-level modules when a submodule masks the top-level name
Client: rb
Patch: Ben Kelly

Prepends a :: to every  place that references the top-level module.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1242376 13f79535-47bb-0310-9956-ffa450edef68
2012-02-09 16:17:50 +00:00
Jake Farrell
f9f01fa1e0 THRIFT-1394:Treatment of optional fields is not consistent between C++ and Java
Client: cpp
Patch: Diwaker Gupta

In CPP, all optional fields are guarded by the isset helper struct. On Java, however, the generated code takes advantage of nullable types: for containers, structs, exceptions, enums, and, notably, strings, the generator elides explicit use of an "isset" bit vector and instead emits checks of the form "field null". This leads to varying behavior between the two languages: an optional string field with a default value will have {{isset[fieldid]}} false on C, but the equivalent test in Java will be true.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1236529 13f79535-47bb-0310-9956-ffa450edef68
2012-01-27 04:48:26 +00:00
Jake Farrell
b2c4952799 Thrift-1465:Visibility of methods in generated java code
Client: java
Patch: Ashutosh Chauhan

Changes visibility of processor getProcessMap() and getEmptyArgs() methods


git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1236515 13f79535-47bb-0310-9956-ffa450edef68
2012-01-27 04:01:54 +00:00
Jake Farrell
ba02146682 THRIFT-1504: Cocoa Generator should use local file imports for base Thrift headers
Client: cocoa
Patch: Steve White

Updates thrift headers as global imports instead of local imports



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1236503 13f79535-47bb-0310-9956-ffa450edef68
2012-01-27 03:06:54 +00:00
Roger Meier
0838bf56f5 THRIFT-1489 Add support for WCF bindings (optionally) to C# compiler, allowing web service usage of Thrift generated code
Patch: Kieran Benton
fix: add missing area of XML documentation generation

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1234095 13f79535-47bb-0310-9956-ffa450edef68
2012-01-20 19:42:23 +00:00
Roger Meier
bc2be31e48 THRIFT-1496 PHP compiler not namespacing enums
Patch: Andrew Grumet

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1233930 13f79535-47bb-0310-9956-ffa450edef68
2012-01-20 14:34:49 +00:00
Roger Meier
26cbb388ec THRIFT-1410 C# Partial Classes (for service implementation class)
Patch: Kieran Benton

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1232585 13f79535-47bb-0310-9956-ffa450edef68
2012-01-17 21:32:50 +00:00
Roger Meier
f0e517db99 THRIFT-1489 Add support for WCF bindings (optionally) to C# compiler, allowing web service usage of Thrift generated code
Patch: Kieran Benton

changes by roger:
- use ServiceModel, DataContract only when wcf is enabled
- indent space vs tab
- remove issue on lib/cpp/README_WINDOWS
- add testStringMap on test/csharp/ThriftTest/TestServer.cs
- add build to test/csharp/ThriftTest/maketest.sh

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1232578 13f79535-47bb-0310-9956-ffa450edef68
2012-01-17 21:20:56 +00:00
Roger Meier
eaa61d8fda THRIFT-1267 Node.js can't throw exceptions
Patch: Henrique Mendonca

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1230797 13f79535-47bb-0310-9956-ffa450edef68
2012-01-12 21:38:29 +00:00
Roger Meier
333bbf3d88 THRIFT-1485 Performance: pass large and/or refcounted arguments as "const"
Patch: Jens Geyer

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1228965 13f79535-47bb-0310-9956-ffa450edef68
2012-01-08 21:51:08 +00:00
Bryan Duxbury
bad4174a57 THRIFT-1479. php: Compiled PHP process functions missing writeMessageEnd()
This patch adds in the missing call.

Patch: Andrew Grumet

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1226892 13f79535-47bb-0310-9956-ffa450edef68
2012-01-03 17:35:26 +00:00
Bryan Duxbury
9704630bab THRIFT-1483. java: java compiler does not generate type parameters for services in extended clauses
Patch: Ruslan Shevchenko

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1226889 13f79535-47bb-0310-9956-ffa450edef68
2012-01-03 17:28:45 +00:00
Bryan Duxbury
a3df547c84 THRIFT-317. java: Issues with Java struct validation
Nested structs will now be validated before serialization starts.

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1225035 13f79535-47bb-0310-9956-ffa450edef68
2011-12-27 22:26:59 +00:00
Roger Meier
94eecc8259 THRIFT-1168 C++ cob client/server: void functions that throw exceptions
Patch: NewBlood

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1221891 13f79535-47bb-0310-9956-ffa450edef68
2011-12-21 21:23:28 +00:00
Bryan Duxbury
1e79cb40f5 THRIFT-1469. java: Java isset space optimization
This patch gives the generated code some variable-sized options for the isset bit vector. The compiler will attempt to use byte, short, int and long types before reverting to a BitSet for structs with a LOT of optional fields. This should save a fair amount of memory in a lot of cases.

Patch: Brian Bloniarz

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1221828 13f79535-47bb-0310-9956-ffa450edef68
2011-12-21 18:13:29 +00:00
Roger Meier
12d705390d THRIFT-1461 Recent TNonblockingServer changes broke --enable-boostthreads=yes, Windows
Patch: Alexandre Parenteau

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1214547 13f79535-47bb-0310-9956-ffa450edef68
2011-12-14 23:35:28 +00:00
Jake Farrell
a99027c708 Thrift-1462: add more strict compiler flags
Reverting MINGW addition for c+++0x 



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1213905 13f79535-47bb-0310-9956-ffa450edef68
2011-12-13 20:12:26 +00:00
Roger Meier
6e96965fdb THRIFT-1462 add more strict compiler flags
FIX: check for MINGW and use reduced compiler flag set for mingw

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1213523 13f79535-47bb-0310-9956-ffa450edef68
2011-12-13 00:36:01 +00:00
Roger Meier
ca10fd4a51 THRIFT-1462 add more strict compiler flags(-Wall -Wextra -std=c++0x -pedantic)
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1213459 13f79535-47bb-0310-9956-ffa450edef68
2011-12-12 22:00:23 +00:00
Roger Meier
aad8fb4fec fix compiler warnings
git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1212892 13f79535-47bb-0310-9956-ffa450edef68
2011-12-10 21:50:10 +00:00
Roger Meier
e1d2458f1a THRIFT-1452 generate a swap() method for all generated structs
fix compiler warnings, when having empty structs

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1212593 13f79535-47bb-0310-9956-ffa450edef68
2011-12-09 19:33:07 +00:00
Jake Farrell
343c61d6a7 Thrift-1441: Generate constructor with parameters for exception class to let it update message property automatically.
Client:delphi
Patch: Kenjiro Fukumitsu

Add the function to delphi generator that generates constructor with parameters to initialize members,if the class is exception and have more than zero parameters.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1212226 13f79535-47bb-0310-9956-ffa450edef68
2011-12-09 02:29:56 +00:00
Jake Farrell
3318201c2f Thrift-1452: generate a swap() method for all generated structs
Client: cpp
Patch: Dave Watson

Convenience method for all C++ thrift types to add swap() function



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1212130 13f79535-47bb-0310-9956-ffa450edef68
2011-12-08 21:15:50 +00:00
Roger Meier
284a9b56d7 THRIFT-1037 Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3
Patch: Damian Mehers & Jens Geyer

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1211880 13f79535-47bb-0310-9956-ffa450edef68
2011-12-08 13:39:56 +00:00
Jake Farrell
23bf35daa3 Thrift-1454:Better handling of write on a closed TSocket
Client: cpp
Patch: Dave Watson

TSocket.send() was expecting a send() on the underlying socket
to fail by returning zero, but the actual behavior is to raise
an exception.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1211736 13f79535-47bb-0310-9956-ffa450edef68
2011-12-08 02:02:20 +00:00
Jake Farrell
a2c5674920 Thrift-1445:minor C++ generator variable cleanup
Client: cpp
Patch: Dave Watson

In generate_process_function(), service_func_name is always used as a
string literal. Therefore, construct it with the double quotes
built-in, rather than having to add them everywhere we use it.



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1210757 13f79535-47bb-0310-9956-ffa450edef68
2011-12-06 02:59:04 +00:00
Jake Farrell
9689d89df1 Thrift-1340: Add support of ARC to Objective-C
Client: Objective-c
Patch: Hirano Satoshi

Adds -objc-arc flag to compiler and if used removes the retain/release/autorelease from generated code



git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1210732 13f79535-47bb-0310-9956-ffa450edef68
2011-12-06 01:07:17 +00:00