valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-07 02:45:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-3131 fix path for "go get"

Browse Source 
Client: Go
Patch: Konstantin Shaposhnikov <k.shaposhnikov@gmail.com>

This closes #497

git.apache.org/thrift.git/lib/go/thrift is the correct import path as it is used
by default in the generated go code.

Unfortunately "go get" can download this library only using git:// scheme so if a user running "go get" is behind a firewall or Git is down at git.apache.org (which seems to be the case from time to time) then running go get with this path will fail.

I will try to get this fixed in Go 1.5.
Issues to watch:
- https://issues.apache.org/jira/browse/INFRA-9658
- https://github.com/golang/go/issues/10797
This commit is contained in:
Jens Geyer 2015-05-16 14:33:18 +02:00
parent b7138acd86
commit fc8a6a5187
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/go/README.md
View File

@ -27,7 +27,7 @@ Using Thrift with Go
In following Go conventions, we recommend you use the 'go' tool to install
Thrift for go.
$ go get git-wip-us.apache.org/repos/asf/thrift.git/lib/go/thrift
$ go get git.apache.org/thrift.git/lib/go/thrift
Will retrieve and install the most recent version of the package.