valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-07 10:48:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-4711: Improve Immutable None Type Instantiation

Browse Source
This commit is contained in:
Beluga Behr 2019-01-01 14:43:23 -05:00 committed by James E. King III
parent 4c71660dab
commit df9c60d38f
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/java/src/org/apache/thrift/Option.java
View File

@ -24,6 +24,9 @@ package org.apache.thrift;
*/
public abstract class Option<T> {
@SuppressWarnings("rawtypes")
private static final Option NONE = new None();
/**
* Whether the Option is defined or not
* @return
@ -87,7 +90,7 @@ public abstract class Option<T> {
}
public String toString() {
return "Some("+value.toString()+")";
return "Some(" + value + ")";
}
}
@ -99,9 +102,9 @@ public abstract class Option<T> {
*/
public static <T> Option<T> fromNullable(T value) {
if (value != null) {
return new Some<T>(value);
return some(value);
} else {
return new None<T>();
return none();
}
}
@ -115,7 +118,8 @@ public abstract class Option<T> {
return new Some<T>(value);
}
@SuppressWarnings("unchecked")
public static <T> None<T> none() {
return new None<T>();
return (None<T>) NONE;
}
}