valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-07 02:45:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-2689 struct names that differ only in capitalization of first character generate broken erlang code

Browse Source 
Client: haskell
Patch: Alisdair Sullivan

This closes #239

Removed struct from NameConflictTest.thrift that causes problems for certain backends
This commit is contained in:
Jens Geyer 2014-10-07 21:16:20 +02:00
parent 196c5afbb1
commit dd971d5377
2 changed files with 0 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/NameConflictTest.thrift
View File

@ -76,15 +76,6 @@ struct TheEdgeCase {
6: bool TheEdgeCase__ 6: bool TheEdgeCase__
} }
struct theEdgeCase {
1: bool theEdgeCase
2: bool theEdgeCase_
3: bool theEdgeCase__
4: bool TheEdgeCase
5: bool TheEdgeCase_
6: bool TheEdgeCase__
}
struct Tricky_ { struct Tricky_ {
1: bool tricky 1: bool tricky
2: bool Tricky 2: bool Tricky

26
test/erl/src/name_conflict_test.erl
View File

@ -80,17 +80,6 @@ record_generation_test_() ->
'TheEdgeCase__'=null 'TheEdgeCase__'=null
} }
)}, )},
{"theEdgeCase record", ?_assertMatch(
{theEdgeCase, _, _, _, _, _, _},
#theEdgeCase{
theEdgeCase=null,
theEdgeCase_=null,
theEdgeCase__=null,
'TheEdgeCase'=null,
'TheEdgeCase_'=null,
'TheEdgeCase__'=null
}
)},
{"Tricky_ record", ?_assertMatch( {"Tricky_ record", ?_assertMatch(
{'Tricky_', _, _}, {'Tricky_', _, _},
#'Tricky_'{tricky=null,'Tricky'=null} #'Tricky_'{tricky=null,'Tricky'=null}
@ -149,10 +138,6 @@ struct_info_test_() ->
{struct, [{1, bool},{2, bool},{3, bool},{4, bool},{5, bool},{6, bool}]}, {struct, [{1, bool},{2, bool},{3, bool},{4, bool},{5, bool},{6, bool}]},
name_conflict_test_types:struct_info('TheEdgeCase') name_conflict_test_types:struct_info('TheEdgeCase')
)}, )},
{"theEdgeCase definition", ?_assertEqual(
{struct, [{1, bool},{2, bool},{3, bool},{4, bool},{5, bool},{6, bool}]},
name_conflict_test_types:struct_info(theEdgeCase)
)},
{"Tricky_ definition", ?_assertEqual( {"Tricky_ definition", ?_assertEqual(
{struct, [{1, bool},{2, bool}]}, {struct, [{1, bool},{2, bool}]},
name_conflict_test_types:struct_info('Tricky_') name_conflict_test_types:struct_info('Tricky_')
@ -234,17 +219,6 @@ struct_info_test_() ->
]}, ]},
name_conflict_test_types:struct_info_ext('TheEdgeCase') name_conflict_test_types:struct_info_ext('TheEdgeCase')
)}, )},
{"TheEdgeCase extended definition", ?_assertEqual(
{struct, [
{1, undefined, bool, theEdgeCase, undefined},
{2, undefined, bool, theEdgeCase_, undefined},
{3, undefined, bool, theEdgeCase__, undefined},
{4, undefined, bool, 'TheEdgeCase', undefined},
{5, undefined, bool, 'TheEdgeCase_', undefined},
{6, undefined, bool, 'TheEdgeCase__', undefined}
]},
name_conflict_test_types:struct_info_ext(theEdgeCase)
)},
{"Tricky_ extended definition", ?_assertEqual( {"Tricky_ extended definition", ?_assertEqual(
{struct, [ {struct, [
{1, undefined, bool, tricky, undefined}, {1, undefined, bool, tricky, undefined},