valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-06 18:35:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-1907 Compiling namespace and sub-namespace directives for unrecognized generators should only be a warning

Browse Source 
Patch: Andrew Cox
This commit is contained in:
Henrique 2013-05-16 21:19:50 +02:00 committed by Henrique Mendonça
parent 744e45f3b6
commit d28d4d5784
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compiler/cpp/src/parse/t_program.h
View File

@ -188,7 +188,8 @@ class t_program : public t_doc {
if (sub_index != std::string::npos) {
std::string sub_namespace = language.substr(sub_index+1);
if ( ! it->second->is_valid_namespace(sub_namespace)) {
throw base_language + " generator does not accept '" + sub_namespace + "' as sub-namespace!";
std::string warning = base_language + " generator does not accept '" + sub_namespace + "' as sub-namespace!";
pwarning(1, warning.c_str());
}
}
}

8
test/ThriftTest.thrift
View File

@ -35,6 +35,12 @@ namespace go ThriftTest
namespace php ThriftTest
namespace delphi Thrift.Test
namespace cocoa ThriftTest
// Presence of namespaces and sub-namespaces for which there is
// no generator should compile with warnings only
namespace noexist ThriftTest
namespace cpp.noexist ThriftTest
namespace * thrift.test
/**
@ -368,4 +374,4 @@ struct StructA {
struct StructB {
1: optional StructA aa;
2: required StructA ab;
}
}