valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-06 18:35:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix remote client for HTTP transport

Browse Source 
Client: go

Assign parsedUrl to the variable in the outer scope instead of creating
a new one. Previously the outer parsedUrl was never assigned and was
therefore always empty.

This closes #1411
This commit is contained in:
Dylan Trotter 2017-11-07 09:56:17 -08:00 committed by James E. King, III
parent 39eaae6675
commit cde4d4181a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/cpp/src/thrift/generate/t_go_generator.cc
View File

@ -2130,7 +2130,7 @@ void t_go_generator::generate_service_remote(t_service* tservice) {
f_remote << indent() << "var urlString string" << endl;
f_remote << indent() << "var framed bool" << endl;
f_remote << indent() << "var useHttp bool" << endl;
f_remote << indent() << "var parsedUrl url.URL" << endl;
f_remote << indent() << "var parsedUrl *url.URL" << endl;
f_remote << indent() << "var trans thrift.TTransport" << endl;
f_remote << indent() << "_ = strconv.Atoi" << endl;
f_remote << indent() << "_ = math.Abs" << endl;
@ -2147,7 +2147,8 @@ void t_go_generator::generate_service_remote(t_service* tservice) {
f_remote << indent() << "flag.Parse()" << endl;
f_remote << indent() << endl;
f_remote << indent() << "if len(urlString) > 0 {" << endl;
f_remote << indent() << " parsedUrl, err := url.Parse(urlString)" << endl;
f_remote << indent() << " var err error" << endl;
f_remote << indent() << " parsedUrl, err = url.Parse(urlString)" << endl;
f_remote << indent() << " if err != nil {" << endl;
f_remote << indent() << " fmt.Fprintln(os.Stderr, \"Error parsing URL: \", err)" << endl;
f_remote << indent() << " flag.Usage()" << endl;