valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-07 02:45:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-4807: Fix php segfault on reference pass

Browse Source 
Client: php (extension)

When reference is passed to php extension, it's unreferenced (instead of
derefrenced). The next time one tries to use the same variable PHP
segaults. Even if not used again, php segfaults on
user_shutdown_function_call.
This commit is contained in:
Josip Sokcevic 2019-02-20 23:15:08 -08:00 committed by James E. King III
parent c6b019affd
commit a4ee1f281b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
View File

@ -1013,7 +1013,7 @@ void binary_serialize_spec(zval* zthis, PHPOutputTransport& transport, HashTable
zval* prop = zend_read_property(Z_OBJCE_P(zthis), zthis, varname, strlen(varname), false, &rv);
if (Z_TYPE_P(prop) == IS_REFERENCE){
ZVAL_UNREF(prop);
ZVAL_DEREF(prop);
}
if (Z_TYPE_P(prop) != IS_NULL) {
transport.writeI8(ttype);