fix static analyzer warings

This commit is contained in:
cyy 2019-01-16 14:43:51 +08:00
parent f7a4ead00d
commit 9fed90104c
5 changed files with 3 additions and 7 deletions

View File

@ -670,10 +670,8 @@ void t_delphi_generator::create_keywords() {
delphi_reserved_method["instancesize"] = 1;
delphi_reserved_method["inheritsfrom"] = 1;
delphi_reserved_method["methodaddress"] = 1;
delphi_reserved_method["methodaddress"] = 1;
delphi_reserved_method["methodname"] = 1;
delphi_reserved_method["fieldaddress"] = 1;
delphi_reserved_method["fieldaddress"] = 1;
delphi_reserved_method["getinterface"] = 1;
delphi_reserved_method["getinterfaceentry"] = 1;
delphi_reserved_method["getinterfacetable"] = 1;

View File

@ -1285,7 +1285,7 @@ void TNonblockingIOThread::registerEvents() {
}
bool TNonblockingIOThread::notify(TNonblockingServer::TConnection* conn) {
THRIFT_SOCKET fd = getNotificationSendFD();
auto fd = getNotificationSendFD();
if (fd < 0) {
return false;
}

View File

@ -216,7 +216,7 @@ void testProtocol(const char* protoname) {
testMessage<TProto>();
printf("%s => OK\n", protoname);
} catch (TException e) {
} catch (const TException &e) {
THRIFT_SNPRINTF(errorMessage, ERR_LEN, "%s => Test FAILED: %s", protoname, e.what());
throw TException(errorMessage);
}

View File

@ -227,7 +227,7 @@ BOOST_AUTO_TEST_CASE( JSON_BufferedHTTP )
blockable_transport->flush() ;
try {
client.recv_roundTripRPC() ;
} catch (TTransportException e) {
} catch (const TTransportException &e) {
BOOST_ERROR( "we should not get a transport exception -- this means we failed: " + std::string(e.what()) ) ;
}
transport->close();

View File

@ -726,9 +726,7 @@ void test_read_none_available() {
BOOST_REQUIRE(transports.in != NULL);
BOOST_REQUIRE(transports.out != NULL);
uint8_t write_buf[16];
uint8_t read_buf[16];
memset(write_buf, 'a', sizeof(write_buf));
// Attempting to read when no data is available should either block until
// some data is available, or fail immediately. (e.g., TSocket blocks,