valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-07 02:45:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-4919 THttpTransport.cs (netstd) and THttpClientTransport (netcore) have bad timeout code

Browse Source 
Patch: Jens Geyer

This closes #1847
This commit is contained in:
Jens Geyer 2019-08-19 23:41:49 +02:00
parent 26ef904600
commit 9cf37be1f1
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/netcore/Thrift/Transports/Client/THttpClientTransport.cs
View File

@ -63,6 +63,7 @@ namespace Thrift.Transports.Client
public int ConnectTimeout
{
set { _connectTimeout = value; }
get { return _connectTimeout; }
}
public override bool IsOpen => true;
@ -145,7 +146,7 @@ namespace Thrift.Transports.Client
if (_connectTimeout > 0)
{
httpClient.Timeout = TimeSpan.FromSeconds(_connectTimeout);
httpClient.Timeout = TimeSpan.FromMilliseconds(_connectTimeout);
}
httpClient.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/x-thrift"));

2
lib/netstd/Thrift/Transport/Client/THttpTransport.cs
View File

@ -145,7 +145,7 @@ namespace Thrift.Transport.Client
if (_connectTimeout > 0)
{
httpClient.Timeout = TimeSpan.FromSeconds(_connectTimeout);
httpClient.Timeout = TimeSpan.FromMilliseconds(_connectTimeout);
}
httpClient.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/x-thrift"));