mirror of
https://github.com/valitydev/thrift.git
synced 2024-11-07 02:45:22 +00:00
Thrift TException does not properly define virtual what() method.
Summary: Clients would elect to call the base class what() method instead of the derived version. This results in less than usable exceptions for debugging. Reviewed By: Karl * mcslee Test Plan: Tested with local application in development. Revert Plan: revertible. git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@664887 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
parent
3860c9a246
commit
97f9d60be8
@ -23,7 +23,7 @@ public:
|
|||||||
|
|
||||||
~TException() throw() {}
|
~TException() throw() {}
|
||||||
|
|
||||||
const char* what() {
|
const char* what() const throw() {
|
||||||
if (message_.empty()) {
|
if (message_.empty()) {
|
||||||
return "Default TException.";
|
return "Default TException.";
|
||||||
} else {
|
} else {
|
||||||
|
Loading…
Reference in New Issue
Block a user