valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-07 02:45:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-4942 Set PHP struct generated field values as private with getters and setters

Browse Source 
Client: php
Patch: Das Dedipyaman

This closes #2245

Update field access for getters_setters flag. FFields are private if getters_setters are set, otherwise, public.
This commit is contained in:
Dedipyaman Das 2020-09-27 02:29:23 +05:30 committed by Jens Geyer
parent c553155af8
commit 6fd830d690
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compiler/cpp/src/thrift/generate/t_php_generator.cc
View File

@ -939,7 +939,8 @@ void t_php_generator::generate_php_struct_definition(ostream& out,
dval = render_const_value((*m_iter)->get_type(), (*m_iter)->get_value());
}
generate_php_doc(out, *m_iter);
indent(out) << "public $" << (*m_iter)->get_name() << " = " << dval << ";" << endl;
string access = (getters_setters_) ? "private" : "public";
indent(out) << access << " $" << (*m_iter)->get_name() << " = " << dval << ";" << endl;
}
out << endl;