valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-06 18:35:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Early error check in golang struct reading

Browse Source 
avoids a timeout on malformed input found by fuzzing
This commit is contained in:
Philippe Antoine 2021-03-15 09:26:39 +01:00 committed by Yuxuan 'fishy' Wang
parent cc70b4e89a
commit 62beb6751d
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/go/thrift/protocol.go
View File

@ -122,11 +122,14 @@ func Skip(ctx context.Context, self TProtocol, fieldType TType, maxDepth int) (e
return err
}
for {
_, typeId, _, _ := self.ReadFieldBegin(ctx)
_, typeId, _, err := self.ReadFieldBegin(ctx)
if err != nil {
return err
}
if typeId == STOP {
break
}
err := Skip(ctx, self, typeId, maxDepth-1)
err = Skip(ctx, self, typeId, maxDepth-1)
if err != nil {
return err
}