valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-07 02:45:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-4012 Python Twisted implementation uses implements, not compatible with Py3

Browse Source 
Client: Python
Patch: Palmer Cox <palmer@fiscalnote.com>

This closes #1144

Zope implements doesn't work with Python 3; @implementer does. Replace uses of implements with @implementer since the former does not work with Python 3, while the latter works with both Python 2 and 3.
This commit is contained in:
Palmer Cox 2016-12-22 01:24:33 -05:00 committed by Jens Geyer
parent 30a8b65dce
commit 366e89ead7
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
compiler/cpp/src/thrift/generate/t_py_generator.cc
View File

@ -1051,7 +1051,7 @@ void t_py_generator::generate_service(t_service* tservice) {
<< import_dynbase_;
if (gen_twisted_) {
f_service_ << "from zope.interface import Interface, implements" << endl
f_service_ << "from zope.interface import Interface, implementer" << endl
<< "from twisted.internet import defer" << endl
<< "from thrift.transport import TTwisted" << endl;
} else if (gen_tornado_) {
@ -1180,8 +1180,8 @@ void t_py_generator::generate_service_client(t_service* tservice) {
f_service_ << endl << endl;
if (gen_twisted_) {
f_service_ << "class Client" << extends_client << ":" << endl
<< indent_str() << "implements(Iface)" << endl
f_service_ << "@implementer(Iface)" << endl
<< "class Client" << extends_client << ":" << endl
<< endl;
} else {
f_service_ << "class Client(" << extends_client << "Iface):" << endl;
@ -1720,8 +1720,8 @@ void t_py_generator::generate_service_server(t_service* tservice) {
// Generate the header portion
if (gen_twisted_) {
f_service_ << "class Processor(" << extends_processor << "TProcessor):" << endl
<< indent_str() << "implements(Iface)" << endl << endl;
f_service_ << "@implementer(Iface)" << endl
<< "class Processor(" << extends_processor << "TProcessor):" << endl;
} else {
f_service_ << "class Processor(" << extends_processor << "Iface, TProcessor):" << endl;
}