valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-06 18:35:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-3831 in test/cpp explicitly use signed char

Browse Source 
`char`'s signed-ness is implimentation dependent, and in the case where
`char` was not signed, we previously recieved errors like

    thrift/0.9.3-r0/git/test/cpp/src/TestClient.cpp:404:15: error: narrowing conversion of '-127' from 'int' to 'char' inside { } [-Wnarrowing]

(This example from gcc-6 on arm)

This closes #1085
This commit is contained in:
Cody P Schafer 2016-09-09 15:50:26 -04:00 committed by Nobuaki Sukegawa
parent 4bbfe6120e
commit 3129549feb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/cpp/src/TestClient.cpp
View File

@ -530,7 +530,7 @@ int main(int argc, char** argv) {
return_code |= ERR_BASETYPES;
}
cout << "testBinary([-128..127]) = {" << flush;
const char bin_data[256]
const signed char bin_data[256]
= {-128, -127, -126, -125, -124, -123, -122, -121, -120, -119, -118, -117, -116, -115, -114,
-113, -112, -111, -110, -109, -108, -107, -106, -105, -104, -103, -102, -101, -100, -99,
-98, -97, -96, -95, -94, -93, -92, -91, -90, -89, -88, -87, -86, -85, -84,
@ -551,7 +551,7 @@ int main(int argc, char** argv) {
127};
try {
string bin_result;
testClient.testBinary(bin_result, string(bin_data, 256));
testClient.testBinary(bin_result, string(reinterpret_cast<const char *>(bin_data), 256));
if (bin_result.size() != 256) {
cout << endl << "*** FAILED ***" << endl;
cout << "invalid length: " << bin_result.size() << endl;