valitydev/thrift
14
0
Fork 0
mirror of https://github.com/valitydev/thrift.git synced 2024-11-06 18:35:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

THRIFT-5509: Suppress noisy log from go's TSimpleServer

Browse Source 
Client: go

This is a follow up of 6f33b0470. After we proactively closed the client
connection, processor.Process could return NOT_OPEN as a result, and
those errors being logged will cause the log to be very noisy.

This will also be cherry-picked into 0.16.0 branch.
This commit is contained in:
Yuxuan 'fishy' Wang 2022-02-08 15:07:31 -08:00
parent f18a8f34e2
commit 3031394106
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/go/thrift/simple_server.go
View File

@ -238,7 +238,7 @@ func (p *TSimpleServer) Stop() error {
return nil
}
// If err is actually EOF, return nil, otherwise return err as-is.
// If err is actually EOF or NOT_OPEN, return nil, otherwise return err as-is.
func treatEOFErrorsAsNil(err error) error {
if err == nil {
return nil
@ -247,7 +247,11 @@ func treatEOFErrorsAsNil(err error) error {
return nil
}
var te TTransportException
if errors.As(err, &te) && te.TypeId() == END_OF_FILE {
// NOT_OPEN returned by processor.Process is usually caused by client
// abandoning the connection (e.g. client side time out, or just client
// closes connections from the pool because of shutting down).
// Those logs will be very noisy, so suppress those logs as well.
if errors.As(err, &te) && (te.TypeId() == END_OF_FILE || te.TypeId() == NOT_OPEN) {
return nil
}
return err