2014-04-05 16:20:07 +00:00
## Process used by committers to review and submit patches
2015-02-04 15:43:26 +00:00
1. Make sure that there is an issue for the patch(s) you are about to commit in our [Jira issue tracker ](http://issues.apache.org/jira/browse/THRIFT )
2014-04-05 16:20:07 +00:00
1. Check out the latest version of the source code
2015-02-04 15:43:26 +00:00
2018-12-27 15:57:35 +00:00
* git clone https://github.com/apache/thrift.git thrift
2014-04-05 16:20:07 +00:00
1. Apply the patch
2015-02-04 15:43:26 +00:00
* curl https://issues.apache.org/jira/... |git apply --ignore-space-change
or
* curl https://github.com/< GitHub User > /thrift/commit/< Commit ID > .patch |git apply --ignore-space-change
2014-04-05 16:20:07 +00:00
1. Inspect the applied patch to ensure that all [Legal aspects on Submission of Contributions (Patches) ](http://www.apache.org/licenses/LICENSE-2.0.html#contributions ) are met
1. Run the necessary unit tests and cross language test cases to verify the patch
1. Commit the patch
2015-02-04 15:43:26 +00:00
git --config user.name "Your Name"
git --config user.email "YourApacheID@apache.org"
git add -A
git commit
2014-04-05 16:20:07 +00:00
1. The commit message should be in the format:
2015-02-04 15:43:26 +00:00
THRIFT-###:< Jira description >
Client: < component >
Patch: < Name of person contributing the patch >
Description of what was fixed or addressed.
< %
if this is a github pull request then add below comment
to automaticaly close GitHub request.
%>
This closes #XX
2014-04-05 16:20:07 +00:00
1. Double check the patch committed and that nothing was missed then push the patch
2015-02-04 15:43:26 +00:00
git status
git show HEAD
git push origin master
2014-04-05 16:20:07 +00:00
2015-02-04 15:43:26 +00:00
1. Resolve the jira issue and set the following for the changelog
2014-04-05 16:20:07 +00:00
2015-02-04 15:43:26 +00:00
* Component the patch is for
* fixVersion to the current version on master