PROX-401: fix after review

This commit is contained in:
avcherkasov 2020-04-20 12:52:26 +03:00
parent 295c06530e
commit 4fc1d465f0
4 changed files with 5 additions and 51 deletions

17
pom.xml
View File

@ -29,7 +29,7 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>1.8</java.version>
<three-ds-server-domain-lib.version>0.0.1</three-ds-server-domain-lib.version>
<three-ds-server-domain-lib.version>1.0.0</three-ds-server-domain-lib.version>
<adapter-thrift-lib.version>1.0.3</adapter-thrift-lib.version>
<cds-proto.version>1.57-b58a3fd</cds-proto.version>
<damsel.version>1.391-8fe5f98</damsel.version>
@ -110,21 +110,6 @@
<build>
<plugins>
<!--<plugin>-->
<!--<groupId>org.springframework.boot</groupId>-->
<!--<artifactId>spring-boot-maven-plugin</artifactId>-->
<!--<version>1.5.1.RELEASE</version>-->
<!--<executions>-->
<!--<execution>-->
<!--<goals>-->
<!--<goal>repackage</goal>-->
<!--</goals>-->
<!--</execution>-->
<!--</executions>-->
<!--<configuration>-->
<!--<skip>true</skip>-->
<!--</configuration>-->
<!--</plugin>-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>

View File

@ -1,18 +1,13 @@
package com.rbkmoney.three.ds.server.client.model;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.rbkmoney.three.ds.server.client.constant.CommonField;
import com.rbkmoney.threeds.server.domain.ChallengeWindowSize;
import com.rbkmoney.threeds.server.domain.message.MessageType;
import lombok.*;
import java.util.HashMap;
import java.util.Map;
import lombok.Builder;
import lombok.Data;
import lombok.ToString;
@Data
@Builder
@NoArgsConstructor
@AllArgsConstructor
@JsonInclude(value = JsonInclude.Include.NON_ABSENT)
@ToString(onlyExplicitlyIncluded = true)
public class CReq {
@ -36,23 +31,4 @@ public class CReq {
@ToString.Include
private String challengeWindowSize;
public Map<String, String> prepareParams() {
Map<String, String> params = new HashMap<>();
params.put(CommonField.THREE_DS_SERVER_TRANS_ID.getValue(), threeDSServerTransID);
params.put(CommonField.ACS_TRANS_ID.getValue(), acsTransID);
params.put(CommonField.MESSAGE_TYPE.getValue(), messageType);
params.put(CommonField.MESSAGE_VERSION.getValue(), messageVersion);
if (threeDSSessionData != null) {
params.put(CommonField.THREE_DS_SESSION_DATA.getValue(), threeDSSessionData);
}
if (challengeWindowSize == null) {
challengeWindowSize = ChallengeWindowSize.FULL_SCREEN.getValue();
}
params.put(CommonField.CHALLENGE_WINDOW_SIZE.getValue(), challengeWindowSize);
return params;
}
}

View File

@ -8,7 +8,7 @@ import java.util.Arrays;
import java.util.Map;
@NoArgsConstructor
public class Mpi3DsClientValidator implements Validator {
public class Mpi3DsClientValidator {
private static String[] requiredFields = {
CommonField.THREE_DS_REQUESTOR_NAME.getValue(),

View File

@ -1,7 +0,0 @@
package com.rbkmoney.three.ds.server.client.validator;
import java.util.Map;
public interface Validator {
void validate(Map<String, String> options);
}