valitydev/salt
14
0
Fork 0
mirror of https://github.com/valitydev/salt.git synced 2024-11-07 17:09:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
b93392dfb7
salt/tests/unit
History
rallytime b93392dfb7 Return a SaltInvocationError when passing incorrect function pattern 
When calling an incorrectly formatted wheel or runner function, we should
be raising a SaltInvocationError with a hint to check function syntax rather
that raising an Eauth authentication error.

This PR does several things:

- Adds a dictionary error return when the function syntax passed through to
`utils.minions.CkMinions.spec_check` does not match the expected `module.function`
syntax
- Handles the return of this new dictionary error (instead of previous `False` return)
wherever the spec_check function is called. This is handled up the stack in
`master.py` and `masterapi.py`.
- Reworks the runner and wheel functions in `master.py` and `masterapi.py` to
help make those functions more DRY (see `salt.auth.check_authentication` function).
- Adds tests for all of these changes (written before the runner and wheel functions
were moved to use the new salt.auth.check_authentication function)  to help prevent
regressions.
- Fixes a couple of places where unit tests exposed potential stacktraces.
- Adjusts one previous unit test concerning the dictionary error change from spec_check
2017-09-05 17:08:50 -04:00
..
acl Cleanup test attributes once finished 2017-03-28 19:00:51 +01:00
beacons Updating mock from salt.utils to salt.utils.files for fopen. 2017-08-14 12:04:38 -07:00
cache Merge branch '2017.7' into 'develop' 2017-08-22 09:07:26 -04:00
cli Merge branch '2016.11' into 'develop' 2017-03-28 17:09:30 -06:00
cloud Fix usage of assert_called_once in Python 3 < 3.6 2017-07-03 09:30:12 -05:00
config Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
daemons Return a SaltInvocationError when passing incorrect function pattern 2017-09-05 17:08:50 -04:00
engines Drop @patch usage 2017-04-28 13:36:42 +01:00
fileserver Merge branch '2017.7' into 'develop' 2017-08-30 12:16:28 -04:00
grains Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
loader Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
modules Merge pull request #43276 from rallytime/utils-state-moves 2017-09-05 14:20:08 -06:00
netapi Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
output Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
pillar Remove tests for old git_pillar syntax. 2017-08-23 16:49:58 -04:00
proxy Fixed pylint 2017-07-20 22:22:24 +01:00
renderers Merge pull request #41868 from yagnik/nacl_renderer 2017-08-22 13:36:38 -06:00
returners Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
runners Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
serializers Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
ssh Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
states Merge pull request #43276 from rallytime/utils-state-moves 2017-09-05 14:20:08 -06:00
templates Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
transport Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
utils Return a SaltInvocationError when passing incorrect function pattern 2017-09-05 17:08:50 -04:00
__init__.py The LoaderModuleMixin is the right approach here. 2017-03-28 19:04:05 +01:00
test_auth.py Fixed lint failure 2017-08-08 14:21:02 +05:30
test_client.py Drop @patch usage 2017-04-28 13:36:42 +01:00
test_conf.py Absolute imports and A LOT of code cleanup. 2017-03-01 01:33:07 +00:00
test_context.py Absolute imports and A LOT of code cleanup. 2017-03-01 01:33:07 +00:00
test_crypt.py Merge branch '2017.7' into 'develop' 2017-08-07 10:43:06 -04:00
test_daemons.py Move mixins to tests.support.mixins. 2017-04-04 17:29:34 +01:00
test_doc.py Update some salt.utils.x paths for moved util functions 2017-08-29 16:24:47 -04:00
test_fileclient.py Fix unit.test_fileclient 2017-08-15 16:34:03 -06:00
test_files.py Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
test_log.py Absolute imports and A LOT of code cleanup. 2017-03-01 01:33:07 +00:00
test_map_conf.py Drop @patch usage 2017-04-28 13:36:42 +01:00
test_master.py Return a SaltInvocationError when passing incorrect function pattern 2017-09-05 17:08:50 -04:00
test_minion.py Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
test_payload.py Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
test_pillar.py Use explicit unicode strings + break up salt.utils 2017-08-08 13:33:43 -05:00
test_pydsl.py Move 4 functions from salt.utils to salt.utils.versions 2017-08-15 12:53:57 -05:00
test_pyobjects.py Update all references for moved functions to use "files" util 2017-07-18 10:31:01 -06:00
test_simple.py Absolute imports and A LOT of code cleanup. 2017-03-01 01:33:07 +00:00
test_spm.py Update all references for moved functions to use "files" util 2017-07-18 10:31:01 -06:00
test_state.py Drop @patch usage 2017-04-28 13:36:42 +01:00
test_stateconf.py Merge branch '2017.7' into 'develop' 2017-08-22 09:07:26 -04:00
test_target.py Move whatever we need from salttesting to salt. 2017-02-28 22:52:49 +00:00
test_template.py Merge branch '2016.11' into 'develop' 2017-04-05 13:02:14 -06:00
test_test_module_names.py Use os.path.join to create paths 2017-08-23 14:43:44 -06:00
test_transport.py Rename transport_test file to test_transport and update imports for pytest 2017-06-28 11:35:13 -06:00
test_version.py Absolute imports and A LOT of code cleanup. 2017-03-01 01:33:07 +00:00
test_zypp_plugins.py Fix zypp_plugins unit test for Python 3 2017-06-27 09:26:35 +01:00