mirror of
https://github.com/valitydev/salt.git
synced 2024-11-07 17:09:03 +00:00
1271 lines
49 KiB
Python
1271 lines
49 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Import python libs
|
|
from __future__ import absolute_import
|
|
import os
|
|
import shutil
|
|
import textwrap
|
|
import threading
|
|
import time
|
|
|
|
# Import Salt Testing libs
|
|
from tests.support.case import ModuleCase
|
|
from tests.support.unit import skipIf
|
|
from tests.support.paths import TMP
|
|
from tests.support.mixins import SaltReturnAssertsMixin
|
|
|
|
# Import salt libs
|
|
import salt.utils
|
|
from salt.modules.virtualenv_mod import KNOWN_BINARY_NAMES
|
|
|
|
# Import 3rd-party libs
|
|
import salt.ext.six as six
|
|
|
|
|
|
class StateModuleTest(ModuleCase, SaltReturnAssertsMixin):
|
|
'''
|
|
Validate the state module
|
|
'''
|
|
|
|
maxDiff = None
|
|
|
|
def test_show_highstate(self):
|
|
'''
|
|
state.show_highstate
|
|
'''
|
|
high = self.run_function('state.show_highstate')
|
|
destpath = os.path.join(TMP, 'testfile')
|
|
self.assertTrue(isinstance(high, dict))
|
|
self.assertTrue(destpath in high)
|
|
self.assertEqual(high[destpath]['__env__'], 'base')
|
|
|
|
def test_show_lowstate(self):
|
|
'''
|
|
state.show_lowstate
|
|
'''
|
|
low = self.run_function('state.show_lowstate')
|
|
self.assertTrue(isinstance(low, list))
|
|
self.assertTrue(isinstance(low[0], dict))
|
|
|
|
def test_catch_recurse(self):
|
|
'''
|
|
state.show_sls used to catch a recursive ref
|
|
'''
|
|
err = self.run_function('state.sls', mods='recurse_fail')
|
|
self.assertIn('recursive', err[0])
|
|
|
|
def test_no_recurse(self):
|
|
'''
|
|
verify that a sls structure is NOT a recursive ref
|
|
'''
|
|
sls = self.run_function('state.show_sls', mods='recurse_ok')
|
|
self.assertIn('snmpd', sls)
|
|
|
|
def test_no_recurse_two(self):
|
|
'''
|
|
verify that a sls structure is NOT a recursive ref
|
|
'''
|
|
sls = self.run_function('state.show_sls', mods='recurse_ok_two')
|
|
self.assertIn('/etc/nagios/nrpe.cfg', sls)
|
|
|
|
def test_running_dictionary_consistency(self):
|
|
'''
|
|
Test the structure of the running dictionary so we don't change it
|
|
without deprecating/documenting the change
|
|
'''
|
|
running_dict_fields = [
|
|
'__id__',
|
|
'__run_num__',
|
|
'__sls__',
|
|
'changes',
|
|
'comment',
|
|
'duration',
|
|
'name',
|
|
'result',
|
|
'start_time',
|
|
]
|
|
|
|
sls = self.run_function('state.single',
|
|
fun='test.succeed_with_changes',
|
|
name='gndn')
|
|
|
|
for state, ret in sls.items():
|
|
for field in running_dict_fields:
|
|
self.assertIn(field, ret)
|
|
|
|
def test_running_dictionary_key_sls(self):
|
|
'''
|
|
Ensure the __sls__ key is either null or a string
|
|
'''
|
|
sls1 = self.run_function('state.single',
|
|
fun='test.succeed_with_changes',
|
|
name='gndn')
|
|
|
|
sls2 = self.run_function('state.sls', mods='gndn')
|
|
|
|
for state, ret in sls1.items():
|
|
self.assertTrue(isinstance(ret['__sls__'], type(None)))
|
|
|
|
for state, ret in sls2.items():
|
|
self.assertTrue(isinstance(ret['__sls__'], str))
|
|
|
|
def _remove_request_cache_file(self):
|
|
'''
|
|
remove minion state request file
|
|
'''
|
|
cache_file = os.path.join(self.get_config('minion')['cachedir'], 'req_state.p')
|
|
if os.path.exists(cache_file):
|
|
os.remove(cache_file)
|
|
|
|
def test_request(self):
|
|
'''
|
|
verify sending a state request to the minion(s)
|
|
'''
|
|
self._remove_request_cache_file()
|
|
|
|
ret = self.run_function('state.request', mods='modules.state.requested')
|
|
result = ret['cmd_|-count_root_dir_contents_|-ls -a / | wc -l_|-run']['result']
|
|
self.assertEqual(result, None)
|
|
|
|
def test_check_request(self):
|
|
'''
|
|
verify checking a state request sent to the minion(s)
|
|
'''
|
|
self._remove_request_cache_file()
|
|
|
|
self.run_function('state.request', mods='modules.state.requested')
|
|
ret = self.run_function('state.check_request')
|
|
result = ret['default']['test_run']['cmd_|-count_root_dir_contents_|-ls -a / | wc -l_|-run']['result']
|
|
self.assertEqual(result, None)
|
|
|
|
def test_clear_request(self):
|
|
'''
|
|
verify clearing a state request sent to the minion(s)
|
|
'''
|
|
self._remove_request_cache_file()
|
|
|
|
self.run_function('state.request', mods='modules.state.requested')
|
|
ret = self.run_function('state.clear_request')
|
|
self.assertTrue(ret)
|
|
|
|
def test_run_request_succeeded(self):
|
|
'''
|
|
verify running a state request sent to the minion(s)
|
|
'''
|
|
self._remove_request_cache_file()
|
|
|
|
if salt.utils.is_windows():
|
|
self.run_function('state.request', mods='modules.state.requested_win')
|
|
else:
|
|
self.run_function('state.request', mods='modules.state.requested')
|
|
|
|
ret = self.run_function('state.run_request')
|
|
|
|
if salt.utils.is_windows():
|
|
key = 'cmd_|-count_root_dir_contents_|-Get-ChildItem C:\\\\ | Measure-Object | %{$_.Count}_|-run'
|
|
else:
|
|
key = 'cmd_|-count_root_dir_contents_|-ls -a / | wc -l_|-run'
|
|
|
|
result = ret[key]['result']
|
|
self.assertTrue(result)
|
|
|
|
def test_run_request_failed_no_request_staged(self):
|
|
'''
|
|
verify not running a state request sent to the minion(s)
|
|
'''
|
|
self._remove_request_cache_file()
|
|
|
|
self.run_function('state.request', mods='modules.state.requested')
|
|
self.run_function('state.clear_request')
|
|
ret = self.run_function('state.run_request')
|
|
self.assertEqual(ret, {})
|
|
|
|
def test_issue_1896_file_append_source(self):
|
|
'''
|
|
Verify that we can append a file's contents
|
|
'''
|
|
testfile = os.path.join(TMP, 'test.append')
|
|
if os.path.isfile(testfile):
|
|
os.unlink(testfile)
|
|
|
|
ret = self.run_function('state.sls', mods='testappend')
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
ret = self.run_function('state.sls', mods='testappend.step-1')
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
ret = self.run_function('state.sls', mods='testappend.step-2')
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
with salt.utils.fopen(testfile, 'r') as fp_:
|
|
testfile_contents = fp_.read()
|
|
|
|
contents = textwrap.dedent('''\
|
|
# set variable identifying the chroot you work in (used in the prompt below)
|
|
if [ -z "$debian_chroot" ] && [ -r /etc/debian_chroot ]; then
|
|
debian_chroot=$(cat /etc/debian_chroot)
|
|
fi
|
|
''')
|
|
|
|
if not salt.utils.is_windows():
|
|
contents += os.linesep
|
|
|
|
contents += textwrap.dedent('''\
|
|
# enable bash completion in interactive shells
|
|
if [ -f /etc/bash_completion ] && ! shopt -oq posix; then
|
|
. /etc/bash_completion
|
|
fi
|
|
''')
|
|
|
|
if salt.utils.is_windows():
|
|
new_contents = contents.splitlines()
|
|
contents = os.linesep.join(new_contents)
|
|
contents += os.linesep
|
|
|
|
self.assertMultiLineEqual(
|
|
contents, testfile_contents)
|
|
|
|
# Re-append switching order
|
|
ret = self.run_function('state.sls', mods='testappend.step-2')
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
ret = self.run_function('state.sls', mods='testappend.step-1')
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
with salt.utils.fopen(testfile, 'r') as fp_:
|
|
testfile_contents = fp_.read()
|
|
|
|
self.assertMultiLineEqual(contents, testfile_contents)
|
|
|
|
def test_issue_1876_syntax_error(self):
|
|
'''
|
|
verify that we catch the following syntax error::
|
|
|
|
/tmp/salttest/issue-1876:
|
|
|
|
file:
|
|
- managed
|
|
- source: salt://testfile
|
|
|
|
file.append:
|
|
- text: foo
|
|
|
|
'''
|
|
testfile = os.path.join(TMP, 'issue-1876')
|
|
sls = self.run_function('state.sls', mods='issue-1876')
|
|
self.assertIn(
|
|
'ID \'{0}\' in SLS \'issue-1876\' contains multiple state '
|
|
'declarations of the same type'.format(testfile),
|
|
sls
|
|
)
|
|
|
|
def test_issue_1879_too_simple_contains_check(self):
|
|
expected = textwrap.dedent('''\
|
|
# set variable identifying the chroot you work in (used in the prompt below)
|
|
if [ -z "$debian_chroot" ] && [ -r /etc/debian_chroot ]; then
|
|
debian_chroot=$(cat /etc/debian_chroot)
|
|
fi
|
|
# enable bash completion in interactive shells
|
|
if [ -f /etc/bash_completion ] && ! shopt -oq posix; then
|
|
. /etc/bash_completion
|
|
fi
|
|
''')
|
|
|
|
if salt.utils.is_windows():
|
|
new_contents = expected.splitlines()
|
|
expected = os.linesep.join(new_contents)
|
|
expected += os.linesep
|
|
|
|
testfile = os.path.join(TMP, 'issue-1879')
|
|
# Delete if exiting
|
|
if os.path.isfile(testfile):
|
|
os.unlink(testfile)
|
|
|
|
# Create the file
|
|
ret = self.run_function('state.sls', mods='issue-1879', timeout=120)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
# The first append
|
|
ret = self.run_function(
|
|
'state.sls', mods='issue-1879.step-1', timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
# The second append
|
|
ret = self.run_function(
|
|
'state.sls', mods='issue-1879.step-2', timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
# Does it match?
|
|
try:
|
|
with salt.utils.fopen(testfile, 'r') as fp_:
|
|
contents = fp_.read()
|
|
self.assertMultiLineEqual(expected, contents)
|
|
# Make sure we don't re-append existing text
|
|
ret = self.run_function(
|
|
'state.sls', mods='issue-1879.step-1', timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
ret = self.run_function(
|
|
'state.sls', mods='issue-1879.step-2', timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
with salt.utils.fopen(testfile, 'r') as fp_:
|
|
contents = fp_.read()
|
|
self.assertMultiLineEqual(expected, contents)
|
|
except Exception:
|
|
if os.path.exists(testfile):
|
|
shutil.copy(testfile, testfile + '.bak')
|
|
raise
|
|
finally:
|
|
if os.path.exists(testfile):
|
|
os.unlink(testfile)
|
|
|
|
def test_include(self):
|
|
fnames = (
|
|
os.path.join(TMP, 'include-test'),
|
|
os.path.join(TMP, 'to-include-test')
|
|
)
|
|
exclude_test_file = os.path.join(
|
|
TMP, 'exclude-test'
|
|
)
|
|
try:
|
|
ret = self.run_function('state.sls', mods='include-test')
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
for fname in fnames:
|
|
self.assertTrue(os.path.isfile(fname))
|
|
self.assertFalse(os.path.isfile(exclude_test_file))
|
|
finally:
|
|
for fname in list(fnames) + [exclude_test_file]:
|
|
if os.path.isfile(fname):
|
|
os.remove(fname)
|
|
|
|
def test_exclude(self):
|
|
fnames = (
|
|
os.path.join(TMP, 'include-test'),
|
|
os.path.join(TMP, 'exclude-test')
|
|
)
|
|
to_include_test_file = os.path.join(
|
|
TMP, 'to-include-test'
|
|
)
|
|
try:
|
|
ret = self.run_function('state.sls', mods='exclude-test')
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
for fname in fnames:
|
|
self.assertTrue(os.path.isfile(fname))
|
|
self.assertFalse(os.path.isfile(to_include_test_file))
|
|
finally:
|
|
for fname in list(fnames) + [to_include_test_file]:
|
|
if os.path.isfile(fname):
|
|
os.remove(fname)
|
|
|
|
@skipIf(salt.utils.which_bin(KNOWN_BINARY_NAMES) is None, 'virtualenv not installed')
|
|
def test_issue_2068_template_str(self):
|
|
venv_dir = os.path.join(
|
|
TMP, 'issue-2068-template-str'
|
|
)
|
|
|
|
try:
|
|
ret = self.run_function(
|
|
'state.sls', mods='issue-2068-template-str-no-dot',
|
|
timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
finally:
|
|
if os.path.isdir(venv_dir):
|
|
shutil.rmtree(venv_dir)
|
|
|
|
# Let's load the template from the filesystem. If running this state
|
|
# with state.sls works, so should using state.template_str
|
|
template_path = os.path.join(
|
|
os.path.dirname(os.path.dirname(__file__)),
|
|
'files', 'file', 'base', 'issue-2068-template-str-no-dot.sls'
|
|
)
|
|
|
|
with salt.utils.fopen(template_path, 'r') as fp_:
|
|
template = fp_.read()
|
|
ret = self.run_function(
|
|
'state.template_str', [template], timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
# Now using state.template
|
|
ret = self.run_function(
|
|
'state.template', [template_path], timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
# Now the problematic #2068 including dot's
|
|
ret = self.run_function(
|
|
'state.sls', mods='issue-2068-template-str', timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
# Let's load the template from the filesystem. If running this state
|
|
# with state.sls works, so should using state.template_str
|
|
template_path = os.path.join(
|
|
os.path.dirname(os.path.dirname(__file__)),
|
|
'files', 'file', 'base', 'issue-2068-template-str.sls'
|
|
)
|
|
|
|
with salt.utils.fopen(template_path, 'r') as fp_:
|
|
template = fp_.read()
|
|
ret = self.run_function(
|
|
'state.template_str', [template], timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
# Now using state.template
|
|
ret = self.run_function(
|
|
'state.template', [template_path], timeout=120
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
def test_template_invalid_items(self):
|
|
TEMPLATE = textwrap.dedent('''\
|
|
{0}:
|
|
- issue-2068-template-str
|
|
|
|
/tmp/test-template-invalid-items:
|
|
file:
|
|
- managed
|
|
- source: salt://testfile
|
|
''')
|
|
for item in ('include', 'exclude', 'extends'):
|
|
ret = self.run_function(
|
|
'state.template_str', [TEMPLATE.format(item)]
|
|
)
|
|
self.assertTrue(isinstance(ret, list))
|
|
self.assertNotEqual(ret, [])
|
|
self.assertEqual(
|
|
['The \'{0}\' declaration found on \'<template-str>\' is '
|
|
'invalid when rendering single templates'.format(item)],
|
|
ret
|
|
)
|
|
|
|
def test_pydsl(self):
|
|
'''
|
|
Test the basics of the pydsl
|
|
'''
|
|
ret = self.run_function('state.sls', mods='pydsl-1')
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
def test_issues_7905_and_8174_sls_syntax_error(self):
|
|
'''
|
|
Call sls file with yaml syntax error.
|
|
|
|
Ensure theses errors are detected and presented to the user without
|
|
stack traces.
|
|
'''
|
|
ret = self.run_function('state.sls', mods='syntax.badlist')
|
|
self.assertEqual(ret, [
|
|
'State \'A\' in SLS \'syntax.badlist\' is not formed as a list'
|
|
])
|
|
ret = self.run_function('state.sls', mods='syntax.badlist2')
|
|
self.assertEqual(ret, [
|
|
'State \'C\' in SLS \'syntax.badlist2\' is not formed as a list'
|
|
])
|
|
|
|
def test_requisites_mixed_require_prereq_use(self):
|
|
'''
|
|
Call sls file containing several requisites.
|
|
'''
|
|
expected_simple_result = {
|
|
'cmd_|-A_|-echo A_|-run': {
|
|
'__run_num__': 2,
|
|
'comment': 'Command "echo A" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-B_|-echo B_|-run': {
|
|
'__run_num__': 1,
|
|
'comment': 'Command "echo B" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-C_|-echo C_|-run': {
|
|
'__run_num__': 0,
|
|
'comment': 'Command "echo C" run',
|
|
'result': True,
|
|
'changes': True}
|
|
}
|
|
expected_result = {
|
|
'cmd_|-A_|-echo A fifth_|-run': {
|
|
'__run_num__': 4,
|
|
'comment': 'Command "echo A fifth" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-B_|-echo B third_|-run': {
|
|
'__run_num__': 2,
|
|
'comment': 'Command "echo B third" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-C_|-echo C second_|-run': {
|
|
'__run_num__': 1,
|
|
'comment': 'Command "echo C second" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-D_|-echo D first_|-run': {
|
|
'__run_num__': 0,
|
|
'comment': 'Command "echo D first" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-E_|-echo E fourth_|-run': {
|
|
'__run_num__': 3,
|
|
'comment': 'Command "echo E fourth" run',
|
|
'result': True,
|
|
'changes': True}
|
|
}
|
|
expected_req_use_result = {
|
|
'cmd_|-A_|-echo A_|-run': {
|
|
'__run_num__': 1,
|
|
'comment': 'Command "echo A" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-B_|-echo B_|-run': {
|
|
'__run_num__': 4,
|
|
'comment': 'Command "echo B" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-C_|-echo C_|-run': {
|
|
'__run_num__': 0,
|
|
'comment': 'Command "echo C" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-D_|-echo D_|-run': {
|
|
'__run_num__': 5,
|
|
'comment': 'Command "echo D" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-E_|-echo E_|-run': {
|
|
'__run_num__': 2,
|
|
'comment': 'Command "echo E" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-F_|-echo F_|-run': {
|
|
'__run_num__': 3,
|
|
'comment': 'Command "echo F" run',
|
|
'result': True,
|
|
'changes': True}
|
|
}
|
|
ret = self.run_function('state.sls', mods='requisites.mixed_simple')
|
|
result = self.normalize_ret(ret)
|
|
self.assertReturnNonEmptySaltType(ret)
|
|
self.assertEqual(expected_simple_result, result)
|
|
|
|
# test Traceback recursion prereq+require #8785
|
|
# TODO: this is actually failing badly
|
|
#ret = self.run_function('state.sls', mods='requisites.prereq_require_recursion_error2')
|
|
#self.assertEqual(
|
|
# ret,
|
|
# ['A recursive requisite was found, SLS "requisites.prereq_require_recursion_error2" ID "B" ID "A"']
|
|
#)
|
|
|
|
# test Infinite recursion prereq+require #8785 v2
|
|
# TODO: this is actually failing badly
|
|
#ret = self.run_function('state.sls', mods='requisites.prereq_require_recursion_error3')
|
|
#self.assertEqual(
|
|
# ret,
|
|
# ['A recursive requisite was found, SLS "requisites.prereq_require_recursion_error2" ID "B" ID "A"']
|
|
#)
|
|
|
|
# test Infinite recursion prereq+require #8785 v3
|
|
# TODO: this is actually failing badly, and expected result is maybe not a recursion
|
|
#ret = self.run_function('state.sls', mods='requisites.prereq_require_recursion_error4')
|
|
#self.assertEqual(
|
|
# ret,
|
|
# ['A recursive requisite was found, SLS "requisites.prereq_require_recursion_error2" ID "B" ID "A"']
|
|
#)
|
|
|
|
# undetected infinite loopS prevents this test from running...
|
|
# TODO: this is actually failing badly
|
|
#ret = self.run_function('state.sls', mods='requisites.mixed_complex1')
|
|
#result = self.normalize_ret(ret)
|
|
#self.assertEqual(expected_result, result)
|
|
|
|
def test_watch_in(self):
|
|
'''
|
|
test watch_in requisite when there is a success
|
|
'''
|
|
ret = self.run_function('state.sls', mods='requisites.watch_in')
|
|
changes = 'test_|-return_changes_|-return_changes_|-succeed_with_changes'
|
|
watch = 'test_|-watch_states_|-watch_states_|-succeed_without_changes'
|
|
|
|
self.assertEqual(ret[changes]['__run_num__'], 0)
|
|
self.assertEqual(ret[watch]['__run_num__'], 2)
|
|
|
|
self.assertEqual('Watch statement fired.', ret[watch]['comment'])
|
|
self.assertEqual('Something pretended to change',
|
|
ret[changes]['changes']['testing']['new'])
|
|
|
|
def test_watch_in_failure(self):
|
|
'''
|
|
test watch_in requisite when there is a failure
|
|
'''
|
|
ret = self.run_function('state.sls', mods='requisites.watch_in_failure')
|
|
out = iter(ret)
|
|
f_state = next(out)
|
|
s_state = next(out)
|
|
|
|
self.assertEqual(False, ret[f_state]['result'])
|
|
self.assertEqual('One or more requisite failed: requisites.watch_in_failure.return_changes',
|
|
ret[s_state]['comment'])
|
|
|
|
def normalize_ret(self, ret):
|
|
'''
|
|
Normalize the return to the format that we'll use for result checking
|
|
'''
|
|
result = {}
|
|
for item, descr in six.iteritems(ret):
|
|
result[item] = {
|
|
'__run_num__': descr['__run_num__'],
|
|
'comment': descr['comment'],
|
|
'result': descr['result'],
|
|
'changes': descr['changes'] != {} # whether there where any changes
|
|
}
|
|
return result
|
|
|
|
def test_requisites_require_ordering_and_errors(self):
|
|
'''
|
|
Call sls file containing several require_in and require.
|
|
|
|
Ensure that some of them are failing and that the order is right.
|
|
'''
|
|
expected_result = {
|
|
'cmd_|-A_|-echo A fifth_|-run': {
|
|
'__run_num__': 4,
|
|
'comment': 'Command "echo A fifth" run',
|
|
'result': True,
|
|
'changes': True,
|
|
},
|
|
'cmd_|-B_|-echo B second_|-run': {
|
|
'__run_num__': 1,
|
|
'comment': 'Command "echo B second" run',
|
|
'result': True,
|
|
'changes': True,
|
|
},
|
|
'cmd_|-C_|-echo C third_|-run': {
|
|
'__run_num__': 2,
|
|
'comment': 'Command "echo C third" run',
|
|
'result': True,
|
|
'changes': True,
|
|
},
|
|
'cmd_|-D_|-echo D first_|-run': {
|
|
'__run_num__': 0,
|
|
'comment': 'Command "echo D first" run',
|
|
'result': True,
|
|
'changes': True,
|
|
},
|
|
'cmd_|-E_|-echo E fourth_|-run': {
|
|
'__run_num__': 3,
|
|
'comment': 'Command "echo E fourth" run',
|
|
'result': True,
|
|
'changes': True,
|
|
},
|
|
'cmd_|-F_|-echo F_|-run': {
|
|
'__run_num__': 5,
|
|
'comment': 'The following requisites were not found:\n'
|
|
+ ' require:\n'
|
|
+ ' foobar: A\n',
|
|
'result': False,
|
|
'changes': False,
|
|
},
|
|
'cmd_|-G_|-echo G_|-run': {
|
|
'__run_num__': 6,
|
|
'comment': 'The following requisites were not found:\n'
|
|
+ ' require:\n'
|
|
+ ' cmd: Z\n',
|
|
'result': False,
|
|
'changes': False,
|
|
},
|
|
'cmd_|-H_|-echo H_|-run': {
|
|
'__run_num__': 7,
|
|
'comment': 'The following requisites were not found:\n'
|
|
+ ' require:\n'
|
|
+ ' cmd: Z\n',
|
|
'result': False,
|
|
'changes': False,
|
|
}
|
|
}
|
|
ret = self.run_function('state.sls', mods='requisites.require')
|
|
result = self.normalize_ret(ret)
|
|
self.assertReturnNonEmptySaltType(ret)
|
|
self.assertEqual(expected_result, result)
|
|
|
|
ret = self.run_function('state.sls', mods='requisites.require_error1')
|
|
self.assertEqual(ret, [
|
|
"Cannot extend ID 'W' in 'base:requisites.require_error1'. It is not part of the high state.\nThis is likely due to a missing include statement or an incorrectly typed ID.\nEnsure that a state with an ID of 'W' is available\nin environment 'base' and to SLS 'requisites.require_error1'"
|
|
])
|
|
|
|
# issue #8235
|
|
# FIXME: Why is require enforcing list syntax while require_in does not?
|
|
# And why preventing it?
|
|
# Currently this state fails, should return C/B/A
|
|
result = {}
|
|
ret = self.run_function('state.sls', mods='requisites.require_simple_nolist')
|
|
self.assertEqual(ret, [
|
|
'The require statement in state \'B\' in SLS '
|
|
+ '\'requisites.require_simple_nolist\' needs to be formed as a list'
|
|
])
|
|
|
|
# commented until a fix is made for issue #8772
|
|
# TODO: this test actually fails
|
|
#ret = self.run_function('state.sls', mods='requisites.require_error2')
|
|
#self.assertEqual(ret, [
|
|
# 'Cannot extend state foobar for ID A in "base:requisites.require_error2".'
|
|
# + ' It is not part of the high state.'
|
|
#])
|
|
|
|
ret = self.run_function('state.sls', mods='requisites.require_recursion_error1')
|
|
self.assertEqual(
|
|
ret,
|
|
['A recursive requisite was found, SLS "requisites.require_recursion_error1" ID "B" ID "A"']
|
|
)
|
|
|
|
def test_requisites_full_sls(self):
|
|
'''
|
|
Teste the sls special command in requisites
|
|
'''
|
|
expected_result = {
|
|
'cmd_|-A_|-echo A_|-run': {
|
|
'__run_num__': 2,
|
|
'comment': 'Command "echo A" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-B_|-echo B_|-run': {
|
|
'__run_num__': 0,
|
|
'comment': 'Command "echo B" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-C_|-echo C_|-run': {
|
|
'__run_num__': 1,
|
|
'comment': 'Command "echo C" run',
|
|
'result': True,
|
|
'changes': True},
|
|
}
|
|
ret = self.run_function('state.sls', mods='requisites.fullsls_require')
|
|
self.assertReturnNonEmptySaltType(ret)
|
|
result = self.normalize_ret(ret)
|
|
self.assertEqual(expected_result, result)
|
|
|
|
# issue #8233: traceback on prereq sls
|
|
# TODO: not done
|
|
#ret = self.run_function('state.sls', mods='requisites.fullsls_prereq')
|
|
#self.assertEqual(['sls command can only be used with require requisite'], ret)
|
|
|
|
def test_requisites_prereq_simple_ordering_and_errors(self):
|
|
'''
|
|
Call sls file containing several prereq_in and prereq.
|
|
|
|
Ensure that some of them are failing and that the order is right.
|
|
'''
|
|
expected_result_simple = {
|
|
'cmd_|-A_|-echo A third_|-run': {
|
|
'__run_num__': 2,
|
|
'comment': 'Command "echo A third" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-B_|-echo B first_|-run': {
|
|
'__run_num__': 0,
|
|
'comment': 'Command "echo B first" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-C_|-echo C second_|-run': {
|
|
'__run_num__': 1,
|
|
'comment': 'Command "echo C second" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-I_|-echo I_|-run': {
|
|
'__run_num__': 3,
|
|
'comment': 'The following requisites were not found:\n'
|
|
+ ' prereq:\n'
|
|
+ ' cmd: Z\n',
|
|
'result': False,
|
|
'changes': False},
|
|
'cmd_|-J_|-echo J_|-run': {
|
|
'__run_num__': 4,
|
|
'comment': 'The following requisites were not found:\n'
|
|
+ ' prereq:\n'
|
|
+ ' foobar: A\n',
|
|
'result': False,
|
|
'changes': False}
|
|
}
|
|
expected_result_simple2 = {
|
|
'cmd_|-A_|-echo A_|-run': {
|
|
'__run_num__': 1,
|
|
'comment': 'Command "echo A" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-B_|-echo B_|-run': {
|
|
'__run_num__': 2,
|
|
'comment': 'Command "echo B" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-C_|-echo C_|-run': {
|
|
'__run_num__': 0,
|
|
'comment': 'Command "echo C" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-D_|-echo D_|-run': {
|
|
'__run_num__': 3,
|
|
'comment': 'Command "echo D" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-E_|-echo E_|-run': {
|
|
'__run_num__': 4,
|
|
'comment': 'Command "echo E" run',
|
|
'result': True,
|
|
'changes': True}
|
|
}
|
|
expected_result_simple3 = {
|
|
'cmd_|-A_|-echo A first_|-run': {
|
|
'__run_num__': 0,
|
|
'comment': 'Command "echo A first" run',
|
|
'result': True,
|
|
'changes': True,
|
|
},
|
|
'cmd_|-B_|-echo B second_|-run': {
|
|
'__run_num__': 1,
|
|
'comment': 'Command "echo B second" run',
|
|
'result': True,
|
|
'changes': True,
|
|
},
|
|
'cmd_|-C_|-echo C third_|-wait': {
|
|
'__run_num__': 2,
|
|
'comment': '',
|
|
'result': True,
|
|
'changes': False,
|
|
}
|
|
}
|
|
expected_result_complex = {
|
|
'cmd_|-A_|-echo A fourth_|-run': {
|
|
'__run_num__': 3,
|
|
'comment': 'Command "echo A fourth" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-B_|-echo B first_|-run': {
|
|
'__run_num__': 0,
|
|
'comment': 'Command "echo B first" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-C_|-echo C second_|-run': {
|
|
'__run_num__': 1,
|
|
'comment': 'Command "echo C second" run',
|
|
'result': True,
|
|
'changes': True},
|
|
'cmd_|-D_|-echo D third_|-run': {
|
|
'__run_num__': 2,
|
|
'comment': 'Command "echo D third" run',
|
|
'result': True,
|
|
'changes': True},
|
|
}
|
|
ret = self.run_function('state.sls', mods='requisites.prereq_simple')
|
|
self.assertReturnNonEmptySaltType(ret)
|
|
result = self.normalize_ret(ret)
|
|
self.assertEqual(expected_result_simple, result)
|
|
|
|
# same test, but not using lists in yaml syntax
|
|
# TODO: issue #8235, prereq ignored when not used in list syntax
|
|
# Currently fails badly with :
|
|
# TypeError encountered executing state.sls: string indices must be integers, not str.
|
|
#expected_result_simple.pop('cmd_|-I_|-echo I_|-run')
|
|
#expected_result_simple.pop('cmd_|-J_|-echo J_|-run')
|
|
#ret = self.run_function('state.sls', mods='requisites.prereq_simple_nolist')
|
|
#result = self.normalize_ret(ret)
|
|
#self.assertEqual(expected_result_simple, result)
|
|
|
|
ret = self.run_function('state.sls', mods='requisites.prereq_simple2')
|
|
result = self.normalize_ret(ret)
|
|
self.assertReturnNonEmptySaltType(ret)
|
|
self.assertEqual(expected_result_simple2, result)
|
|
|
|
ret = self.run_function('state.sls', mods='requisites.prereq_simple3')
|
|
result = self.normalize_ret(ret)
|
|
self.assertReturnNonEmptySaltType(ret)
|
|
self.assertEqual(expected_result_simple3, result)
|
|
|
|
#ret = self.run_function('state.sls', mods='requisites.prereq_error_nolist')
|
|
#self.assertEqual(
|
|
# ret,
|
|
# ['Cannot extend ID Z in "base:requisites.prereq_error_nolist".'
|
|
# + ' It is not part of the high state.']
|
|
#)
|
|
|
|
ret = self.run_function('state.sls', mods='requisites.prereq_compile_error1')
|
|
self.assertReturnNonEmptySaltType(ret)
|
|
self.assertEqual(
|
|
ret['cmd_|-B_|-echo B_|-run']['comment'],
|
|
'The following requisites were not found:\n'
|
|
+ ' prereq:\n'
|
|
+ ' foobar: A\n'
|
|
)
|
|
|
|
ret = self.run_function('state.sls', mods='requisites.prereq_compile_error2')
|
|
self.assertReturnNonEmptySaltType(ret)
|
|
self.assertEqual(
|
|
ret['cmd_|-B_|-echo B_|-run']['comment'],
|
|
'The following requisites were not found:\n'
|
|
+ ' prereq:\n'
|
|
+ ' foobar: C\n'
|
|
)
|
|
|
|
ret = self.run_function('state.sls', mods='requisites.prereq_complex')
|
|
result = self.normalize_ret(ret)
|
|
self.assertEqual(expected_result_complex, result)
|
|
|
|
# issue #8210 : prereq recursion undetected
|
|
# TODO: this test fails
|
|
#ret = self.run_function('state.sls', mods='requisites.prereq_recursion_error')
|
|
#self.assertEqual(
|
|
# ret,
|
|
# ['A recursive requisite was found, SLS "requisites.prereq_recursion_error" ID "B" ID "A"']
|
|
#)
|
|
def test_infinite_recursion_sls_prereq(self):
|
|
ret = self.run_function('state.sls', mods='requisites.prereq_sls_infinite_recursion')
|
|
self.assertSaltTrueReturn(ret)
|
|
|
|
def test_requisites_use(self):
|
|
'''
|
|
Call sls file containing several use_in and use.
|
|
|
|
'''
|
|
# TODO issue #8235 & #8774 some examples are still commented in the test file
|
|
ret = self.run_function('state.sls', mods='requisites.use')
|
|
self.assertReturnNonEmptySaltType(ret)
|
|
for item, descr in six.iteritems(ret):
|
|
self.assertEqual(descr['comment'], 'onlyif execution failed')
|
|
|
|
# TODO: issue #8802 : use recursions undetected
|
|
# issue is closed as use does not actually inherit requisites
|
|
# if chain-use is added after #8774 resolution theses tests would maybe become useful
|
|
#ret = self.run_function('state.sls', mods='requisites.use_recursion')
|
|
#self.assertEqual(ret, [
|
|
# 'A recursive requisite was found, SLS "requisites.use_recursion"'
|
|
# + ' ID "B" ID "A"'
|
|
#])
|
|
|
|
#ret = self.run_function('state.sls', mods='requisites.use_recursion2')
|
|
#self.assertEqual(ret, [
|
|
# 'A recursive requisite was found, SLS "requisites.use_recursion2"'
|
|
# + ' ID "C" ID "A"'
|
|
#])
|
|
|
|
#ret = self.run_function('state.sls', mods='requisites.use_auto_recursion')
|
|
#self.assertEqual(ret, [
|
|
# 'A recursive requisite was found, SLS "requisites.use_recursion"'
|
|
# + ' ID "A" ID "A"'
|
|
#])
|
|
|
|
def test_get_file_from_env_in_top_match(self):
|
|
tgt = os.path.join(TMP, 'prod-cheese-file')
|
|
try:
|
|
ret = self.run_function(
|
|
'state.highstate', minion_tgt='sub_minion'
|
|
)
|
|
self.assertSaltTrueReturn(ret)
|
|
self.assertTrue(os.path.isfile(tgt))
|
|
with salt.utils.fopen(tgt, 'r') as cheese:
|
|
data = cheese.read()
|
|
self.assertIn('Gromit', data)
|
|
self.assertIn('Comte', data)
|
|
finally:
|
|
os.unlink(tgt)
|
|
|
|
# onchanges tests
|
|
|
|
def test_onchanges_requisite(self):
|
|
'''
|
|
Tests a simple state using the onchanges requisite
|
|
'''
|
|
|
|
# Only run the state once and keep the return data
|
|
state_run = self.run_function('state.sls', mods='requisites.onchanges_simple')
|
|
|
|
# First, test the result of the state run when changes are expected to happen
|
|
test_data = state_run['cmd_|-test_changing_state_|-echo "Success!"_|-run']['comment']
|
|
expected_result = 'Command "echo "Success!"" run'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
# Then, test the result of the state run when changes are not expected to happen
|
|
test_data = state_run['cmd_|-test_non_changing_state_|-echo "Should not run"_|-run']['comment']
|
|
expected_result = 'State was not run because none of the onchanges reqs changed'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
def test_onchanges_requisite_multiple(self):
|
|
'''
|
|
Tests a simple state using the onchanges requisite
|
|
'''
|
|
|
|
# Only run the state once and keep the return data
|
|
state_run = self.run_function('state.sls',
|
|
mods='requisites.onchanges_multiple')
|
|
|
|
# First, test the result of the state run when two changes are expected to happen
|
|
test_data = state_run['cmd_|-test_two_changing_states_|-echo "Success!"_|-run']['comment']
|
|
expected_result = 'Command "echo "Success!"" run'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
# Then, test the result of the state run when two changes are not expected to happen
|
|
test_data = state_run['cmd_|-test_two_non_changing_states_|-echo "Should not run"_|-run']['comment']
|
|
expected_result = 'State was not run because none of the onchanges reqs changed'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
# Finally, test the result of the state run when only one of the onchanges requisites changes.
|
|
test_data = state_run['cmd_|-test_one_changing_state_|-echo "Success!"_|-run']['comment']
|
|
expected_result = 'Command "echo "Success!"" run'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
def test_onchanges_in_requisite(self):
|
|
'''
|
|
Tests a simple state using the onchanges_in requisite
|
|
'''
|
|
|
|
# Only run the state once and keep the return data
|
|
state_run = self.run_function('state.sls', mods='requisites.onchanges_in_simple')
|
|
|
|
# First, test the result of the state run of when changes are expected to happen
|
|
test_data = state_run['cmd_|-test_changes_expected_|-echo "Success!"_|-run']['comment']
|
|
expected_result = 'Command "echo "Success!"" run'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
# Then, test the result of the state run when changes are not expected to happen
|
|
test_data = state_run['cmd_|-test_changes_not_expected_|-echo "Should not run"_|-run']['comment']
|
|
expected_result = 'State was not run because none of the onchanges reqs changed'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
# onfail tests
|
|
|
|
def test_onfail_requisite(self):
|
|
'''
|
|
Tests a simple state using the onfail requisite
|
|
'''
|
|
|
|
# Only run the state once and keep the return data
|
|
state_run = self.run_function('state.sls', mods='requisites.onfail_simple')
|
|
|
|
# First, test the result of the state run when a failure is expected to happen
|
|
test_data = state_run['cmd_|-test_failing_state_|-echo "Success!"_|-run']['comment']
|
|
expected_result = 'Command "echo "Success!"" run'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
# Then, test the result of the state run when a failure is not expected to happen
|
|
test_data = state_run['cmd_|-test_non_failing_state_|-echo "Should not run"_|-run']['comment']
|
|
expected_result = 'State was not run because onfail req did not change'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
def test_multiple_onfail_requisite(self):
|
|
'''
|
|
test to ensure state is run even if only one
|
|
of the onfails fails. This is a test for the issue:
|
|
https://github.com/saltstack/salt/issues/22370
|
|
'''
|
|
|
|
state_run = self.run_function('state.sls', mods='requisites.onfail_multiple')
|
|
|
|
retcode = state_run['cmd_|-c_|-echo itworked_|-run']['changes']['retcode']
|
|
self.assertEqual(retcode, 0)
|
|
|
|
stdout = state_run['cmd_|-c_|-echo itworked_|-run']['changes']['stdout']
|
|
self.assertEqual(stdout, 'itworked')
|
|
|
|
def test_onfail_in_requisite(self):
|
|
'''
|
|
Tests a simple state using the onfail_in requisite
|
|
'''
|
|
|
|
# Only run the state once and keep the return data
|
|
state_run = self.run_function('state.sls', mods='requisites.onfail_in_simple')
|
|
|
|
# First, test the result of the state run when a failure is expected to happen
|
|
test_data = state_run['cmd_|-test_failing_state_|-echo "Success!"_|-run']['comment']
|
|
expected_result = 'Command "echo "Success!"" run'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
# Then, test the result of the state run when a failure is not expected to happen
|
|
test_data = state_run['cmd_|-test_non_failing_state_|-echo "Should not run"_|-run']['comment']
|
|
expected_result = 'State was not run because onfail req did not change'
|
|
self.assertIn(expected_result, test_data)
|
|
|
|
# listen tests
|
|
|
|
def test_listen_requisite(self):
|
|
'''
|
|
Tests a simple state using the listen requisite
|
|
'''
|
|
|
|
# Only run the state once and keep the return data
|
|
state_run = self.run_function('state.sls', mods='requisites.listen_simple')
|
|
|
|
# First, test the result of the state run when a listener is expected to trigger
|
|
listener_state = 'cmd_|-listener_test_listening_change_state_|-echo "Listening State"_|-mod_watch'
|
|
self.assertIn(listener_state, state_run)
|
|
|
|
# Then, test the result of the state run when a listener should not trigger
|
|
absent_state = 'cmd_|-listener_test_listening_non_changing_state_|-echo "Only run once"_|-mod_watch'
|
|
self.assertNotIn(absent_state, state_run)
|
|
|
|
def test_listen_in_requisite(self):
|
|
'''
|
|
Tests a simple state using the listen_in requisite
|
|
'''
|
|
|
|
# Only run the state once and keep the return data
|
|
state_run = self.run_function('state.sls', mods='requisites.listen_in_simple')
|
|
|
|
# First, test the result of the state run when a listener is expected to trigger
|
|
listener_state = 'cmd_|-listener_test_listening_change_state_|-echo "Listening State"_|-mod_watch'
|
|
self.assertIn(listener_state, state_run)
|
|
|
|
# Then, test the result of the state run when a listener should not trigger
|
|
absent_state = 'cmd_|-listener_test_listening_non_changing_state_|-echo "Only run once"_|-mod_watch'
|
|
self.assertNotIn(absent_state, state_run)
|
|
|
|
def test_listen_in_requisite_resolution(self):
|
|
'''
|
|
Verify listen_in requisite lookups use ID declaration to check for changes
|
|
'''
|
|
|
|
# Only run the state once and keep the return data
|
|
state_run = self.run_function('state.sls', mods='requisites.listen_in_simple')
|
|
|
|
# Test the result of the state run when a listener is expected to trigger
|
|
listener_state = 'cmd_|-listener_test_listen_in_resolution_|-echo "Successful listen_in resolution"_|-mod_watch'
|
|
self.assertIn(listener_state, state_run)
|
|
|
|
def test_listen_requisite_resolution(self):
|
|
'''
|
|
Verify listen requisite lookups use ID declaration to check for changes
|
|
'''
|
|
|
|
# Only run the state once and keep the return data
|
|
state_run = self.run_function('state.sls', mods='requisites.listen_simple')
|
|
|
|
# Both listeners are expected to trigger
|
|
listener_state = 'cmd_|-listener_test_listening_resolution_one_|-echo "Successful listen resolution"_|-mod_watch'
|
|
self.assertIn(listener_state, state_run)
|
|
|
|
listener_state = 'cmd_|-listener_test_listening_resolution_two_|-echo "Successful listen resolution"_|-mod_watch'
|
|
self.assertIn(listener_state, state_run)
|
|
|
|
def test_issue_30820_requisite_in_match_by_name(self):
|
|
'''
|
|
This tests the case where a requisite_in matches by name instead of ID
|
|
|
|
See https://github.com/saltstack/salt/issues/30820 for more info
|
|
'''
|
|
state_run = self.run_function(
|
|
'state.sls',
|
|
mods='requisites.requisite_in_match_by_name'
|
|
)
|
|
bar_state = 'cmd_|-bar state_|-echo bar_|-wait'
|
|
|
|
self.assertIn(bar_state, state_run)
|
|
self.assertEqual(state_run[bar_state]['comment'],
|
|
'Command "echo bar" run')
|
|
|
|
def test_retry_option_defaults(self):
|
|
'''
|
|
test the retry option on a simple state with defaults
|
|
ensure comment is as expected
|
|
ensure state duration is greater than default retry_interval (30 seconds)
|
|
'''
|
|
state_run = self.run_function(
|
|
'state.sls',
|
|
mods='retry.retry_defaults'
|
|
)
|
|
retry_state = 'file_|-file_test_|-/path/to/a/non-existent/file.txt_|-exists'
|
|
expected_comment = ('Attempt 1: Returned a result of "False", with the following '
|
|
'comment: "Specified path /path/to/a/non-existent/file.txt does not exist"\n'
|
|
'Specified path /path/to/a/non-existent/file.txt does not exist')
|
|
self.assertEqual(state_run[retry_state]['comment'], expected_comment)
|
|
self.assertTrue(state_run[retry_state]['duration'] > 30)
|
|
self.assertEqual(state_run[retry_state]['result'], False)
|
|
|
|
def test_retry_option_custom(self):
|
|
'''
|
|
test the retry option on a simple state with custom retry values
|
|
ensure comment is as expected
|
|
ensure state duration is greater than custom defined interval * (retries - 1)
|
|
'''
|
|
state_run = self.run_function(
|
|
'state.sls',
|
|
mods='retry.retry_custom'
|
|
)
|
|
retry_state = 'file_|-file_test_|-/path/to/a/non-existent/file.txt_|-exists'
|
|
expected_comment = ('Attempt 1: Returned a result of "False", with the following '
|
|
'comment: "Specified path /path/to/a/non-existent/file.txt does not exist"\n'
|
|
'Attempt 2: Returned a result of "False", with the following comment: "Specified'
|
|
' path /path/to/a/non-existent/file.txt does not exist"\nAttempt 3: Returned'
|
|
' a result of "False", with the following comment: "Specified path'
|
|
' /path/to/a/non-existent/file.txt does not exist"\nAttempt 4: Returned a'
|
|
' result of "False", with the following comment: "Specified path'
|
|
' /path/to/a/non-existent/file.txt does not exist"\nSpecified path'
|
|
' /path/to/a/non-existent/file.txt does not exist')
|
|
self.assertEqual(state_run[retry_state]['comment'], expected_comment)
|
|
self.assertTrue(state_run[retry_state]['duration'] > 40)
|
|
self.assertEqual(state_run[retry_state]['result'], False)
|
|
|
|
def test_retry_option_success(self):
|
|
'''
|
|
test a state with the retry option that should return True immedietly (i.e. no retries)
|
|
'''
|
|
testfile = os.path.join(TMP, 'retry_file')
|
|
state_run = self.run_function(
|
|
'state.sls',
|
|
mods='retry.retry_success'
|
|
)
|
|
os.unlink(testfile)
|
|
retry_state = 'file_|-file_test_|-{0}_|-exists'.format(testfile)
|
|
self.assertNotIn('Attempt', state_run[retry_state]['comment'])
|
|
|
|
def run_create(self):
|
|
'''
|
|
helper function to wait 30 seconds and then create the temp retry file
|
|
'''
|
|
testfile = os.path.join(TMP, 'retry_file')
|
|
time.sleep(30)
|
|
open(testfile, 'a').close() # pylint: disable=resource-leakage
|
|
|
|
def test_retry_option_eventual_success(self):
|
|
'''
|
|
test a state with the retry option that should return True after at least 4 retry attmempt
|
|
but never run 15 attempts
|
|
'''
|
|
testfile = os.path.join(TMP, 'retry_file')
|
|
create_thread = threading.Thread(target=self.run_create)
|
|
create_thread.start()
|
|
state_run = self.run_function(
|
|
'state.sls',
|
|
mods='retry.retry_success2'
|
|
)
|
|
retry_state = 'file_|-file_test_|-{0}_|-exists'.format(testfile)
|
|
self.assertIn('Attempt 1:', state_run[retry_state]['comment'])
|
|
self.assertIn('Attempt 2:', state_run[retry_state]['comment'])
|
|
self.assertIn('Attempt 3:', state_run[retry_state]['comment'])
|
|
self.assertIn('Attempt 4:', state_run[retry_state]['comment'])
|
|
self.assertNotIn('Attempt 15:', state_run[retry_state]['comment'])
|
|
self.assertEqual(state_run[retry_state]['result'], True)
|
|
|
|
def test_issue_38683_require_order_failhard_combination(self):
|
|
'''
|
|
This tests the case where require, order, and failhard are all used together in a state definition.
|
|
|
|
Previously, the order option, which used in tandem with require and failhard, would cause the state
|
|
compiler to stacktrace. This exposed a logic error in the ``check_failhard`` function of the state
|
|
compiler. With the logic error resolved, this test should now pass.
|
|
|
|
See https://github.com/saltstack/salt/issues/38683 for more information.
|
|
'''
|
|
state_run = self.run_function(
|
|
'state.sls',
|
|
mods='requisites.require_order_failhard_combo'
|
|
)
|
|
state_id = 'test_|-b_|-b_|-fail_with_changes'
|
|
|
|
self.assertIn(state_id, state_run)
|
|
self.assertEqual(state_run[state_id]['comment'], 'Failure!')
|
|
self.assertFalse(state_run[state_id]['result'])
|