mirror of
https://github.com/valitydev/salt.git
synced 2024-11-07 17:09:03 +00:00
8474006dab
Modifies the fibre_channel.py grain for linux to allow mocking. You can't mock a file handle used in a for loop. Fixes the mocking in test_windows_iscsi_iqn_grains. Apparently, you can't stack multiple mocks in the same with statement.
95 lines
3.6 KiB
Python
95 lines
3.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
'''
|
|
:codeauthor: :email:`Shane Lee <slee@saltstack.com>`
|
|
'''
|
|
# Import Python libs
|
|
from __future__ import absolute_import, print_function, unicode_literals
|
|
import os
|
|
|
|
# Import Salt Testing Libs
|
|
from tests.support.unit import TestCase, skipIf
|
|
from tests.support.mock import (
|
|
patch,
|
|
mock_open,
|
|
MagicMock,
|
|
NO_MOCK,
|
|
NO_MOCK_REASON
|
|
)
|
|
|
|
# Import Salt Libs
|
|
import salt.grains.iscsi as iscsi
|
|
|
|
|
|
@skipIf(NO_MOCK, NO_MOCK_REASON)
|
|
class IscsiGrainsTestCase(TestCase):
|
|
'''
|
|
Test cases for iscsi grains
|
|
'''
|
|
def test_windows_iscsi_iqn_grains(self):
|
|
cmd_run_mock = MagicMock(
|
|
return_value={'stdout': 'iSCSINodeName\n'
|
|
'iqn.1991-05.com.microsoft:simon-x1\n'}
|
|
)
|
|
_grains = {}
|
|
with patch('salt.utils.path.which', MagicMock(return_value=True)):
|
|
with patch('salt.modules.cmdmod.run_all', cmd_run_mock):
|
|
_grains['iscsi_iqn'] = iscsi._windows_iqn()
|
|
|
|
self.assertEqual(_grains.get('iscsi_iqn'),
|
|
['iqn.1991-05.com.microsoft:simon-x1'])
|
|
|
|
def test_aix_iscsi_iqn_grains(self):
|
|
cmd_run_mock = MagicMock(
|
|
return_value='initiator_name iqn.localhost.hostid.7f000001'
|
|
)
|
|
|
|
_grains = {}
|
|
with patch('salt.modules.cmdmod.run', cmd_run_mock):
|
|
_grains['iscsi_iqn'] = iscsi._aix_iqn()
|
|
|
|
self.assertEqual(_grains.get('iscsi_iqn'),
|
|
['iqn.localhost.hostid.7f000001'])
|
|
|
|
def test_linux_iscsi_iqn_grains(self):
|
|
_iscsi_file = '## DO NOT EDIT OR REMOVE THIS FILE!\n' \
|
|
'## If you remove this file, the iSCSI daemon will not start.\n' \
|
|
'## If you change the InitiatorName, existing access control lists\n' \
|
|
'## may reject this initiator. The InitiatorName must be unique\n' \
|
|
'## for each iSCSI initiator. Do NOT duplicate iSCSI InitiatorNames.\n' \
|
|
'InitiatorName=iqn.1993-08.org.debian:01:d12f7aba36\n'
|
|
|
|
with patch('salt.utils.files.fopen', mock_open()) as iscsi_initiator_file:
|
|
iscsi_initiator_file.return_value.__iter__.return_value = _iscsi_file.splitlines()
|
|
iqn = iscsi._linux_iqn()
|
|
|
|
assert isinstance(iqn, list)
|
|
assert len(iqn) == 1
|
|
assert iqn == ['iqn.1993-08.org.debian:01:d12f7aba36']
|
|
|
|
@patch('salt.utils.files.fopen', MagicMock(side_effect=IOError(os.errno.EPERM,
|
|
'The cables are not the same length.')))
|
|
@patch('salt.grains.iscsi.log', MagicMock())
|
|
def test_linux_iqn_non_root(self):
|
|
'''
|
|
Test if linux_iqn is running on salt-master as non-root
|
|
and handling access denial properly.
|
|
:return:
|
|
'''
|
|
assert iscsi._linux_iqn() == []
|
|
iscsi.log.debug.assert_called()
|
|
assert 'Error while accessing' in iscsi.log.debug.call_args[0][0]
|
|
assert 'cables are not the same' in iscsi.log.debug.call_args[0][2].strerror
|
|
assert iscsi.log.debug.call_args[0][2].errno == os.errno.EPERM
|
|
assert iscsi.log.debug.call_args[0][1] == '/etc/iscsi/initiatorname.iscsi'
|
|
|
|
@patch('salt.utils.files.fopen', MagicMock(side_effect=IOError(os.errno.ENOENT, '')))
|
|
@patch('salt.grains.iscsi.log', MagicMock())
|
|
def test_linux_iqn_no_iscsii_initiator(self):
|
|
'''
|
|
Test if linux_iqn is running on salt-master as root.
|
|
iscsii initiator is not there accessible or is not supported.
|
|
:return:
|
|
'''
|
|
assert iscsi._linux_iqn() == []
|
|
iscsi.log.debug.assert_not_called()
|