mirror of
https://github.com/valitydev/salt.git
synced 2024-11-07 08:58:59 +00:00
3184168365
This PR is part of what will be an ongoing effort to use explicit unicode strings in Salt. Because Python 3 does not suport Python 2's raw unicode string syntax (i.e. `ur'\d+'`), we must use `salt.utils.locales.sdecode()` to ensure that the raw string is unicode. However, because of how `salt/utils/__init__.py` has evolved into the hulking monstrosity it is today, this means importing a large module in places where it is not needed, which could negatively impact performance. For this reason, this PR also breaks out some of the functions from `salt/utils/__init__.py` into new/existing modules under `salt/utils/`. The long term goal will be that the modules within this directory do not depend on importing `salt.utils`. A summary of the changes in this PR is as follows: * Moves the following functions from `salt.utils` to new locations (including a deprecation warning if invoked from `salt.utils`): `to_bytes`, `to_str`, `to_unicode`, `str_to_num`, `is_quoted`, `dequote`, `is_hex`, `is_bin_str`, `rand_string`, `contains_whitespace`, `clean_kwargs`, `invalid_kwargs`, `which`, `which_bin`, `path_join`, `shlex_split`, `rand_str`, `is_windows`, `is_proxy`, `is_linux`, `is_darwin`, `is_sunos`, `is_smartos`, `is_smartos_globalzone`, `is_smartos_zone`, `is_freebsd`, `is_netbsd`, `is_openbsd`, `is_aix` * Moves the functions already deprecated by @rallytime to the bottom of `salt/utils/__init__.py` for better organization, so we can keep the deprecated ones separate from the ones yet to be deprecated as we continue to break up `salt.utils` * Updates `salt/*.py` and all files under `salt/client/` to use explicit unicode string literals. * Gets rid of implicit imports of `salt.utils` (e.g. `from salt.utils import foo` becomes `import salt.utils.foo as foo`). * Renames the `test.rand_str` function to `test.random_hash` to more accurately reflect what it does * Modifies `salt.utils.stringutils.random()` (née `salt.utils.rand_string()`) such that it returns a string matching the passed size. Previously this function would get `size` bytes from `os.urandom()`, base64-encode it, and return the result, which would in most cases not be equal to the passed size.
90 lines
2.5 KiB
Python
90 lines
2.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
'''
|
|
integration tests for mac_pkgutil
|
|
'''
|
|
|
|
# Import Python libs
|
|
from __future__ import absolute_import
|
|
import os
|
|
|
|
# Import Salt Testing libs
|
|
from tests.support.case import ModuleCase
|
|
from tests.support.paths import TMP
|
|
from tests.support.helpers import destructiveTest, skip_if_not_root
|
|
|
|
# Import Salt libs
|
|
import salt.utils.path
|
|
import salt.utils.platform
|
|
|
|
TEST_PKG_URL = 'https://distfiles.macports.org/MacPorts/MacPorts-2.3.4-10.11-ElCapitan.pkg'
|
|
TEST_PKG_NAME = 'org.macports.MacPorts'
|
|
TEST_PKG = os.path.join(TMP, 'MacPorts-2.3.4-10.11-ElCapitan.pkg')
|
|
|
|
|
|
@skip_if_not_root
|
|
class MacPkgutilModuleTest(ModuleCase):
|
|
'''
|
|
Validate the mac_pkgutil module
|
|
'''
|
|
|
|
def setUp(self):
|
|
'''
|
|
Get current settings
|
|
'''
|
|
if not salt.utils.platform.is_darwin():
|
|
self.skipTest('Test only available on macOS')
|
|
|
|
if not salt.utils.path.which('pkgutil'):
|
|
self.skipTest('Test requires pkgutil binary')
|
|
|
|
def tearDown(self):
|
|
'''
|
|
Reset to original settings
|
|
'''
|
|
self.run_function('pkgutil.forget', ['org.macports.MacPorts'])
|
|
self.run_function('file.remove', ['/opt/local'])
|
|
|
|
def test_list(self):
|
|
'''
|
|
Test pkgutil.list
|
|
'''
|
|
self.assertIsInstance(self.run_function('pkgutil.list'), list)
|
|
self.assertIn('com.apple.pkg.BaseSystemResources',
|
|
self.run_function('pkgutil.list'))
|
|
|
|
def test_is_installed(self):
|
|
'''
|
|
Test pkgutil.is_installed
|
|
'''
|
|
# Test Package is installed
|
|
self.assertTrue(
|
|
self.run_function('pkgutil.is_installed',
|
|
['com.apple.pkg.BaseSystemResources']))
|
|
|
|
# Test Package is not installed
|
|
self.assertFalse(
|
|
self.run_function('pkgutil.is_installed', ['spongebob']))
|
|
|
|
@destructiveTest
|
|
def test_install_forget(self):
|
|
'''
|
|
Test pkgutil.install
|
|
Test pkgutil.forget
|
|
'''
|
|
# Test if installed
|
|
self.assertFalse(
|
|
self.run_function('pkgutil.is_installed', [TEST_PKG_NAME]))
|
|
|
|
# Download the package
|
|
self.run_function('cp.get_url', [TEST_PKG_URL, TEST_PKG])
|
|
|
|
# Test install
|
|
self.assertTrue(
|
|
self.run_function('pkgutil.install', [TEST_PKG, TEST_PKG_NAME]))
|
|
self.assertIn(
|
|
'Unsupported scheme',
|
|
self.run_function('pkgutil.install', ['ftp://test', 'spongebob']))
|
|
|
|
# Test forget
|
|
self.assertTrue(self.run_function('pkgutil.forget', [TEST_PKG_NAME]))
|