mirror of
https://github.com/valitydev/salt.git
synced 2024-11-08 09:23:56 +00:00
3184168365
This PR is part of what will be an ongoing effort to use explicit unicode strings in Salt. Because Python 3 does not suport Python 2's raw unicode string syntax (i.e. `ur'\d+'`), we must use `salt.utils.locales.sdecode()` to ensure that the raw string is unicode. However, because of how `salt/utils/__init__.py` has evolved into the hulking monstrosity it is today, this means importing a large module in places where it is not needed, which could negatively impact performance. For this reason, this PR also breaks out some of the functions from `salt/utils/__init__.py` into new/existing modules under `salt/utils/`. The long term goal will be that the modules within this directory do not depend on importing `salt.utils`. A summary of the changes in this PR is as follows: * Moves the following functions from `salt.utils` to new locations (including a deprecation warning if invoked from `salt.utils`): `to_bytes`, `to_str`, `to_unicode`, `str_to_num`, `is_quoted`, `dequote`, `is_hex`, `is_bin_str`, `rand_string`, `contains_whitespace`, `clean_kwargs`, `invalid_kwargs`, `which`, `which_bin`, `path_join`, `shlex_split`, `rand_str`, `is_windows`, `is_proxy`, `is_linux`, `is_darwin`, `is_sunos`, `is_smartos`, `is_smartos_globalzone`, `is_smartos_zone`, `is_freebsd`, `is_netbsd`, `is_openbsd`, `is_aix` * Moves the functions already deprecated by @rallytime to the bottom of `salt/utils/__init__.py` for better organization, so we can keep the deprecated ones separate from the ones yet to be deprecated as we continue to break up `salt.utils` * Updates `salt/*.py` and all files under `salt/client/` to use explicit unicode string literals. * Gets rid of implicit imports of `salt.utils` (e.g. `from salt.utils import foo` becomes `import salt.utils.foo as foo`). * Renames the `test.rand_str` function to `test.random_hash` to more accurately reflect what it does * Modifies `salt.utils.stringutils.random()` (née `salt.utils.rand_string()`) such that it returns a string matching the passed size. Previously this function would get `size` bytes from `os.urandom()`, base64-encode it, and return the result, which would in most cases not be equal to the passed size.
59 lines
1.8 KiB
Python
59 lines
1.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
'''
|
|
Tests for the service state
|
|
'''
|
|
# Import python libs
|
|
from __future__ import absolute_import
|
|
|
|
# Import Salt Testing libs
|
|
from tests.support.case import ModuleCase
|
|
from tests.support.unit import skipIf
|
|
from tests.support.helpers import destructiveTest
|
|
from tests.support.mixins import SaltReturnAssertsMixin
|
|
|
|
# Import salt libs
|
|
import salt.utils.path
|
|
|
|
INIT_DELAY = 5
|
|
SERVICE_NAME = 'crond'
|
|
|
|
|
|
@destructiveTest
|
|
@skipIf(salt.utils.path.which('crond') is None, 'crond not installed')
|
|
class ServiceTest(ModuleCase, SaltReturnAssertsMixin):
|
|
'''
|
|
Validate the service state
|
|
'''
|
|
def check_service_status(self, exp_return):
|
|
'''
|
|
helper method to check status of service
|
|
'''
|
|
check_status = self.run_function('service.status', name=SERVICE_NAME)
|
|
if check_status is not exp_return:
|
|
self.fail('status of service is not returning correctly')
|
|
|
|
def test_service_dead(self):
|
|
'''
|
|
test service.dead state module
|
|
'''
|
|
start_service = self.run_state('service.running', name=SERVICE_NAME)
|
|
self.assertSaltTrueReturn(start_service)
|
|
self.check_service_status(True)
|
|
|
|
ret = self.run_state('service.dead', name=SERVICE_NAME)
|
|
self.assertSaltTrueReturn(ret)
|
|
self.check_service_status(False)
|
|
|
|
def test_service_dead_init_delay(self):
|
|
'''
|
|
test service.dead state module with init_delay arg
|
|
'''
|
|
start_service = self.run_state('service.running', name=SERVICE_NAME)
|
|
self.assertSaltTrueReturn(start_service)
|
|
self.check_service_status(True)
|
|
|
|
ret = self.run_state('service.dead', name=SERVICE_NAME,
|
|
init_delay=INIT_DELAY)
|
|
self.assertSaltTrueReturn(ret)
|
|
self.check_service_status(False)
|