When adding the cp.get_file function, we need to add it into the list of
mock functions in the unit test along with get_template or the unit
tests will fail.
In the JunOS modules os_install is designed to install operating system
images to the device. The current code uses get_template to upload the
OS image file to the device. This does not work because get_template
attempts to load the entire file into memory so that it can process any
template directives inside the file. The typical JunOS files are so large
that they cause a MemoryError exception in Python.
I can think of no circumstances where it would be useful to template an
OS image file. Any changes you make to it will break the internal
checksums and cause upgrades to break. Therefore, I have changed the
code to use get_file which does not have the problem with large files.
This code has been tested in my lab with JunOS 15.1X53-D55.5 version
upgrades on EX2300 switches.
This reverts most of #40934. The only thing that should have been fixed there was the spurious warning message.
The logic in calculating which nameserver grains is not correct. It merely overwrites what is returned by
salt.utils.dns.parse_resolv instead of choosing what to include.
As a result of that error, in the case where ipv6 is exempted, we don't string-ify the nameserver in the
list comprehension, which in term passes a non-parseable object to the msgpack serializer which results
in a totally broken minion.
I chose not to fix the logic in the block mentioned above because in doing so, we'd remove other items
from the dictionary which are already present which could break some users. We'll have to carefully evaluate
how to accomplish this going forward.
- bogus: missing-whitespace-after-comma... there are so commas!
- desired: broad exception catching on the basis that I don't know
what exceptions may happen here yet.
This fixes the bug that ssh.host_keys non-deterministically returns either the
public key or the certificate.
It also adds a parameter like `private` to ignore certificates.
This config file enables the [probot-stale](https://github.com/probot/stale/)
bot to comment on stale issues. We're starting off with issues
that have become stale after approximately 3 years and 6 months.
This value is configured in the `daysUntilStale` setting.
